* [RESEND] Bluetooth: btrtl: Add support for RTL8852BS
@ 2023-02-06 6:33 Victor Hassan
2023-02-06 7:01 ` bluez.test.bot
2023-02-06 10:03 ` Paul Menzel
0 siblings, 2 replies; 4+ messages in thread
From: Victor Hassan @ 2023-02-06 6:33 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz; +Cc: linux-bluetooth, linux-kernel
Add the support for RTL8852BS BT controller on UART interface.
The necessary firmware file will be submitted to linux-firmware.
Signed-off-by: Victor Hassan <victor@allwinnertech.com>
---
drivers/bluetooth/btrtl.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 69c3fe649ca7..36c3a23324f8 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -198,6 +198,14 @@ static const struct id_table ic_id_table[] = {
.fw_name = "rtl_bt/rtl8852bu_fw.bin",
.cfg_name = "rtl_bt/rtl8852bu_config" },
+ /* 8852B with UART interface */
+ { IC_INFO(RTL_ROM_LMP_8852A, 0xb, 0xb, HCI_UART),
+ .config_needed = true,
+ .has_rom_version = true,
+ .has_msft_ext = true,
+ .fw_name = "rtl_bt/rtl8852bs_fw.bin",
+ .cfg_name = "rtl_bt/rtl8852bs_config" },
+
/* 8852C */
{ IC_INFO(RTL_ROM_LMP_8852A, 0xc, 0xc, HCI_USB),
.config_needed = false,
@@ -965,5 +973,7 @@ MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852au_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852bu_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852bu_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8852bs_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8852bs_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852cu_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852cu_config.bin");
--
2.29.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [RESEND] Bluetooth: btrtl: Add support for RTL8852BS
2023-02-06 6:33 [RESEND] Bluetooth: btrtl: Add support for RTL8852BS Victor Hassan
@ 2023-02-06 7:01 ` bluez.test.bot
2023-02-06 10:03 ` Paul Menzel
1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2023-02-06 7:01 UTC (permalink / raw)
To: linux-bluetooth, victor
[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=719009
---Test result---
Test Summary:
CheckPatch PASS 0.98 seconds
GitLint PASS 0.37 seconds
SubjectPrefix PASS 0.11 seconds
BuildKernel PASS 31.72 seconds
CheckAllWarning PASS 34.55 seconds
CheckSparse WARNING 38.58 seconds
CheckSmatch WARNING 107.40 seconds
BuildKernel32 PASS 30.13 seconds
TestRunnerSetup PASS 434.48 seconds
TestRunner_l2cap-tester PASS 16.45 seconds
TestRunner_iso-tester PASS 16.78 seconds
TestRunner_bnep-tester PASS 5.42 seconds
TestRunner_mgmt-tester PASS 109.76 seconds
TestRunner_rfcomm-tester PASS 8.72 seconds
TestRunner_sco-tester PASS 8.08 seconds
TestRunner_ioctl-tester PASS 9.43 seconds
TestRunner_mesh-tester PASS 6.93 seconds
TestRunner_smp-tester PASS 7.90 seconds
TestRunner_userchan-tester PASS 5.72 seconds
IncrementalBuild PASS 28.52 seconds
Details
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND] Bluetooth: btrtl: Add support for RTL8852BS
2023-02-06 6:33 [RESEND] Bluetooth: btrtl: Add support for RTL8852BS Victor Hassan
2023-02-06 7:01 ` bluez.test.bot
@ 2023-02-06 10:03 ` Paul Menzel
2023-02-14 6:23 ` Victor Hassan
1 sibling, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2023-02-06 10:03 UTC (permalink / raw)
To: Victor Hassan
Cc: marcel, johan.hedberg, luiz.dentz, linux-bluetooth, linux-kernel
Dear Victor,
Thank you for your patch.
Am 06.02.23 um 07:33 schrieb Victor Hassan:
> Add the support for RTL8852BS BT controller on UART interface.
> The necessary firmware file will be submitted to linux-firmware.
>
> Signed-off-by: Victor Hassan <victor@allwinnertech.com>
> ---
> drivers/bluetooth/btrtl.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 69c3fe649ca7..36c3a23324f8 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -198,6 +198,14 @@ static const struct id_table ic_id_table[] = {
> .fw_name = "rtl_bt/rtl8852bu_fw.bin",
> .cfg_name = "rtl_bt/rtl8852bu_config" },
>
> + /* 8852B with UART interface */
> + { IC_INFO(RTL_ROM_LMP_8852A, 0xb, 0xb, HCI_UART),
> + .config_needed = true,
> + .has_rom_version = true,
> + .has_msft_ext = true,
> + .fw_name = "rtl_bt/rtl8852bs_fw.bin",
> + .cfg_name = "rtl_bt/rtl8852bs_config" },
> +
I’d sort *bs* before *bu*.
> /* 8852C */
> { IC_INFO(RTL_ROM_LMP_8852A, 0xc, 0xc, HCI_USB),
> .config_needed = false,
> @@ -965,5 +973,7 @@ MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852au_config.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852bu_fw.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852bu_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8852bs_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8852bs_config.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852cu_fw.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852cu_config.bin");
Ditto.
Kind regards,
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND] Bluetooth: btrtl: Add support for RTL8852BS
2023-02-06 10:03 ` Paul Menzel
@ 2023-02-14 6:23 ` Victor Hassan
0 siblings, 0 replies; 4+ messages in thread
From: Victor Hassan @ 2023-02-14 6:23 UTC (permalink / raw)
To: Paul Menzel
Cc: marcel, johan.hedberg, luiz.dentz, linux-bluetooth, linux-kernel
Dear Paul:
Thank you for your advises. I had send PATCH-v2 to fix it. Can you
give me more advises?
On 2023/2/6 18:03, Paul Menzel wrote:
> Dear Victor,
>
>
> Thank you for your patch.
>
> Am 06.02.23 um 07:33 schrieb Victor Hassan:
>> Add the support for RTL8852BS BT controller on UART interface.
>> The necessary firmware file will be submitted to linux-firmware.
>>
>> Signed-off-by: Victor Hassan <victor@allwinnertech.com>
>> ---
>> drivers/bluetooth/btrtl.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
>> index 69c3fe649ca7..36c3a23324f8 100644
>> --- a/drivers/bluetooth/btrtl.c
>> +++ b/drivers/bluetooth/btrtl.c
>> @@ -198,6 +198,14 @@ static const struct id_table ic_id_table[] = {
>> .fw_name = "rtl_bt/rtl8852bu_fw.bin",
>> .cfg_name = "rtl_bt/rtl8852bu_config" },
>> + /* 8852B with UART interface */
>> + { IC_INFO(RTL_ROM_LMP_8852A, 0xb, 0xb, HCI_UART),
>> + .config_needed = true,
>> + .has_rom_version = true,
>> + .has_msft_ext = true,
>> + .fw_name = "rtl_bt/rtl8852bs_fw.bin",
>> + .cfg_name = "rtl_bt/rtl8852bs_config" },
>> +
>
> I’d sort *bs* before *bu*.
>
>> /* 8852C */
>> { IC_INFO(RTL_ROM_LMP_8852A, 0xc, 0xc, HCI_USB),
>> .config_needed = false,
>> @@ -965,5 +973,7 @@ MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");
>> MODULE_FIRMWARE("rtl_bt/rtl8852au_config.bin");
>> MODULE_FIRMWARE("rtl_bt/rtl8852bu_fw.bin");
>> MODULE_FIRMWARE("rtl_bt/rtl8852bu_config.bin");
>> +MODULE_FIRMWARE("rtl_bt/rtl8852bs_fw.bin");
>> +MODULE_FIRMWARE("rtl_bt/rtl8852bs_config.bin");
>> MODULE_FIRMWARE("rtl_bt/rtl8852cu_fw.bin");
>> MODULE_FIRMWARE("rtl_bt/rtl8852cu_config.bin");
>
> Ditto.
>
>
> Kind regards,
>
> Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-14 6:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 6:33 [RESEND] Bluetooth: btrtl: Add support for RTL8852BS Victor Hassan
2023-02-06 7:01 ` bluez.test.bot
2023-02-06 10:03 ` Paul Menzel
2023-02-14 6:23 ` Victor Hassan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox