linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Germann <bage@debian.org>
To: Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Bastian Germann <bage@debian.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: [PATCH v5 0/2] Bluetooth: btrtl: add support for the RTL8723CS
Date: Sun, 12 Feb 2023 13:41:50 +0100	[thread overview]
Message-ID: <20230212124153.2415-1-bage@debian.org> (raw)

Pinebook uses RTL8723CS for WiFi and bluetooth. Unfortunately, RTL8723CS
has broken BT-4.1 support, so it requires a quirk.

Add a quirk and wire up 8723CS support in btrtl.
I was asked for a btmon output without the quirk;
however, using the chip without the quirk ends up in a bad state with
"Opcode 0x c77 failed: -56" (HCI_OP_READ_SYNC_TRAIN_PARAMS) on training.
A btmon output with the quirk active was already sent by Vasily.

v1 of this series was sent in July 2020 by Vasily Khoruzhick.
I have tested it to work on the Pinebook.

Changelog:
v2:
   * Rebase
   * Add uart-has-rtscts to device tree as requested by reviewer
v3:
   * Drop the device tree as it was split out and is already integrated.
   * Rename the quirk as requested by reviewer Marcel Holtmann
v4:
   * Use skb_pull_data as requested by reviewer Luiz Augusto von Dentz
v5:
   * Make use of skb_pull_data's length check

Vasily Khoruzhick (2):
  Bluetooth: Add new quirk for broken local ext features page 2
  Bluetooth: btrtl: add support for the RTL8723CS

 drivers/bluetooth/btrtl.c   | 120 ++++++++++++++++++++++++++++++++++--
 drivers/bluetooth/btrtl.h   |   5 ++
 drivers/bluetooth/hci_h5.c  |   4 ++
 include/net/bluetooth/hci.h |   7 +++
 net/bluetooth/hci_event.c   |   4 +-
 5 files changed, 135 insertions(+), 5 deletions(-)

-- 
2.39.1


             reply	other threads:[~2023-02-12 12:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-12 12:41 Bastian Germann [this message]
2023-02-12 12:41 ` [PATCH v5 1/2] Bluetooth: Add new quirk for broken local ext features page 2 Bastian Germann
2023-02-12 13:15   ` Bluetooth: btrtl: add support for the RTL8723CS bluez.test.bot
2023-02-12 12:41 ` [PATCH v5 2/2] " Bastian Germann
2023-02-22 22:44 ` [PATCH v5 0/2] " Bastian Germann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230212124153.2415-1-bage@debian.org \
    --to=bage@debian.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).