Re: [RFC v2 01/12] shared/crypto: Add bt_crypto_sirk

Luiz Augusto von Dentz
2023-03-13T05:36:51Z

Hi Pauli, Frederic,

On Fri, Mar 10, 2023 at 4:40 PM <patchwork-bot+bluetooth@kernel.org> wrote:
>
> Hello:
>
> This series was applied to bluetooth/bluez.git (master)
> by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
>
> On Tue, 7 Mar 2023 14:24:11 -0800 you wrote:
> > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> >
> > This adds bt_crypto_sirk which attempts to generate a unique SIRK using
> > the following steps:
> >
> > - Generate a hash (k) using the str as input
> > - Generate a hash (sirk) using vendor, product, version and source as input
> > - Encrypt sirk using k as LTK with sef function.
> >
> > [...]
>
> Here is the summary with links:
> - [RFC,v2,01/12] shared/crypto: Add bt_crypto_sirk
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c1dd94cc7f81
> - [RFC,v2,02/12] shared/ad: Add RSI data type
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c2e99aefd337
> - [RFC,v2,03/12] doc: Add set-api
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6477522e92e3
> - [RFC,v2,04/12] device-api: Add Set property
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5bac4cddb191
> - [RFC,v2,05/12] core: Add initial implementation of DeviceSet interface
> (no matching commit)
> - [RFC,v2,06/12] core: Check if device has RSI
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f95ffcc8b1fe
> - [RFC,v2,07/12] main.conf: Add CSIP profile configurable options
> (no matching commit)
> - [RFC,v2,08/12] shared/csip: Add initial code for handling CSIP
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d297a03b7a61
> - [RFC,v2,09/12] profiles: Add initial code for csip plugin
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9e1eb0a62b3f
> - [RFC,v2,10/12] tools: Add support to generate RSI using SIRK
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c446a64d461b
> - [RFC,v2,11/12] client: Add support for DeviceSet proxy
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=373bafc34ce6
> - [RFC,v2,12/12] client: Use AdvertisingFlags when available
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=815f779aa8e4
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html

Let me know if you guys are happy with this interface to detect
Coordinated Sets, it still experimental so we can experiment with it
until we think it is stable, regarding the implementation of the
transports one major difference here is that we will need to encode
left and right separately, not sure how hard it is to do that in
pipewire?

>

--
Luiz Augusto von Dentz