[PATCH] Bluetooth: NXP: select CONFIG_CRC8

[PATCH] Bluetooth: NXP: select CONFIG_CRC8

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The driver needs both CRC32 and CRC8 to link correctly:

ld.lld: error: undefined symbol: crc8_populate_msb
>>> referenced by btnxpuart.c
>>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
ld.lld: error: undefined symbol: crc8
>>> referenced by btnxpuart.c
>>>               drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a

Fixes: 3e662aa4453a ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/bluetooth/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 0703bdd44140..f84322d375de 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -469,6 +469,7 @@ config BT_NXPUART
 	tristate "NXP protocol support"
 	depends on SERIAL_DEV_BUS
 	select CRC32
+	select CRC8
 	help
 	  NXP is serial driver required for NXP Bluetooth
 	  devices with UART interface.
-- 
2.39.2

RE: Bluetooth: NXP: select CONFIG_CRC8

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2910 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=732709

---Test result---

Test Summary:
CheckPatch                    FAIL      0.98 seconds
GitLint                       FAIL      0.63 seconds
SubjectPrefix                 PASS      0.06 seconds
BuildKernel                   PASS      43.10 seconds
CheckAllWarning               PASS      47.43 seconds
CheckSparse                   PASS      52.54 seconds
CheckSmatch                   PASS      143.76 seconds
BuildKernel32                 PASS      41.96 seconds
TestRunnerSetup               PASS      610.65 seconds
TestRunner_l2cap-tester       PASS      21.65 seconds
TestRunner_iso-tester         PASS      23.98 seconds
TestRunner_bnep-tester        PASS      7.63 seconds
TestRunner_mgmt-tester        PASS      141.46 seconds
TestRunner_rfcomm-tester      PASS      12.49 seconds
TestRunner_sco-tester         PASS      11.10 seconds
TestRunner_ioctl-tester       PASS      13.67 seconds
TestRunner_mesh-tester        PASS      9.76 seconds
TestRunner_smp-tester         PASS      10.49 seconds
TestRunner_userchan-tester    PASS      7.86 seconds
IncrementalBuild              PASS      38.89 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: NXP: select CONFIG_CRC8
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#66: 
>>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a

total: 0 errors, 1 warnings, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13183936.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
Bluetooth: NXP: select CONFIG_CRC8

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
9: B1 Line exceeds max length (87>80): ">>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a"
12: B1 Line exceeds max length (83>80): ">>>               drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a"


---
Regards,
Linux Bluetooth

Re: [PATCH] Bluetooth: NXP: select CONFIG_CRC8

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

On Wed, 22 Mar 2023, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver needs both CRC32 and CRC8 to link correctly:
> 
> ld.lld: error: undefined symbol: crc8_populate_msb
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
> ld.lld: error: undefined symbol: crc8
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a
> 
> Fixes: 3e662aa4453a ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/bluetooth/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 0703bdd44140..f84322d375de 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -469,6 +469,7 @@ config BT_NXPUART
>  	tristate "NXP protocol support"
>  	depends on SERIAL_DEV_BUS
>  	select CRC32
> +	select CRC8
>  	help
>  	  NXP is serial driver required for NXP Bluetooth
>  	  devices with UART interface.
> 

Right. ...I should have realized this was missing too when I noticed 
select CRC32 wasn't there.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


-- 
 i.

Re: [PATCH] Bluetooth: NXP: select CONFIG_CRC8

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 22 Mar 2023 12:16:27 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver needs both CRC32 and CRC8 to link correctly:
> 
> ld.lld: error: undefined symbol: crc8_populate_msb
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_serdev_probe) in archive vmlinux.a
> ld.lld: error: undefined symbol: crc8
> >>> referenced by btnxpuart.c
> >>>               drivers/bluetooth/btnxpuart.o:(nxp_send_ack) in archive vmlinux.a
> 
> [...]

Here is the summary with links:
  - Bluetooth: NXP: select CONFIG_CRC8
    https://git.kernel.org/bluetooth/bluetooth-next/c/335aed70654a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html