linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nitin Jadhav <nitin.jadhav@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: devyani.godbole@nxp.com, pav@iki.fi, luiz.dentz@gmail.com,
	sathish.narasimman@intel.com, nitin.jadhav@nxp.com
Subject: [PATCH BlueZ v3 1/3] shared/vcp: Fixed the crash observed with VOCS
Date: Tue, 25 Jul 2023 14:21:24 +0300	[thread overview]
Message-ID: <20230725112126.49656-2-nitin.jadhav@nxp.com> (raw)
In-Reply-To: <20230725112126.49656-1-nitin.jadhav@nxp.com>

Root cause
- There are two types of database- Remote and Local (rdb and ldb).
- In client mode currently the code was written to access ldb.

Fix
- Correcting it, to access rdb has resolved the problem in VOCS.
- Same correction is done for VCS.

Reported-by: Pauli Virtanen <pav@iki.fi>
---
 src/shared/vcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shared/vcp.c b/src/shared/vcp.c
index 74bd01729..314618664 100644
--- a/src/shared/vcp.c
+++ b/src/shared/vcp.c
@@ -1719,10 +1719,10 @@ bool bt_vcp_attach(struct bt_vcp *vcp, struct bt_gatt_client *client)
 		return false;
 
 	bt_uuid16_create(&uuid, VCS_UUID);
-	gatt_db_foreach_service(vcp->ldb->db, &uuid, foreach_vcs_service, vcp);
+	gatt_db_foreach_service(vcp->rdb->db, &uuid, foreach_vcs_service, vcp);
 
 	bt_uuid16_create(&uuid, VOL_OFFSET_CS_UUID);
-	gatt_db_foreach_service(vcp->ldb->db, &uuid, foreach_vocs_service, vcp);
+	gatt_db_foreach_service(vcp->rdb->db, &uuid, foreach_vocs_service, vcp);
 
 	return true;
 }
-- 
2.34.1


  reply	other threads:[~2023-07-25 11:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 11:21 [PATCH BlueZ v3 0/3] Fixed the crash observed with VOCS Nitin Jadhav
2023-07-25 11:21 ` Nitin Jadhav [this message]
2023-07-25 13:33   ` bluez.test.bot
2023-07-25 11:21 ` [PATCH BlueZ v3 2/3] shared/vcp: Fixed issues related to read audio location and descriptor Nitin Jadhav
2023-07-25 11:21 ` [PATCH BlueZ v3 3/3] shared/vcp: Corrected handle size to accommodate included service Nitin Jadhav
2023-07-25 11:46   ` Paul Menzel
2023-07-25 19:50 ` [PATCH BlueZ v3 0/3] Fixed the crash observed with VOCS patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725112126.49656-2-nitin.jadhav@nxp.com \
    --to=nitin.jadhav@nxp.com \
    --cc=devyani.godbole@nxp.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=pav@iki.fi \
    --cc=sathish.narasimman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).