public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Inga Stotland <inga.stotland@gmail.com>
To: brian.gix@gmail.com, luiz.von.dentz@intel.com,
	linux-bluetooth@vger.kernel.org
Cc: Inga Stotland <inga.stotland@gmail.com>
Subject: [PATCH BlueZ v2] mesh: Fix check for active scan when using generic IO
Date: Mon, 16 Oct 2023 17:21:23 -0700	[thread overview]
Message-ID: <20231017002123.43533-1-inga.stotland@gmail.com> (raw)

This modifies the check for an active scan in generic IO:
the bug has been introduced during earlier code refactoring.

Fixes: https://github.com/bluez/bluez/issues/625
---
 mesh/mesh-io-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mesh/mesh-io-generic.c b/mesh/mesh-io-generic.c
index 00932ade7..13a863b48 100644
--- a/mesh/mesh-io-generic.c
+++ b/mesh/mesh-io-generic.c
@@ -781,7 +781,7 @@ static bool recv_register(struct mesh_io *io, const uint8_t *filter,
 	bool already_scanning;
 	bool active = false;
 
-	already_scanning = !l_queue_isempty(io->rx_regs);
+	already_scanning = l_queue_length(io->rx_regs) > 1;
 
 	/* Look for any AD types requiring Active Scanning */
 	if (l_queue_find(io->rx_regs, find_active, NULL))
-- 
2.41.0


             reply	other threads:[~2023-10-17  0:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17  0:21 Inga Stotland [this message]
2023-10-17  2:22 ` [BlueZ,v2] mesh: Fix check for active scan when using generic IO bluez.test.bot
2023-10-17 16:40 ` [PATCH BlueZ v2] " patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231017002123.43533-1-inga.stotland@gmail.com \
    --to=inga.stotland@gmail.com \
    --cc=brian.gix@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.von.dentz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox