From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>,
linux-bluetooth@vger.kernel.org, mario.limonciello@amd.com,
regressions@lists.linux.dev, regressions@leemhuis.info,
Basavaraj.Natikar@amd.com, pmenzel@molgen.mpg.de,
bugs-a21@moonlit-rail.com,
Mathias Nyman <mathias.nyman@linux.intel.com>,
stable@vger.kernel.org
Subject: [PATCH 2/2] Revert "xhci: Loosen RPM as default policy to cover for AMD xHC 1.1"
Date: Mon, 4 Dec 2023 12:08:59 +0200 [thread overview]
Message-ID: <20231204100859.1332772-2-mathias.nyman@linux.intel.com> (raw)
In-Reply-To: <20231204100859.1332772-1-mathias.nyman@linux.intel.com>
This reverts commit 4baf1218150985ee3ab0a27220456a1f027ea0ac.
Enabling runtime pm as default for all AMD xHC 1.1 controllers caused
regression. An initial attempt to fix those was done in commit a5d6264b638e
("xhci: Enable RPM on controllers that support low-power states") but new
issues are still seen.
Revert them both and start from a clean slate.
This patch went to stable an needs to be reverted from there as well.
Fixes: 4baf12181509 ("xhci: Loosen RPM as default policy to cover for AMD xHC 1.1")
Link: https://lore.kernel.org/linux-usb/55c50bf5-bffb-454e-906e-4408c591cb63@molgen.mpg.de
Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
drivers/usb/host/xhci-pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index bde43cef8846..b9ae5c2a2527 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -535,8 +535,6 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
/* xHC spec requires PCI devices to support D3hot and D3cold */
if (xhci->hci_version >= 0x120)
xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
- else if (pdev->vendor == PCI_VENDOR_ID_AMD && xhci->hci_version >= 0x110)
- xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
if (xhci->quirks & XHCI_RESET_ON_RESUME)
xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
--
2.25.1
next prev parent reply other threads:[~2023-12-04 10:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 1:54 Regression: Inoperative bluetooth, Intel chipset, mainline kernel 6.6.2+ Kris Karas (Bug Reporting)
2023-12-01 6:27 ` Bagas Sanjaya
2023-12-01 8:19 ` Kris Karas (Bug Reporting)
2023-12-01 8:27 ` Paul Menzel
2023-12-03 12:17 ` Oleksandr Natalenko
2023-12-03 18:46 ` Kris Karas (Bug Reporting)
2023-12-01 6:33 ` Thorsten Leemhuis
2023-12-01 8:15 ` Greg KH
2023-12-02 6:43 ` Kris Karas (Bug Reporting)
2023-12-02 7:23 ` Paul Menzel
2023-12-02 7:50 ` Greg KH
2023-12-02 7:58 ` Kris Karas (Bug Reporting)
2023-12-02 8:15 ` Greg KH
2023-12-03 8:32 ` Kris Karas (Bug Reporting)
2023-12-03 8:38 ` Greg KH
2023-12-03 16:16 ` Basavaraj Natikar
2023-12-03 16:24 ` Basavaraj Natikar
2023-12-03 19:52 ` Oleksandr Natalenko
2023-12-04 9:12 ` Mathias Nyman
2023-12-04 10:08 ` [PATCH 1/2] Revert "xhci: Enable RPM on controllers that support low-power states" Mathias Nyman
2023-12-04 10:08 ` Mathias Nyman [this message]
2023-12-04 10:14 ` [1/2] " bluez.test.bot
2023-12-04 10:49 ` [PATCH 1/2] " Basavaraj Natikar
2023-12-04 14:22 ` Mathias Nyman
2023-12-04 14:49 ` Basavaraj Natikar
2023-12-04 15:06 ` Mathias Nyman
2023-12-04 15:29 ` Basavaraj Natikar
2023-12-04 23:55 ` Greg KH
2023-12-05 9:05 ` [PATCH v2] Revert "xhci: Loosen RPM as default policy to cover for AMD xHC 1.1" Mathias Nyman
2023-12-05 9:13 ` [v2] " bluez.test.bot
2023-12-05 18:36 ` [PATCH v2] " Mario Limonciello
2023-12-15 16:53 ` patchwork-bot+bluetooth
2023-12-15 16:53 ` [PATCH 1/2] Revert "xhci: Enable RPM on controllers that support low-power states" patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204100859.1332772-2-mathias.nyman@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=bugs-a21@moonlit-rail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=pmenzel@molgen.mpg.de \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).