Re: [PATCH BlueZ 04/10] build: remove dummy {conf,state}{dir,_DATA}

Luiz Augusto von Dentz
2024-01-19T15:09:38Z

Hi Emil, Tedd,

On Fri, Jan 19, 2024 at 6:09 AM Emil Velikov <emil.l.velikov@gmail.com> wrote:
>
> On Thu, 18 Jan 2024 at 17:05, Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> >
> > Hi Emil,
> >
> > On Thu, Jan 18, 2024 at 11:12 AM Emil Velikov <emil.l.velikov@gmail.com> wrote:
> > >
> > > On Wed, 17 Jan 2024 at 08:39, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> > > >
> > > > On Tue, 16 Jan 2024 at 18:40, Luiz Augusto von Dentz
> > > > <luiz.dentz@gmail.com> wrote:
> > > >
> > > > >
> > > > > This one seems to be causing some build regression, when trying to
> > > > > apply it breaks the builds.
> > > > >
> > > >
> > > > Thanks for the quick feedback Luiz.
> > > >
> > > > Would be happy to help but need some details:
> > > > - configure options used
> > > > - autoconf, make, gcc(?) version
> > > > - the error log
> > > >
> > >
> > > Just went through all the patches and they apply and build just fine.
> > > Both in terms of "./bootstrap-configure && make distcheck" as well as
> > > the Arch specific configure options as seen here [1].
> > >
> > > Any pointers about the issue you're seeing and the platform in
> > > question would be appreciated.
> > >
> > > Thanks again,
> > > Emil
> > >
> > > [1] https://gitlab.archlinux.org/archlinux/packaging/packages/bluez/-/blob/main/PKGBUILD?ref_type=heads
> >
> > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/
> > 9/../../../x86_64-linux-gnu/Scrt1.o: in function `_start':
> > (.text+0x24): undefined reference to `main'
> > collect2: error: ld returned 1 exit status
> > make[1]: *** [Makefile:5864: mesh/bluetooth-meshd] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [Makefile:4674: all] Error 2
> >
> > This might be due to using scan-build, anyway CI also run into the same problem:
> >
>
> Might be version/platform specific - `scan-build make -j2` works just
> fine here. What are you using - distro, autoconf, clang/scan-build
> version?
>
> > https://github.com/BluezTestBot/bluez/pull/2010#issuecomment-1893971347
> >
>
> Hmm, I was wondering where the bot lives. Will take a closer look.

If I'm not mistaken it runs under a ubuntu VM under a github action,
@Tedd Ho-Jeong An can probably explain it better since he wrote the CI
integration, which btw we intend to move to BlueZ organization at some
point.

> Thanks
> Emil

--
Luiz Augusto von Dentz