[v3] Bluetooth: btusb: Set error code in btusb_mtk_hci_wmt_sync()

[v3] Bluetooth: btusb: Set error code in btusb_mtk_hci_wmt_sync()

[Youwan Wang]

Convenient to check if the function was executed successfully
and know the specific error location in the code.

Signed-off-by: Youwan Wang <youwan@nfschina.com>
---
 drivers/bluetooth/btusb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index d793dcd06687..a7244a8a5b7c 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2824,8 +2824,10 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,
 		goto err_free_wc;
 	}
 
-	if (data->evt_skb == NULL)
+	if (data->evt_skb == NULL) {
+		err = -ENOBUFS;
 		goto err_free_wc;
+	}
 
 	/* Parse and handle the return WMT event */
 	wmt_evt = (struct btmtk_hci_wmt_evt *)data->evt_skb->data;
-- 
2.25.1

Re: [v3] Bluetooth: btusb: Set error code in btusb_mtk_hci_wmt_sync()

[youwan]

Okay, thank you. The new patch has been sent




email：youwan@nfschina.com



 
From: Youwan Wang



Date: 2024-03-13 15:43



To: marcel



CC: johan.hedberg; luiz.dentz; linux-bluetooth; Youwan Wang



Subject: [v3] Bluetooth: btusb: Set error code in btusb_mtk_hci_wmt_sync()



Convenient to check if the function was executed successfully



and know the specific error location in the code.



 



Signed-off-by: Youwan Wang <youwan@nfschina.com>



---



drivers/bluetooth/btusb.c | 4 +++-



1 file changed, 3 insertions(+), 1 deletion(-)



 



diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c



index d793dcd06687..a7244a8a5b7c 100644



--- a/drivers/bluetooth/btusb.c



+++ b/drivers/bluetooth/btusb.c



@@ -2824,8 +2824,10 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,



goto err_free_wc;



}



- if (data->evt_skb == NULL)



+ if (data->evt_skb == NULL) {



+ err = -ENOBUFS;



goto err_free_wc;



+ }



/* Parse and handle the return WMT event */



wmt_evt = (struct btmtk_hci_wmt_evt *)data->evt_skb->data;



--



2.25.1



 

RE: [v3] Bluetooth: btusb: Set error code in btusb_mtk_hci_wmt_sync()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=834873

---Test result---

Test Summary:
CheckPatch                    PASS      0.59 seconds
GitLint                       PASS      0.28 seconds
SubjectPrefix                 PASS      1.71 seconds
BuildKernel                   PASS      28.26 seconds
CheckAllWarning               PASS      31.08 seconds
CheckSparse                   PASS      37.14 seconds
CheckSmatch                   PASS      100.28 seconds
BuildKernel32                 PASS      28.41 seconds
TestRunnerSetup               PASS      514.97 seconds
TestRunner_l2cap-tester       PASS      17.99 seconds
TestRunner_iso-tester         PASS      30.41 seconds
TestRunner_bnep-tester        PASS      4.75 seconds
TestRunner_mgmt-tester        PASS      112.65 seconds
TestRunner_rfcomm-tester      PASS      7.31 seconds
TestRunner_sco-tester         PASS      14.96 seconds
TestRunner_ioctl-tester       PASS      7.80 seconds
TestRunner_mesh-tester        PASS      8.13 seconds
TestRunner_smp-tester         PASS      7.76 seconds
TestRunner_userchan-tester    PASS      5.06 seconds
IncrementalBuild              PASS      26.63 seconds



---
Regards,
Linux Bluetooth