Re: [PATCH v1 3/3] Bluetooth: btintel_pcie: Add *setup* function to download firmware

[Bjorn Helgaas <helgaas@kernel.org>]

On Thu, Mar 28, 2024 at 04:49:04PM +0530, Kiran K wrote:
> Add to support to download firmware.
> 
> Signed-off-by: Kiran K <kiran.k@intel.com>
> Co-developed-by: Chandrashekar <chandrashekar.devegowda@intel.com>
> Signed-off-by: Chandrashekar <chandrashekar.devegowda@intel.com>

> +	/* Due to the fw limitation, the type header of the packet should be
> +	 * 4 bytes unlikely 1 byte for UART. In UART, the firmware can reads

s/unlikely/unlike/ (I think?)
s/can reads/can read/

> +	 * the first byte to get the packet type and redirect the rest of data
> +	 * packet to the right handler. But for PCIe, THF(Transfer Flow Handler)
> +	 * fetches the 4 bytes of data from DMA memory and by the time it reads
> +	 * the first 4 bytes, it already consumes some part of packet. Thus
> +	 * the packet type indicator for iBT PCIe is 4 bytes.
> +	 * Luckily, when HCI core creates the skb, it allocated 8 bytes of
> +	 * head room for profile and driver use, and before sending the data
> +	 * to the device, append the iBT PCIe packet type in the front.
> +	 */