From: Bastien Nocera <hadess@hadess.net>
To: linux-bluetooth@vger.kernel.org
Cc: Bastien Nocera <hadess@hadess.net>
Subject: [BlueZ 03/15] shared/gatt-client: Fix uninitialised variable usage
Date: Thu, 16 May 2024 11:03:07 +0200 [thread overview]
Message-ID: <20240516090340.61417-4-hadess@hadess.net> (raw)
In-Reply-To: <20240516090340.61417-1-hadess@hadess.net>
Error: UNINIT (CWE-457): [#def44] [important]
bluez-5.75/src/shared/gatt-client.c:1669:2: var_decl: Declaring variable "value" without initializer.
bluez-5.75/src/shared/gatt-client.c:1686:2: uninit_use_in_call: Using uninitialized value "value" when calling "bt_gatt_client_write_value".
1684| }
1685|
1686|-> att_id = bt_gatt_client_write_value(notify_data->client,
1687| notify_data->chrc->ccc_handle,
1688| (void *)&value, sizeof(value),
---
src/shared/gatt-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
index dcf6f0211a67..8e4ae7e5e230 100644
--- a/src/shared/gatt-client.c
+++ b/src/shared/gatt-client.c
@@ -1666,7 +1666,7 @@ static bool notify_data_write_ccc(struct notify_data *notify_data, bool enable,
bt_gatt_client_callback_t callback)
{
unsigned int att_id;
- uint16_t value;
+ uint16_t value = 0x0000;
uint16_t properties = notify_data->chrc->properties;
assert(notify_data->chrc->ccc_handle);
--
2.44.0
next prev parent reply other threads:[~2024-05-16 9:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 9:03 [BlueZ 00/15] Fix a number of static analysis issues #2 Bastien Nocera
2024-05-16 9:03 ` [BlueZ 01/15] main: Simplify variable assignment Bastien Nocera
2024-05-16 9:03 ` [BlueZ 02/15] shared/ecc: Fix uninitialised variable usage Bastien Nocera
2024-05-16 9:03 ` Bastien Nocera [this message]
2024-05-16 9:03 ` [BlueZ 04/15] tools/mesh-cfgclient: " Bastien Nocera
2024-05-16 9:03 ` [BlueZ 05/15] test-runner: Remove unused envp Bastien Nocera
2024-05-16 9:03 ` [BlueZ 06/15] test-runner: Fix uninitialised variable usage Bastien Nocera
2024-05-16 9:03 ` [BlueZ 07/15] " Bastien Nocera
2024-05-16 9:03 ` [BlueZ 08/15] shared/bap: Fix possible use-after-free Bastien Nocera
2024-05-16 9:03 ` [BlueZ 09/15] isotest: Fix bad free Bastien Nocera
2024-05-16 9:03 ` [BlueZ 10/15] test-runner: Fix fd leak on failure Bastien Nocera
2024-05-16 9:03 ` [BlueZ 11/15] isotest: Fix string size expectations Bastien Nocera
2024-05-16 9:03 ` [BlueZ 12/15] mgmt-tester: Fix non-nul-terminated string Bastien Nocera
2024-05-16 9:03 ` [BlueZ 13/15] gdbus: Check sprintf retval Bastien Nocera
2024-05-16 9:03 ` [BlueZ 14/15] shared/bap: Fix memory leak in error path Bastien Nocera
2024-05-16 9:03 ` [BlueZ 15/15] android/handsfree: Check sprintf retval Bastien Nocera
2024-05-16 20:50 ` [BlueZ 00/15] Fix a number of static analysis issues #2 patchwork-bot+bluetooth
2024-05-27 8:23 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516090340.61417-4-hadess@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox