RE: Bluetooth: Patch for CYW4373 hci up fail issue

bluez.test.bot
2024-05-16T05:33:14Z

[-- Attachment #1: Type: text/plain, Size: 6943 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=853578

---Test result---

Test Summary:
CheckPatch FAIL 1.07 seconds
GitLint FAIL 0.44 seconds
SubjectPrefix PASS 0.07 seconds
BuildKernel PASS 29.54 seconds
CheckAllWarning WARNING 32.16 seconds
CheckSparse WARNING 37.46 seconds
CheckSmatch FAIL 35.73 seconds
BuildKernel32 PASS 28.33 seconds
TestRunnerSetup PASS 516.67 seconds
TestRunner_l2cap-tester PASS 20.34 seconds
TestRunner_iso-tester PASS 32.56 seconds
TestRunner_bnep-tester PASS 4.66 seconds
TestRunner_mgmt-tester PASS 111.34 seconds
TestRunner_rfcomm-tester PASS 7.24 seconds
TestRunner_sco-tester PASS 14.90 seconds
TestRunner_ioctl-tester PASS 7.65 seconds
TestRunner_mesh-tester PASS 5.78 seconds
TestRunner_smp-tester PASS 6.68 seconds
TestRunner_userchan-tester PASS 4.90 seconds
IncrementalBuild PASS 27.20 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: Patch for CYW4373 hci up fail issue
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#84:
Due to the issue, Bluetooth driver of 5.15 and later kernel fails to hci up.

WARNING: line length of 138 exceeds 100 columns
#114: FILE: drivers/bluetooth/btbcm.c:451:
+ int table_size = sizeof(disable_broken_read_transmit_power_by_chip_ver)/sizeof(disable_broken_read_transmit_power_by_chip_ver[0]);

WARNING: Prefer ARRAY_SIZE(disable_broken_read_transmit_power_by_chip_ver)
#114: FILE: drivers/bluetooth/btbcm.c:451:
+ int table_size = sizeof(disable_broken_read_transmit_power_by_chip_ver)/sizeof(disable_broken_read_transmit_power_by_chip_ver[0]);

ERROR: that open brace { should be on the previous line
#117: FILE: drivers/bluetooth/btbcm.c:454:
+ for( i=0 ; i<table_size ; i++, entry++)
+ {

ERROR: spaces required around that '=' (ctx:VxV)
#117: FILE: drivers/bluetooth/btbcm.c:454:
+ for( i=0 ; i<table_size ; i++, entry++)
^

ERROR: spaces required around that '<' (ctx:VxV)
#117: FILE: drivers/bluetooth/btbcm.c:454:
+ for( i=0 ; i<table_size ; i++, entry++)
^

ERROR: space prohibited after that open parenthesis '('
#117: FILE: drivers/bluetooth/btbcm.c:454:
+ for( i=0 ; i<table_size ; i++, entry++)

ERROR: space required before the open parenthesis '('
#117: FILE: drivers/bluetooth/btbcm.c:454:
+ for( i=0 ; i<table_size ; i++, entry++)

ERROR: space prohibited after that open parenthesis '('
#119: FILE: drivers/bluetooth/btbcm.c:456:
+ if( (chip_id == entry->chip_id) && (baseline == entry->baseline) )

ERROR: space prohibited before that close parenthesis ')'
#119: FILE: drivers/bluetooth/btbcm.c:456:
+ if( (chip_id == entry->chip_id) && (baseline == entry->baseline) )

ERROR: space required before the open parenthesis '('
#119: FILE: drivers/bluetooth/btbcm.c:456:
+ if( (chip_id == entry->chip_id) && (baseline == entry->baseline) )

WARNING: From:/Signed-off-by: email name mismatch: 'From: Nobuaki.Tsunashima@infineon.com' != 'Signed-off-by: Nobuaki Tsunashima <nobuaki.tsunashima@infineon.com>'

total: 8 errors, 4 warnings, 59 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13665743.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
Bluetooth: Patch for CYW4373 hci up fail issue

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
8: B1 Line exceeds max length (84>80): "Especially in USB i/f case, it would be difficult to download patch FW that includes"
9: B1 Line exceeds max length (84>80): "Its fix unless hci is up. The patch forces the driver to skip LE_Read_Transmit_Power"
##############################
Test: CheckAllWarning - WARNING
Desc: Run linux kernel with all warning enabled
Output:
drivers/bluetooth/btbcm.c: In function ‘btbcm_is_disable_broken_read_tx_power_by_chip_ver’:drivers/bluetooth/btbcm.c:453:41: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 453 | struct bcm_chip_version_table *entry = &disable_broken_read_transmit_power_by_chip_ver[0]; | ^
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:
drivers/bluetooth/btbcm.c: In function ‘btbcm_is_disable_broken_read_tx_power_by_chip_ver’:drivers/bluetooth/btbcm.c:453:41: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]drivers/bluetooth/btbcm.c:453:95: warning: incorrect type in initializer (different modifiers)drivers/bluetooth/btbcm.c:453:95: expected struct bcm_chip_version_table *entrydrivers/bluetooth/btbcm.c:453:95: got struct bcm_chip_version_table const *
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2

---
Regards,
Linux Bluetooth