public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: "Yo-Jung (Leo) Lin" <leo.lin@canonical.com>
To: luiz.dentz@gmail.com
Cc: linux-bluetooth@vger.kernel.org, kai.heng.feng@canonical.com,
	0xff07@gmail.com, Yo-Jung Lin <leo.lin@canonical.com>
Subject: Re: [PATCH v3] Bluetooth: L2CAP: Fix rejecting L2CAP_CONN_PARAM_UPDATE_REQ
Date: Thu, 23 May 2024 14:45:08 +0800	[thread overview]
Message-ID: <20240523064508.6293-1-leo.lin@canonical.com> (raw)
In-Reply-To: <20240521143521.1568672-1-luiz.dentz@gmail.com>

I tested it using the bluetooth-next, with HEAD at 
a3975db95fcd8e304f1ee4b0be1895038942a8ef. It rejects the connection
parameter update request at least for the case where the min > max,
which is one of the failed conditions for the hci_check_conn_params()

Note that TSPX_iut_invalid_connection_interval_{min, max} in the IXIT
can be used to create faulty connection parameters.

The specific test steps are:

1. Set TSPX_iut_invalid_connection_interval_min to a value larger
   than TSPX_iut_invalid_connection_interval_max, e.g. 0xAB and 0xAA
   respectively.

2. Start the GAP/CONN/CPUP/BV-05-C case on PTS.

3. Enter bluetoothctl. Use "scan on" to find the address of PTS dongle.

4. Meanwhile, PTS will ask for connect request. Connect to it by
   running "connect $PTS_ADDR" in bluetoothctl.

5. At this point the PTS would send the parameter update request with
   faulty parameters set in the IXIT. Kernel will reject this request.

6. PST will then ask to send a disconnect request. Run "disconnect"
   in bluetoothctl. The test case should pass after disconnection.

Tested-by: Yo-Jung (Leo) Lin <leo.lin@canonical.com>

      parent reply	other threads:[~2024-05-23  6:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21 14:35 [PATCH v3] Bluetooth: L2CAP: Fix rejecting L2CAP_CONN_PARAM_UPDATE_REQ Luiz Augusto von Dentz
2024-05-21 14:56 ` [v3] " bluez.test.bot
2024-05-22 15:10 ` [PATCH v3] " patchwork-bot+bluetooth
2024-05-23  6:45 ` Yo-Jung (Leo) Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240523064508.6293-1-leo.lin@canonical.com \
    --to=leo.lin@canonical.com \
    --cc=0xff07@gmail.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox