* [PATCH v2] Bluetooth: Add vendor-specific packet classification for ISO data
@ 2024-05-23 6:09 Ying Hsu
2024-05-23 6:37 ` [v2] " bluez.test.bot
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ying Hsu @ 2024-05-23 6:09 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz, pmenzel
Cc: chromeos-bluetooth-upstreaming, Ying Hsu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Johan Hedberg, Marcel Holtmann,
Paolo Abeni, linux-kernel, netdev
When HCI raw sockets are opened, the Bluetooth kernel module doesn't
track CIS/BIS connections. User-space applications have to identify
ISO data by maintaining connection information and look up the mapping
for each ACL data packet received. Besides, btsnoop log captured in
kernel couldn't tell ISO data from ACL data in this case.
To avoid additional lookups, this patch introduces vendor-specific
packet classification for Intel BT controllers to distinguish
ISO data packets from ACL data packets.
Signed-off-by: Ying Hsu <yinghsu@chromium.org>
---
Tested LE audio unicast recording on a ChromeOS device with Intel AX211
Changes in v2:
- Adds vendor-specific packet classificaton in hci_dev.
- Keeps reclassification in hci_recv_frame.
drivers/bluetooth/btusb.c | 19 +++++++++++++++++++
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c | 16 ++++++++++++++++
3 files changed, 36 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 79aefdb3324d..75561e749c50 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -966,6 +966,24 @@ static void btusb_intel_cmd_timeout(struct hci_dev *hdev)
gpiod_set_value_cansleep(reset_gpio, 0);
}
+#define BT_USB_INTEL_ISODATA_HANDLE_BASE 0x900
+
+static u8 btusb_intel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
+{
+ /*
+ * Distinguish ISO data packets form ACL data packets
+ * based on their conneciton handle value range.
+ */
+ if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
+ __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
+
+ if (hci_handle(handle) >= BT_USB_INTEL_ISODATA_HANDLE_BASE)
+ return HCI_ISODATA_PKT;
+ }
+
+ return hci_skb_pkt_type(skb);
+}
+
#define RTK_DEVCOREDUMP_CODE_MEMDUMP 0x01
#define RTK_DEVCOREDUMP_CODE_HW_ERR 0x02
#define RTK_DEVCOREDUMP_CODE_CMD_TIMEOUT 0x03
@@ -4451,6 +4469,7 @@ static int btusb_probe(struct usb_interface *intf,
/* Transport specific configuration */
hdev->send = btusb_send_frame_intel;
hdev->cmd_timeout = btusb_intel_cmd_timeout;
+ hdev->classify_pkt_type = btusb_intel_classify_pkt_type;
if (id->driver_info & BTUSB_INTEL_NO_WBS_SUPPORT)
btintel_set_flag(hdev, INTEL_ROM_LEGACY_NO_WBS_SUPPORT);
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index 9231396fe96f..7b7068a84ff7 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -649,6 +649,7 @@ struct hci_dev {
int (*get_codec_config_data)(struct hci_dev *hdev, __u8 type,
struct bt_codec *codec, __u8 *vnd_len,
__u8 **vnd_data);
+ u8 (*classify_pkt_type)(struct hci_dev *hdev, struct sk_buff *skb);
};
#define HCI_PHY_HANDLE(handle) (handle & 0xff)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index b3ee9ff17624..8b817a99cefd 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -2941,15 +2941,31 @@ int hci_reset_dev(struct hci_dev *hdev)
}
EXPORT_SYMBOL(hci_reset_dev);
+static u8 hci_dev_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
+{
+ if (hdev->classify_pkt_type)
+ return hdev->classify_pkt_type(hdev, skb);
+
+ return hci_skb_pkt_type(skb);
+}
+
/* Receive frame from HCI drivers */
int hci_recv_frame(struct hci_dev *hdev, struct sk_buff *skb)
{
+ u8 dev_pkt_type;
+
if (!hdev || (!test_bit(HCI_UP, &hdev->flags)
&& !test_bit(HCI_INIT, &hdev->flags))) {
kfree_skb(skb);
return -ENXIO;
}
+ /* Check if the driver agree with packet type classification */
+ dev_pkt_type = hci_dev_classify_pkt_type(hdev, skb);
+ if (hci_skb_pkt_type(skb) != dev_pkt_type) {
+ hci_skb_pkt_type(skb) = dev_pkt_type;
+ }
+
switch (hci_skb_pkt_type(skb)) {
case HCI_EVENT_PKT:
break;
--
2.45.1.288.g0e0cd299f1-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [v2] Bluetooth: Add vendor-specific packet classification for ISO data
2024-05-23 6:09 [PATCH v2] Bluetooth: Add vendor-specific packet classification for ISO data Ying Hsu
@ 2024-05-23 6:37 ` bluez.test.bot
2024-05-23 13:17 ` [PATCH v2] " Simon Horman
2024-05-23 14:23 ` Luiz Augusto von Dentz
2 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2024-05-23 6:37 UTC (permalink / raw)
To: linux-bluetooth, yinghsu
[-- Attachment #1: Type: text/plain, Size: 2580 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=855213
---Test result---
Test Summary:
CheckPatch PASS 1.04 seconds
GitLint PASS 0.32 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 29.56 seconds
CheckAllWarning PASS 32.09 seconds
CheckSparse PASS 37.47 seconds
CheckSmatch FAIL 34.58 seconds
BuildKernel32 PASS 28.44 seconds
TestRunnerSetup PASS 515.38 seconds
TestRunner_l2cap-tester PASS 20.38 seconds
TestRunner_iso-tester PASS 31.72 seconds
TestRunner_bnep-tester PASS 4.83 seconds
TestRunner_mgmt-tester FAIL 107.97 seconds
TestRunner_rfcomm-tester PASS 7.39 seconds
TestRunner_sco-tester PASS 15.00 seconds
TestRunner_ioctl-tester PASS 7.76 seconds
TestRunner_mesh-tester PASS 5.90 seconds
TestRunner_smp-tester PASS 6.98 seconds
TestRunner_userchan-tester PASS 5.90 seconds
IncrementalBuild PASS 28.41 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2
Failed Test Cases
LL Privacy - Add Device 5 (2 Devices to RL) Failed 0.170 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Bluetooth: Add vendor-specific packet classification for ISO data
2024-05-23 6:09 [PATCH v2] Bluetooth: Add vendor-specific packet classification for ISO data Ying Hsu
2024-05-23 6:37 ` [v2] " bluez.test.bot
@ 2024-05-23 13:17 ` Simon Horman
2024-05-23 14:23 ` Luiz Augusto von Dentz
2 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2024-05-23 13:17 UTC (permalink / raw)
To: Ying Hsu
Cc: linux-bluetooth, luiz.dentz, pmenzel,
chromeos-bluetooth-upstreaming, David S. Miller, Eric Dumazet,
Jakub Kicinski, Johan Hedberg, Marcel Holtmann, Paolo Abeni,
linux-kernel, netdev
On Thu, May 23, 2024 at 06:09:31AM +0000, Ying Hsu wrote:
> When HCI raw sockets are opened, the Bluetooth kernel module doesn't
> track CIS/BIS connections. User-space applications have to identify
> ISO data by maintaining connection information and look up the mapping
> for each ACL data packet received. Besides, btsnoop log captured in
> kernel couldn't tell ISO data from ACL data in this case.
>
> To avoid additional lookups, this patch introduces vendor-specific
> packet classification for Intel BT controllers to distinguish
> ISO data packets from ACL data packets.
>
> Signed-off-by: Ying Hsu <yinghsu@chromium.org>
> ---
> Tested LE audio unicast recording on a ChromeOS device with Intel AX211
>
> Changes in v2:
> - Adds vendor-specific packet classificaton in hci_dev.
> - Keeps reclassification in hci_recv_frame.
>
> drivers/bluetooth/btusb.c | 19 +++++++++++++++++++
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_core.c | 16 ++++++++++++++++
> 3 files changed, 36 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 79aefdb3324d..75561e749c50 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -966,6 +966,24 @@ static void btusb_intel_cmd_timeout(struct hci_dev *hdev)
> gpiod_set_value_cansleep(reset_gpio, 0);
> }
>
> +#define BT_USB_INTEL_ISODATA_HANDLE_BASE 0x900
> +
> +static u8 btusb_intel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
> +{
> + /*
> + * Distinguish ISO data packets form ACL data packets
> + * based on their conneciton handle value range.
nit: connection
> + */
> + if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
> + __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
> +
> + if (hci_handle(handle) >= BT_USB_INTEL_ISODATA_HANDLE_BASE)
> + return HCI_ISODATA_PKT;
> + }
> +
> + return hci_skb_pkt_type(skb);
> +}
> +
> #define RTK_DEVCOREDUMP_CODE_MEMDUMP 0x01
> #define RTK_DEVCOREDUMP_CODE_HW_ERR 0x02
> #define RTK_DEVCOREDUMP_CODE_CMD_TIMEOUT 0x03
...
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] Bluetooth: Add vendor-specific packet classification for ISO data
2024-05-23 6:09 [PATCH v2] Bluetooth: Add vendor-specific packet classification for ISO data Ying Hsu
2024-05-23 6:37 ` [v2] " bluez.test.bot
2024-05-23 13:17 ` [PATCH v2] " Simon Horman
@ 2024-05-23 14:23 ` Luiz Augusto von Dentz
2024-05-24 3:35 ` Ying Hsu
2 siblings, 1 reply; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2024-05-23 14:23 UTC (permalink / raw)
To: Ying Hsu
Cc: linux-bluetooth, pmenzel, chromeos-bluetooth-upstreaming,
David S. Miller, Eric Dumazet, Jakub Kicinski, Johan Hedberg,
Marcel Holtmann, Paolo Abeni, linux-kernel, netdev
Hi Ying,
On Thu, May 23, 2024 at 2:09 AM Ying Hsu <yinghsu@chromium.org> wrote:
>
> When HCI raw sockets are opened, the Bluetooth kernel module doesn't
> track CIS/BIS connections. User-space applications have to identify
> ISO data by maintaining connection information and look up the mapping
> for each ACL data packet received. Besides, btsnoop log captured in
> kernel couldn't tell ISO data from ACL data in this case.
>
> To avoid additional lookups, this patch introduces vendor-specific
> packet classification for Intel BT controllers to distinguish
> ISO data packets from ACL data packets.
>
> Signed-off-by: Ying Hsu <yinghsu@chromium.org>
> ---
> Tested LE audio unicast recording on a ChromeOS device with Intel AX211
>
> Changes in v2:
> - Adds vendor-specific packet classificaton in hci_dev.
> - Keeps reclassification in hci_recv_frame.
>
> drivers/bluetooth/btusb.c | 19 +++++++++++++++++++
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_core.c | 16 ++++++++++++++++
> 3 files changed, 36 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 79aefdb3324d..75561e749c50 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -966,6 +966,24 @@ static void btusb_intel_cmd_timeout(struct hci_dev *hdev)
> gpiod_set_value_cansleep(reset_gpio, 0);
> }
>
> +#define BT_USB_INTEL_ISODATA_HANDLE_BASE 0x900
> +
> +static u8 btusb_intel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
We might as well move this to btintel.c since it should not be USB specific.
> +{
> + /*
> + * Distinguish ISO data packets form ACL data packets
> + * based on their conneciton handle value range.
> + */
> + if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
> + __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
> +
> + if (hci_handle(handle) >= BT_USB_INTEL_ISODATA_HANDLE_BASE)
> + return HCI_ISODATA_PKT;
> + }
> +
> + return hci_skb_pkt_type(skb);
> +}
> +
> #define RTK_DEVCOREDUMP_CODE_MEMDUMP 0x01
> #define RTK_DEVCOREDUMP_CODE_HW_ERR 0x02
> #define RTK_DEVCOREDUMP_CODE_CMD_TIMEOUT 0x03
> @@ -4451,6 +4469,7 @@ static int btusb_probe(struct usb_interface *intf,
> /* Transport specific configuration */
> hdev->send = btusb_send_frame_intel;
> hdev->cmd_timeout = btusb_intel_cmd_timeout;
> + hdev->classify_pkt_type = btusb_intel_classify_pkt_type;
>
> if (id->driver_info & BTUSB_INTEL_NO_WBS_SUPPORT)
> btintel_set_flag(hdev, INTEL_ROM_LEGACY_NO_WBS_SUPPORT);
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index 9231396fe96f..7b7068a84ff7 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -649,6 +649,7 @@ struct hci_dev {
> int (*get_codec_config_data)(struct hci_dev *hdev, __u8 type,
> struct bt_codec *codec, __u8 *vnd_len,
> __u8 **vnd_data);
> + u8 (*classify_pkt_type)(struct hci_dev *hdev, struct sk_buff *skb);
> };
>
> #define HCI_PHY_HANDLE(handle) (handle & 0xff)
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index b3ee9ff17624..8b817a99cefd 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -2941,15 +2941,31 @@ int hci_reset_dev(struct hci_dev *hdev)
> }
> EXPORT_SYMBOL(hci_reset_dev);
>
> +static u8 hci_dev_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
> +{
> + if (hdev->classify_pkt_type)
> + return hdev->classify_pkt_type(hdev, skb);
> +
> + return hci_skb_pkt_type(skb);
> +}
> +
> /* Receive frame from HCI drivers */
> int hci_recv_frame(struct hci_dev *hdev, struct sk_buff *skb)
> {
> + u8 dev_pkt_type;
> +
> if (!hdev || (!test_bit(HCI_UP, &hdev->flags)
> && !test_bit(HCI_INIT, &hdev->flags))) {
> kfree_skb(skb);
> return -ENXIO;
> }
>
> + /* Check if the driver agree with packet type classification */
> + dev_pkt_type = hci_dev_classify_pkt_type(hdev, skb);
> + if (hci_skb_pkt_type(skb) != dev_pkt_type) {
> + hci_skb_pkt_type(skb) = dev_pkt_type;
> + }
> +
> switch (hci_skb_pkt_type(skb)) {
> case HCI_EVENT_PKT:
> break;
> --
> 2.45.1.288.g0e0cd299f1-goog
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] Bluetooth: Add vendor-specific packet classification for ISO data
2024-05-23 14:23 ` Luiz Augusto von Dentz
@ 2024-05-24 3:35 ` Ying Hsu
0 siblings, 0 replies; 5+ messages in thread
From: Ying Hsu @ 2024-05-24 3:35 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: linux-bluetooth, pmenzel, chromeos-bluetooth-upstreaming,
David S. Miller, Eric Dumazet, Jakub Kicinski, Johan Hedberg,
Marcel Holtmann, Paolo Abeni, linux-kernel, netdev
Hi Luiz,
I'm happy to move btusb_intel_classify_pkt_type into btintel.c in the
next patcheset.
As I only tested it on Intel USB BT controllers, I suggest Intel
further assess its applicability to other transports and future BT
controllers in another change.
On Thu, May 23, 2024 at 10:23 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Ying,
>
> On Thu, May 23, 2024 at 2:09 AM Ying Hsu <yinghsu@chromium.org> wrote:
> >
> > When HCI raw sockets are opened, the Bluetooth kernel module doesn't
> > track CIS/BIS connections. User-space applications have to identify
> > ISO data by maintaining connection information and look up the mapping
> > for each ACL data packet received. Besides, btsnoop log captured in
> > kernel couldn't tell ISO data from ACL data in this case.
> >
> > To avoid additional lookups, this patch introduces vendor-specific
> > packet classification for Intel BT controllers to distinguish
> > ISO data packets from ACL data packets.
> >
> > Signed-off-by: Ying Hsu <yinghsu@chromium.org>
> > ---
> > Tested LE audio unicast recording on a ChromeOS device with Intel AX211
> >
> > Changes in v2:
> > - Adds vendor-specific packet classificaton in hci_dev.
> > - Keeps reclassification in hci_recv_frame.
> >
> > drivers/bluetooth/btusb.c | 19 +++++++++++++++++++
> > include/net/bluetooth/hci_core.h | 1 +
> > net/bluetooth/hci_core.c | 16 ++++++++++++++++
> > 3 files changed, 36 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 79aefdb3324d..75561e749c50 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -966,6 +966,24 @@ static void btusb_intel_cmd_timeout(struct hci_dev *hdev)
> > gpiod_set_value_cansleep(reset_gpio, 0);
> > }
> >
> > +#define BT_USB_INTEL_ISODATA_HANDLE_BASE 0x900
> > +
> > +static u8 btusb_intel_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
>
> We might as well move this to btintel.c since it should not be USB specific.
>
> > +{
> > + /*
> > + * Distinguish ISO data packets form ACL data packets
> > + * based on their conneciton handle value range.
> > + */
> > + if (hci_skb_pkt_type(skb) == HCI_ACLDATA_PKT) {
> > + __u16 handle = __le16_to_cpu(hci_acl_hdr(skb)->handle);
> > +
> > + if (hci_handle(handle) >= BT_USB_INTEL_ISODATA_HANDLE_BASE)
> > + return HCI_ISODATA_PKT;
> > + }
> > +
> > + return hci_skb_pkt_type(skb);
> > +}
> > +
> > #define RTK_DEVCOREDUMP_CODE_MEMDUMP 0x01
> > #define RTK_DEVCOREDUMP_CODE_HW_ERR 0x02
> > #define RTK_DEVCOREDUMP_CODE_CMD_TIMEOUT 0x03
> > @@ -4451,6 +4469,7 @@ static int btusb_probe(struct usb_interface *intf,
> > /* Transport specific configuration */
> > hdev->send = btusb_send_frame_intel;
> > hdev->cmd_timeout = btusb_intel_cmd_timeout;
> > + hdev->classify_pkt_type = btusb_intel_classify_pkt_type;
> >
> > if (id->driver_info & BTUSB_INTEL_NO_WBS_SUPPORT)
> > btintel_set_flag(hdev, INTEL_ROM_LEGACY_NO_WBS_SUPPORT);
> > diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> > index 9231396fe96f..7b7068a84ff7 100644
> > --- a/include/net/bluetooth/hci_core.h
> > +++ b/include/net/bluetooth/hci_core.h
> > @@ -649,6 +649,7 @@ struct hci_dev {
> > int (*get_codec_config_data)(struct hci_dev *hdev, __u8 type,
> > struct bt_codec *codec, __u8 *vnd_len,
> > __u8 **vnd_data);
> > + u8 (*classify_pkt_type)(struct hci_dev *hdev, struct sk_buff *skb);
> > };
> >
> > #define HCI_PHY_HANDLE(handle) (handle & 0xff)
> > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> > index b3ee9ff17624..8b817a99cefd 100644
> > --- a/net/bluetooth/hci_core.c
> > +++ b/net/bluetooth/hci_core.c
> > @@ -2941,15 +2941,31 @@ int hci_reset_dev(struct hci_dev *hdev)
> > }
> > EXPORT_SYMBOL(hci_reset_dev);
> >
> > +static u8 hci_dev_classify_pkt_type(struct hci_dev *hdev, struct sk_buff *skb)
> > +{
> > + if (hdev->classify_pkt_type)
> > + return hdev->classify_pkt_type(hdev, skb);
> > +
> > + return hci_skb_pkt_type(skb);
> > +}
> > +
> > /* Receive frame from HCI drivers */
> > int hci_recv_frame(struct hci_dev *hdev, struct sk_buff *skb)
> > {
> > + u8 dev_pkt_type;
> > +
> > if (!hdev || (!test_bit(HCI_UP, &hdev->flags)
> > && !test_bit(HCI_INIT, &hdev->flags))) {
> > kfree_skb(skb);
> > return -ENXIO;
> > }
> >
> > + /* Check if the driver agree with packet type classification */
> > + dev_pkt_type = hci_dev_classify_pkt_type(hdev, skb);
> > + if (hci_skb_pkt_type(skb) != dev_pkt_type) {
> > + hci_skb_pkt_type(skb) = dev_pkt_type;
> > + }
> > +
> > switch (hci_skb_pkt_type(skb)) {
> > case HCI_EVENT_PKT:
> > break;
> > --
> > 2.45.1.288.g0e0cd299f1-goog
> >
>
>
> --
> Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-24 3:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 6:09 [PATCH v2] Bluetooth: Add vendor-specific packet classification for ISO data Ying Hsu
2024-05-23 6:37 ` [v2] " bluez.test.bot
2024-05-23 13:17 ` [PATCH v2] " Simon Horman
2024-05-23 14:23 ` Luiz Augusto von Dentz
2024-05-24 3:35 ` Ying Hsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox