From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ v1 1/4] client/player: Fix not setting config target_latency with edpoint.config
Date: Wed, 31 Jul 2024 14:57:15 +0100 [thread overview]
Message-ID: <20240731135718.429604-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This fixes not setting target_latency with endpoint.config command.
---
client/player.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/client/player.c b/client/player.c
index 3c3587f2c..93d6b62e2 100644
--- a/client/player.c
+++ b/client/player.c
@@ -1790,9 +1790,9 @@ static void append_ucast_qos(DBusMessageIter *iter, struct endpoint_config *cfg)
DBUS_TYPE_UINT32, &qos->delay);
if (cfg->target_latency) {
- bt_shell_printf("TargetLatency 0x%02x\n", qos->target_latency);
+ bt_shell_printf("TargetLatency 0x%02x\n", cfg->target_latency);
g_dbus_dict_append_entry(iter, "TargetLatency", DBUS_TYPE_BYTE,
- &qos->target_latency);
+ &cfg->target_latency);
}
append_io_qos(iter, &qos->io_qos);
@@ -3765,6 +3765,7 @@ static void cmd_config_endpoint(int argc, char *argv[])
/* Copy capabilities */
util_iov_append(cfg->caps, preset->data.iov_base,
preset->data.iov_len);
+ cfg->target_latency = preset->target_latency;
/* Set QoS parameters */
cfg->qos = preset->qos;
@@ -3960,7 +3961,7 @@ static void custom_target_latency(const char *input, void *user_data)
else if (!strcasecmp(input, "Balance"))
p->target_latency = 0x02;
else if (!strcasecmp(input, "High"))
- p->target_latency = 0x02;
+ p->target_latency = 0x03;
else {
char *endptr = NULL;
--
2.45.0
next reply other threads:[~2024-07-31 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 13:57 Luiz Augusto von Dentz [this message]
2024-07-31 13:57 ` [PATCH BlueZ v1 2/4] monitor: Fix crash parsing notification Luiz Augusto von Dentz
2024-07-31 13:57 ` [PATCH BlueZ v1 3/4] shared/bap: Fix not setting metadata Luiz Augusto von Dentz
2024-07-31 13:57 ` [PATCH BlueZ v1 4/4] bap: Fix not setting metatada Luiz Augusto von Dentz
2024-07-31 16:58 ` [BlueZ,v1,1/4] client/player: Fix not setting config target_latency with edpoint.config bluez.test.bot
2024-07-31 17:10 ` [PATCH BlueZ v1 1/4] " patchwork-bot+bluetooth
2024-08-01 9:30 ` patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731135718.429604-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox