Re: [syzbot] [pm?] INFO: trying to register non-static key in netdev_unregister_kobject

Re: [syzbot] [pm?] INFO: trying to register non-static key in netdev_unregister_kobject

[Hillf Danton]

On Mon, 27 May 2024 05:16:25 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    e67572cd2204 Linux 6.9-rc6
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13274a87180000

#syz test upstream  master

--- x/net/bluetooth/hci_core.c
+++ y/net/bluetooth/hci_core.c
@@ -2598,7 +2598,7 @@ int hci_register_dev(struct hci_dev *hde
 	if (!IS_ERR_OR_NULL(bt_debugfs))
 		hdev->debugfs = debugfs_create_dir(hdev->name, bt_debugfs);
 
-	error = device_add(&hdev->dev);
+	error = device_register(&hdev->dev);
 	if (error < 0)
 		goto err_wqueue;
 
--

Re: [syzbot] [pm?] INFO: trying to register non-static key in netdev_unregister_kobject

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+27c3c57b78da2a0995d8@syzkaller.appspotmail.com
Tested-by: syzbot+27c3c57b78da2a0995d8@syzkaller.appspotmail.com

Tested on:

commit:         6a0e3826 Merge tag 'for-6.11-rc2-tag' of git://git.ker..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=11eff061980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=73b1a61cb77f73e5
dashboard link: https://syzkaller.appspot.com/bug?extid=27c3c57b78da2a0995d8
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=14872e5d980000

Note: testing is done by a robot and is best-effort only.