* [PATCH] Bluetooth: Remove unnecessary braces around single line statement [not found] <20250127221052.197899-2-deaner92.ref@yahoo.com> @ 2025-01-27 22:10 ` deaner92 2025-01-27 22:31 ` bluez.test.bot ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: deaner92 @ 2025-01-27 22:10 UTC (permalink / raw) Cc: luiz.dentz, marcel, linux-bluetooth, markus.elfring, patchwork-bot, Jeremy Clifton From: Jeremy Clifton <deaner92@yahoo.com> Warning found with checkpatch.pl script. Remove unnecessary braces. Signed-off-by: Jeremy Clifton <deaner92@yahoo.com> --- drivers/bluetooth/bfusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c index cab93935cc7f..0d6ad50da046 100644 --- a/drivers/bluetooth/bfusb.c +++ b/drivers/bluetooth/bfusb.c @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) buf += 3; } - if (count < len) { + if (count < len) bt_dev_err(data->hdev, "block extends over URB buffer ranges"); - } if ((hdr & 0xe1) == 0xc1) bfusb_recv_block(data, hdr, buf, len); -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: Bluetooth: Remove unnecessary braces around single line statement 2025-01-27 22:10 ` [PATCH] Bluetooth: Remove unnecessary braces around single line statement deaner92 @ 2025-01-27 22:31 ` bluez.test.bot 2025-01-28 19:45 ` Jeremy Dean 2025-01-28 6:30 ` [PATCH] " Jeremy Dean 2025-01-29 20:20 ` patchwork-bot+bluetooth 2 siblings, 1 reply; 7+ messages in thread From: bluez.test.bot @ 2025-01-27 22:31 UTC (permalink / raw) To: linux-bluetooth, deaner92 [-- Attachment #1: Type: text/plain, Size: 2109 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=928654 ---Test result--- Test Summary: CheckPatch PENDING 0.37 seconds GitLint PENDING 0.24 seconds SubjectPrefix PASS 0.10 seconds BuildKernel PASS 24.21 seconds CheckAllWarning PASS 27.14 seconds CheckSparse PASS 30.24 seconds BuildKernel32 PASS 27.66 seconds TestRunnerSetup PASS 424.07 seconds TestRunner_l2cap-tester PASS 20.29 seconds TestRunner_iso-tester PASS 27.05 seconds TestRunner_bnep-tester PASS 4.75 seconds TestRunner_mgmt-tester FAIL 121.36 seconds TestRunner_rfcomm-tester PASS 7.54 seconds TestRunner_sco-tester PASS 9.38 seconds TestRunner_ioctl-tester PASS 14.45 seconds TestRunner_mesh-tester PASS 5.93 seconds TestRunner_smp-tester PASS 6.93 seconds TestRunner_userchan-tester PASS 4.92 seconds IncrementalBuild PENDING 0.51 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 490, Passed: 483 (98.6%), Failed: 3, Not Run: 4 Failed Test Cases LL Privacy - Add Device 3 (AL is full) Failed 0.186 seconds LL Privacy - Set Flags 1 (Add to RL) Failed 0.148 seconds LL Privacy - Start Discovery 2 (Disable RL) Failed 0.165 seconds ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Bluetooth: Remove unnecessary braces around single line statement 2025-01-27 22:31 ` bluez.test.bot @ 2025-01-28 19:45 ` Jeremy Dean 0 siblings, 0 replies; 7+ messages in thread From: Jeremy Dean @ 2025-01-28 19:45 UTC (permalink / raw) To: linux-bluetooth; +Cc: markus.elfring, patchwork-bot On Mon, Jan 27, 2025 at 02:31:06PM -0800, bluez.test.bot@gmail.com wrote: CCing Markus Elfring, your esmpt server kicked back the message. Jeremy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: Remove unnecessary braces around single line statement 2025-01-27 22:10 ` [PATCH] Bluetooth: Remove unnecessary braces around single line statement deaner92 2025-01-27 22:31 ` bluez.test.bot @ 2025-01-28 6:30 ` Jeremy Dean 2025-01-28 20:20 ` Luiz Augusto von Dentz 2025-01-29 20:20 ` patchwork-bot+bluetooth 2 siblings, 1 reply; 7+ messages in thread From: Jeremy Dean @ 2025-01-28 6:30 UTC (permalink / raw) To: linux-bluetooth; +Cc: markus.elfring, marcel It looks like this is failing a test case at tedd_an/TestRunner_mgmt-tester. Is this test failing because of the test itself? How can test or description of the test be obtained so that the necessary modifications can be made? Jeremy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: Remove unnecessary braces around single line statement 2025-01-28 6:30 ` [PATCH] " Jeremy Dean @ 2025-01-28 20:20 ` Luiz Augusto von Dentz 0 siblings, 0 replies; 7+ messages in thread From: Luiz Augusto von Dentz @ 2025-01-28 20:20 UTC (permalink / raw) To: Jeremy Dean; +Cc: linux-bluetooth, markus.elfring, marcel Hi Jeremy, On Tue, Jan 28, 2025 at 1:30 AM Jeremy Dean <deaner92@yahoo.com> wrote: > > It looks like this is failing a test case at > tedd_an/TestRunner_mgmt-tester. > > Is this test failing because of the test itself? > How can test or description of the test be obtained so that > the necessary modifications can be made? That is some race with mgmt-tester it seems, not related to the problem, that said you didn't include the output of checkpatch.pl that you are trying to fix. You can use git commit --amend and git format-patch -v2 + git send-email to send the v2. > Jeremy > -- Luiz Augusto von Dentz ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: Remove unnecessary braces around single line statement 2025-01-27 22:10 ` [PATCH] Bluetooth: Remove unnecessary braces around single line statement deaner92 2025-01-27 22:31 ` bluez.test.bot 2025-01-28 6:30 ` [PATCH] " Jeremy Dean @ 2025-01-29 20:20 ` patchwork-bot+bluetooth 2 siblings, 0 replies; 7+ messages in thread From: patchwork-bot+bluetooth @ 2025-01-29 20:20 UTC (permalink / raw) To: Jeremy Dean Cc: luiz.dentz, marcel, linux-bluetooth, markus.elfring, patchwork-bot Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 27 Jan 2025 23:10:37 +0100 you wrote: > From: Jeremy Clifton <deaner92@yahoo.com> > > Warning found with checkpatch.pl script. Remove unnecessary braces. > > Signed-off-by: Jeremy Clifton <deaner92@yahoo.com> > --- > drivers/bluetooth/bfusb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Here is the summary with links: - Bluetooth: Remove unnecessary braces around single line statement https://git.kernel.org/bluetooth/bluetooth-next/c/a2a245849af8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20250125165804.11486-1-deaner92.ref@yahoo.com>]
* [PATCH] Bluetooth: Unnecessary braces around single line statment. [not found] <20250125165804.11486-1-deaner92.ref@yahoo.com> @ 2025-01-25 16:58 ` deaner92 2025-01-26 8:02 ` Paul Menzel 0 siblings, 1 reply; 7+ messages in thread From: deaner92 @ 2025-01-25 16:58 UTC (permalink / raw) Cc: deaner92, marcel, luiz.dentz, linux-bluetooth, linux-kernel From: Jeremy Clifton <deaner92@yahoo.com> Warning found with checkpatch.pl script. Removed unnecessary braces. Signed-off-by: Jeremy Clifton <deaner92@yahoo.com> --- drivers/bluetooth/bfusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c index cab93935cc7f..0d6ad50da046 100644 --- a/drivers/bluetooth/bfusb.c +++ b/drivers/bluetooth/bfusb.c @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) buf += 3; } - if (count < len) { + if (count < len) bt_dev_err(data->hdev, "block extends over URB buffer ranges"); - } if ((hdr & 0xe1) == 0xc1) bfusb_recv_block(data, hdr, buf, len); -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: Unnecessary braces around single line statment. 2025-01-25 16:58 ` [PATCH] Bluetooth: Unnecessary braces around single line statment deaner92 @ 2025-01-26 8:02 ` Paul Menzel 2025-01-26 19:27 ` [PATCH] Bluetooth: Remove unnecessary braces around single line statement Jeremy Dean 0 siblings, 1 reply; 7+ messages in thread From: Paul Menzel @ 2025-01-26 8:02 UTC (permalink / raw) To: Jeremy Clifton; +Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel Dear Jeremy, Thank you for your patch. Could you please make the summary/title a statement, and remove the dot/period at the end: Bluetooth: Remove unnecessary braces around single line statement Am 25.01.25 um 17:58 schrieb deaner92@yahoo.com: > From: Jeremy Clifton <deaner92@yahoo.com> > > Warning found with checkpatch.pl script. Removed unnecessary braces. I’d use imperative mood for the second sentence: Remove unnecessary braces. Also please add a Fixes: tag. > Signed-off-by: Jeremy Clifton <deaner92@yahoo.com> > --- > drivers/bluetooth/bfusb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c > index cab93935cc7f..0d6ad50da046 100644 > --- a/drivers/bluetooth/bfusb.c > +++ b/drivers/bluetooth/bfusb.c > @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) > buf += 3; > } > > - if (count < len) { > + if (count < len) > bt_dev_err(data->hdev, "block extends over URB buffer ranges"); > - } > > if ((hdr & 0xe1) == 0xc1) > bfusb_recv_block(data, hdr, buf, len); Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Bluetooth: Remove unnecessary braces around single line statement 2025-01-26 8:02 ` Paul Menzel @ 2025-01-26 19:27 ` Jeremy Dean 0 siblings, 0 replies; 7+ messages in thread From: Jeremy Dean @ 2025-01-26 19:27 UTC (permalink / raw) To: Paul Menzel; +Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel Dear Paul, I have changed the subject. Fixes: Coding style, unnecessary braces On Sun, Jan 26, 2025 at 09:02:04AM +0100, Paul Menzel wrote: > Dear Jeremy, > > > Thank you for your patch. Could you please make the summary/title a > statement, and remove the dot/period at the end: > > Bluetooth: Remove unnecessary braces around single line statement > > Am 25.01.25 um 17:58 schrieb deaner92@yahoo.com: > > From: Jeremy Clifton <deaner92@yahoo.com> > > > > Warning found with checkpatch.pl script. Removed unnecessary braces. > > I’d use imperative mood for the second sentence: > > Remove unnecessary braces. > > Also please add a Fixes: tag. > > > Signed-off-by: Jeremy Clifton <deaner92@yahoo.com> > > --- > > drivers/bluetooth/bfusb.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c > > index cab93935cc7f..0d6ad50da046 100644 > > --- a/drivers/bluetooth/bfusb.c > > +++ b/drivers/bluetooth/bfusb.c > > @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb) > > buf += 3; > > } > > - if (count < len) { > > + if (count < len) > > bt_dev_err(data->hdev, "block extends over URB buffer ranges"); > > - } > > if ((hdr & 0xe1) == 0xc1) > > bfusb_recv_block(data, hdr, buf, len); > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> > > > Kind regards, > > Paul ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-01-29 20:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250127221052.197899-2-deaner92.ref@yahoo.com>
2025-01-27 22:10 ` [PATCH] Bluetooth: Remove unnecessary braces around single line statement deaner92
2025-01-27 22:31 ` bluez.test.bot
2025-01-28 19:45 ` Jeremy Dean
2025-01-28 6:30 ` [PATCH] " Jeremy Dean
2025-01-28 20:20 ` Luiz Augusto von Dentz
2025-01-29 20:20 ` patchwork-bot+bluetooth
[not found] <20250125165804.11486-1-deaner92.ref@yahoo.com>
2025-01-25 16:58 ` [PATCH] Bluetooth: Unnecessary braces around single line statment deaner92
2025-01-26 8:02 ` Paul Menzel
2025-01-26 19:27 ` [PATCH] Bluetooth: Remove unnecessary braces around single line statement Jeremy Dean
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox