linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btmtk: Remove resetting mt7921 before downloading the fw
@ 2024-08-22  5:23 Hao Qin
  2024-09-10 17:09 ` Marc Payne
  0 siblings, 1 reply; 28+ messages in thread
From: Hao Qin @ 2024-08-22  5:23 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg, Luiz Von Dentz
  Cc: Chris Lu, Sean Wang, Deren Wu, Aaron Hou, Steve Lee,
	linux-bluetooth, linux-kernel, linux-mediatek, Hao Qin

Remove resetting mt7921 before downloading the fw, as it may cause
command timeout when performing the reset.

Signed-off-by: Hao Qin <hao.qin@mediatek.com>
---
 drivers/bluetooth/btmtk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
index 2b7c80043aa2..a46f70135cbd 100644
--- a/drivers/bluetooth/btmtk.c
+++ b/drivers/bluetooth/btmtk.c
@@ -1326,7 +1326,6 @@ int btmtk_usb_setup(struct hci_dev *hdev)
 		fwname = FIRMWARE_MT7668;
 		break;
 	case 0x7922:
-	case 0x7961:
 	case 0x7925:
 		/* Reset the device to ensure it's in the initial state before
 		 * downloading the firmware to ensure.
@@ -1334,7 +1333,8 @@ int btmtk_usb_setup(struct hci_dev *hdev)
 
 		if (!test_bit(BTMTK_FIRMWARE_LOADED, &btmtk_data->flags))
 			btmtk_usb_subsys_reset(hdev, dev_id);
-
+		fallthrough;
+	case 0x7961:
 		btmtk_fw_get_filename(fw_bin_name, sizeof(fw_bin_name), dev_id,
 				      fw_version, fw_flavor);
 
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH] Bluetooth: btmtk: Remove resetting mt7921 before downloading the fw
@ 2025-01-10  9:55 Hao Qin
  2025-01-14 17:20 ` patchwork-bot+bluetooth
  0 siblings, 1 reply; 28+ messages in thread
From: Hao Qin @ 2025-01-10  9:55 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg, Luiz Von Dentz
  Cc: Sean Wang, Deren Wu, Aaron Hou, Chris Lu, Steve Lee,
	linux-bluetooth, linux-kernel, linux-mediatek, Hao Qin

Remove resetting mt7921 before downloading the fw, as it may cause
command timeout when performing the reset.

Signed-off-by: Hao Qin <hao.qin@mediatek.com>
---
 drivers/bluetooth/btmtk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
index 224eafc27dbe..68846c5bd4f7 100644
--- a/drivers/bluetooth/btmtk.c
+++ b/drivers/bluetooth/btmtk.c
@@ -1329,7 +1329,6 @@ int btmtk_usb_setup(struct hci_dev *hdev)
 		fwname = FIRMWARE_MT7668;
 		break;
 	case 0x7922:
-	case 0x7961:
 	case 0x7925:
 		/* Reset the device to ensure it's in the initial state before
 		 * downloading the firmware to ensure.
@@ -1337,7 +1336,8 @@ int btmtk_usb_setup(struct hci_dev *hdev)
 
 		if (!test_bit(BTMTK_FIRMWARE_LOADED, &btmtk_data->flags))
 			btmtk_usb_subsys_reset(hdev, dev_id);
-
+		fallthrough;
+	case 0x7961:
 		btmtk_fw_get_filename(fw_bin_name, sizeof(fw_bin_name), dev_id,
 				      fw_version, fw_flavor);
 
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2025-01-29 18:31 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22  5:23 [PATCH] Bluetooth: btmtk: Remove resetting mt7921 before downloading the fw Hao Qin
2024-09-10 17:09 ` Marc Payne
2024-09-12  7:09   ` Chris Lu (陸稚泓)
2024-09-17 19:53     ` marc.payne
     [not found]       ` <9bfbbf24ac2480d94d3455f7e33e4b5502b38ced.camel@mediatek.com>
2024-09-18 13:37         ` Luiz Augusto von Dentz
2024-09-19  3:26           ` Chris Lu (陸稚泓)
2024-09-19 22:25             ` marc.payne
2024-09-20  6:27               ` Chris Lu (陸稚泓)
2024-10-14  9:29                 ` Linux regression tracking (Thorsten Leemhuis)
2024-10-22 10:56                   ` Takashi Iwai
2024-10-30  9:21                     ` Thorsten Leemhuis
2024-10-30 11:03                       ` Chris Lu (陸稚泓)
2024-10-30 11:29                         ` Thorsten Leemhuis
2024-11-01  7:11                           ` Chris Lu (陸稚泓)
2024-11-01 14:22                             ` Thorsten Leemhuis
2024-11-02 10:04                               ` Takashi Iwai
2024-11-11  9:21                                 ` Linux regression tracking (Thorsten Leemhuis)
2025-01-13 22:18                                   ` Sergio Callegari
2025-01-18 16:58                                     ` John Glotzer
2025-01-28  0:04                                       ` Bitterblue Smith
2025-01-29 18:31                                         ` John Glotzer
2024-11-27 23:14                               ` [REGRESSION] bluetooth: mt7921: Crash on Resume From Suspend And Hibernate John Glotzer
2024-12-05 12:59                                 ` Sergio Callegari
2024-12-06  2:29                                   ` John Glotzer
2024-12-21  9:52                                   ` Sergio Callegari
2024-09-18 16:02         ` [PATCH] Bluetooth: btmtk: Remove resetting mt7921 before downloading the fw marc.payne
  -- strict thread matches above, loose matches on Subject: below --
2025-01-10  9:55 Hao Qin
2025-01-14 17:20 ` patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).