From: "Frédéric Danis" <frederic.danis@collabora.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ v2 2/2] mpris-proxy: Fix infinite list items reception
Date: Tue, 4 Feb 2025 16:40:19 +0100 [thread overview]
Message-ID: <20250204154020.95539-2-frederic.danis@collabora.com> (raw)
In-Reply-To: <20250204154020.95539-1-frederic.danis@collabora.com>
Samsung Music app on Android phone send play list items in loop if
highest bit is set to 1, so limit playlist to 0x7FFFFFFF items.
---
tools/mpris-proxy.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/mpris-proxy.c b/tools/mpris-proxy.c
index 9edd42e99..b08733314 100644
--- a/tools/mpris-proxy.c
+++ b/tools/mpris-proxy.c
@@ -1692,6 +1692,7 @@ static const GDBusPropertyTable tracklist_properties[] = {
static void list_items_setup(DBusMessageIter *iter, void *user_data)
{
DBusMessageIter dict;
+ uint32_t val = 0;
dbus_message_iter_open_container(iter, DBUS_TYPE_ARRAY,
DBUS_DICT_ENTRY_BEGIN_CHAR_AS_STRING
@@ -1699,6 +1700,12 @@ static void list_items_setup(DBusMessageIter *iter, void *user_data)
DBUS_TYPE_VARIANT_AS_STRING
DBUS_DICT_ENTRY_END_CHAR_AS_STRING,
&dict);
+ dict_append_entry(&dict, "Start", DBUS_TYPE_UINT32, &val);
+ /* Samsung Music app on Android phone send play list items in loop if
+ * highest bit is set to 1, so limit playlist to 0x7FFFFFFF items
+ */
+ val = 0x7FFFFFFF;
+ dict_append_entry(&dict, "End", DBUS_TYPE_UINT32, &val);
dbus_message_iter_close_container(iter, &dict);
}
--
2.43.0
next prev parent reply other threads:[~2025-02-04 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 15:40 [PATCH BlueZ v2 1/2] mpris-proxy: Add mpris:artUrl support Frédéric Danis
2025-02-04 15:40 ` Frédéric Danis [this message]
2025-02-04 17:13 ` [BlueZ,v2,1/2] " bluez.test.bot
2025-02-04 22:50 ` [PATCH BlueZ v2 1/2] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204154020.95539-2-frederic.danis@collabora.com \
--to=frederic.danis@collabora.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox