Re: [PATCH v4 1/3] Bluetooth: Fix possible race with userspace of sysfs isoc_alt

Greg KH
2025-02-13T12:10:14Z

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Feb 13, 2025 at 07:57:15PM +0800, Hsin-chen Chuang wrote:
> The btusb driver data is allocated by devm_kzalloc and is
> automatically freed on driver detach, so I guess we don't have
> anything to do here.

What? A struct device should NEVER be allocated with devm_kzalloc.
That's just not going to work at all.

> Or perhaps we should move btusb_disconnect's content here? Luiz, what
> do you think?

I think something is really wrong here. Why are you adding a new struct
device to the system? What requires that? What is this new device
going to be used for?

confused,

greg k-h