From: Greg KH <gregkh@linuxfoundation.org>
To: Hsin-chen Chuang <chharry@google.com>
Cc: luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org,
chromeos-bluetooth-upstreaming@chromium.org,
Hsin-chen Chuang <chharry@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Ying Hsu <yinghsu@chromium.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v4 1/3] Bluetooth: Fix possible race with userspace of sysfs isoc_alt
Date: Thu, 13 Feb 2025 13:10:11 +0100 [thread overview]
Message-ID: <2025021347-washboard-slashed-5d08@gregkh> (raw)
In-Reply-To: <CADg1FFdez0OdNDPRFPFxNHL_JcKmHE6KNxnYvt4sK7i+Uw6opA@mail.gmail.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Feb 13, 2025 at 07:57:15PM +0800, Hsin-chen Chuang wrote:
> The btusb driver data is allocated by devm_kzalloc and is
> automatically freed on driver detach, so I guess we don't have
> anything to do here.
What? A struct device should NEVER be allocated with devm_kzalloc.
That's just not going to work at all.
> Or perhaps we should move btusb_disconnect's content here? Luiz, what
> do you think?
I think something is really wrong here. Why are you adding a new struct
device to the system? What requires that? What is this new device
going to be used for?
confused,
greg k-h
next prev parent reply other threads:[~2025-02-13 12:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 3:43 [PATCH v4 1/3] Bluetooth: Fix possible race with userspace of sysfs isoc_alt Hsin-chen Chuang
2025-02-13 3:44 ` [PATCH v4 2/3] Bluetooth: Always allow SCO packets for user channel Hsin-chen Chuang
2025-02-13 3:44 ` [PATCH v4 3/3] Bluetooth: Add ABI doc for sysfs isoc_alt Hsin-chen Chuang
2025-02-13 10:01 ` Greg KH
2025-02-13 10:07 ` Hsin-chen Chuang
2025-02-13 10:13 ` Greg KH
2025-02-13 10:14 ` Hsin-chen Chuang
2025-02-13 4:34 ` [v4,1/3] Bluetooth: Fix possible race with userspace of " bluez.test.bot
2025-02-13 10:01 ` [PATCH v4 1/3] " Greg KH
2025-02-13 11:57 ` Hsin-chen Chuang
2025-02-13 12:10 ` Greg KH [this message]
2025-02-13 13:33 ` Hsin-chen Chuang
2025-02-13 13:45 ` Greg KH
2025-02-13 14:06 ` Hsin-chen Chuang
2025-02-13 14:22 ` Luiz Augusto von Dentz
2025-02-13 14:35 ` Greg KH
2025-02-13 15:56 ` Luiz Augusto von Dentz
2025-02-13 16:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021347-washboard-slashed-5d08@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chharry@chromium.org \
--cc=chharry@google.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yinghsu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox