public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ v1] client/player: Fix changing preset SDU
Date: Fri,  7 Mar 2025 11:34:35 -0500	[thread overview]
Message-ID: <20250307163435.49599-1-luiz.dentz@gmail.com> (raw)

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes changing preset SDU when configuring multiple channels, the
SDU of the configuration is the one the needs to be adjusted not the
preset itself.
---
 client/player.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/client/player.c b/client/player.c
index 17817c45a921..9d38347d6b91 100644
--- a/client/player.c
+++ b/client/player.c
@@ -2296,8 +2296,12 @@ static DBusMessage *endpoint_select_properties_reply(struct endpoint *ep,
 		/* Adjust the SDU size based on the number of
 		 * locations/channels that is being requested.
 		 */
-		if (channels > 1)
-			qos->sdu *= channels;
+		if (channels > 1) {
+			if (ep->broadcast)
+				cfg->qos.bcast.io_qos.sdu *= channels;
+			else
+				cfg->qos.ucast.io_qos.sdu *= channels;
+		}
 	}
 
 	dbus_message_iter_init_append(reply, &iter);
-- 
2.48.1


             reply	other threads:[~2025-03-07 16:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 16:34 Luiz Augusto von Dentz [this message]
2025-03-07 17:40 ` [BlueZ,v1] client/player: Fix changing preset SDU bluez.test.bot
2025-03-18 18:00 ` [PATCH BlueZ v1] " patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307163435.49599-1-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox