From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47FC027C864; Thu, 3 Apr 2025 19:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707261; cv=none; b=sx6hX5/37aSOTkYJdEmosoVqCmuA4YVH3l9rx/iXedWhmu3h66J1K/eW6M84jXc9XQw9f4iyv6ucnDMDc18WJoWRCHhM12gDcQA0iZQTyNWFF3j25t+v7GnxsEyJjJYXpVv86u0fHSiUOJLddA/IGjaIS+gbJOgldCGe+iCm6Go= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743707261; c=relaxed/simple; bh=pT4Q3S01Su1Abesxq99U45A/8NkbW73u1b0G/aLZtOI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GlUWQaOsY0vZeRsN0icW1nCEKDLaquopN2s11qBHNqw0+aXZTPJS04wG94cWeMwYZSuKt4QRcgRRVrVmcHhAW4DxsVoT3eFt65ew8s26zHDhoodd2dE8k+VPQsdM1CqGtFkL+8LAiuL70rgOafzbPgmPODpCF1jBt6XWA91ZiSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bSmFME+Q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bSmFME+Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3489C4CEE3; Thu, 3 Apr 2025 19:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743707260; bh=pT4Q3S01Su1Abesxq99U45A/8NkbW73u1b0G/aLZtOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bSmFME+Q/gEdXtc6Dd9RWMBUroTdS2j1TuJrF6m/hj4+RocEutQN3GuEPspxUB2qs MgR9rcw0Xwj6Py1GZlYEITMsRIkxNfAZc5sG/8OEeKB+2dvhroAd49ifxpfjVykVe5 lrjR6+amfZ4T78+VCqbAv/wr1FQxyQWdg7lhDCUh/awxkiOz9c2RHYdLzGFiYJ11JT DAMkgGg4gXj/DQgXRE3UozASYO7ZYxtwREx46xapfkMy7qdOC2IcZZd28iCc4U/Eji 6SC/pacNMAUEM9IJ65w1Lz1VO5BzbM/4x2BDT51aheOT020UGR4u9y195zKAQpB9bc Bx2rovc/XxSoQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dmitry Baryshkov , Luiz Augusto von Dentz , Sasha Levin , marcel@holtmann.org, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org Subject: [PATCH AUTOSEL 6.12 45/47] Bluetooth: qca: simplify WCN399x NVM loading Date: Thu, 3 Apr 2025 15:05:53 -0400 Message-Id: <20250403190555.2677001-45-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403190555.2677001-1-sashal@kernel.org> References: <20250403190555.2677001-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.21 Content-Transfer-Encoding: 8bit From: Dmitry Baryshkov [ Upstream commit 1cc41b5092e3aa511454ec882c525af311bee631 ] The WCN399x code has two separate cases for loading the NVM data. In preparation to adding support for WCN3950, which also requires similar quirk, split the "variant" to be specified explicitly and merge two snprintfs into a single one. Signed-off-by: Dmitry Baryshkov Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- drivers/bluetooth/btqca.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index 04d02c746ec0f..dd2c0485b9848 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -785,6 +785,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, const char *firmware_name) { struct qca_fw_config config = {}; + const char *variant = ""; int err; u8 rom_ver = 0; u32 soc_ver; @@ -879,13 +880,11 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, case QCA_WCN3990: case QCA_WCN3991: case QCA_WCN3998: - if (le32_to_cpu(ver.soc_id) == QCA_WCN3991_SOC_ID) { - snprintf(config.fwname, sizeof(config.fwname), - "qca/crnv%02xu.bin", rom_ver); - } else { - snprintf(config.fwname, sizeof(config.fwname), - "qca/crnv%02x.bin", rom_ver); - } + if (le32_to_cpu(ver.soc_id) == QCA_WCN3991_SOC_ID) + variant = "u"; + + snprintf(config.fwname, sizeof(config.fwname), + "qca/crnv%02x%s.bin", rom_ver, variant); break; case QCA_WCN3988: snprintf(config.fwname, sizeof(config.fwname), -- 2.39.5