From: Rob Herring <robh@kernel.org>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Cc: marcel@holtmann.org, luiz.dentz@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
amitkumar.karwar@nxp.com, sherry.sun@nxp.com,
manjeet.gupta@nxp.com
Subject: Re: [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support for host-wakeup
Date: Fri, 11 Apr 2025 17:08:59 -0500 [thread overview]
Message-ID: <20250411220859.GA4161337-robh@kernel.org> (raw)
In-Reply-To: <20250411163719.326558-1-neeraj.sanjaykale@nxp.com>
On Fri, Apr 11, 2025 at 10:07:18PM +0530, Neeraj Sanjay Kale wrote:
> Add support for host-wakeup on GPIO interrupt.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
> .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index d02e9dd847ef..ab1411c05f49 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -48,6 +48,12 @@ properties:
> description:
> The GPIO number of the NXP chipset used for BT_WAKE_IN.
>
> + host-wakeup-gpios:
> + maxItems: 1
> + description:
> + Host wakeup by falling edge interrupt on this GPIO which
> + is connected to BT_WAKE_OUT pin of the NXP chipset.
Read the description in the Broadcom binding you copied this from.
Define this as an interrupt named 'wakeup', not a GPIO. After all, to be
a wake-up source, it kind of has to be an interrupt.
Just because I said no to putting wakeup source handling in serdev,
doesn't mean the binding should change. The handling just has to be in
the driver.
Rob
next prev parent reply other threads:[~2025-04-11 22:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 16:37 [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support for host-wakeup Neeraj Sanjay Kale
2025-04-11 16:37 ` [PATCH v1 2/2] Bluetooth: btnxpuart: Implement host-wakeup feature Neeraj Sanjay Kale
2025-04-11 17:05 ` [v1,1/2] dt-bindings: net: bluetooth: nxp: Add support for host-wakeup bluez.test.bot
2025-04-11 22:08 ` Rob Herring [this message]
2025-04-14 17:25 ` [EXT] Re: [PATCH v1 1/2] " Neeraj Sanjay Kale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411220859.GA4161337-robh@kernel.org \
--to=robh@kernel.org \
--cc=amitkumar.karwar@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=manjeet.gupta@nxp.com \
--cc=marcel@holtmann.org \
--cc=neeraj.sanjaykale@nxp.com \
--cc=sherry.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox