public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuni1840@gmail.com>
To: pav@iki.fi
Cc: bluez.test.bot@gmail.com, kuni1840@gmail.com,
	linux-bluetooth@vger.kernel.org
Subject: Re: [v1] bluetooth: hci_core: Fix use-after-free in vhci_flush().
Date: Sat, 14 Jun 2025 17:26:01 -0700	[thread overview]
Message-ID: <20250615002620.2343407-1-kuni1840@gmail.com> (raw)
In-Reply-To: <6d9fd112f73fd56511318a0bc8f9681f7348de27.camel@iki.fi>

From: Pauli Virtanen <pav@iki.fi>
Date: Sat, 14 Jun 2025 14:30:18 +0300
> pe, 2025-06-13 kello 19:20 -0700, Kuniyuki Iwashima kirjoitti:
> 
> [clip]
> > > ##############################
> > > Test: TestRunner_mesh-tester - FAIL
> > > Desc: Run mesh-tester with test-runner
> > > Output:
> > > BUG: KASAN: slab-use-after-free in run_timer_softirq+0x76b/0x7d0
> > > WARNING: CPU: 0 PID: 68 at kernel/workqueue.c:2257 __queue_work+0x93e/0xba0
> > > Total: 10, Passed: 9 (90.0%), Failed: 1, Not Run: 0
> > 
> > It seems the same splat can be seen on other patches.
> > https://lore.kernel.org/linux-bluetooth/?q=KASAN+run_timer_softirq
> > 
> > Is this a known issue, or are we all making the same mistake ?
> > If latter, can I get the full splat 
> 
> https://github.com/BluezTestBot/bluetooth-next/pull/2887/checks
> 
> But probably it's an existing issue.

I agree this is a separate issue.

To me, disable_work_sync(&hdev->rx_work) in hci_unregister_dev()
is doing the proper synchronisation between the work, so it might
be a problem in the workqueue code.


> 
> > and some guidance to run
> > the same test locally (if it's easy to set up) ?
> 
> Please see
> https://github.com/bluez/bluez/blob/master/doc/test-runner.rst#examples
> 
> I does not reproduce locally for me however.

Thanks!

  reply	other threads:[~2025-06-15  0:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 23:02 [PATCH v1] bluetooth: hci_core: Fix use-after-free in vhci_flush() Kuniyuki Iwashima
2025-06-13 23:34 ` [v1] " bluez.test.bot
2025-06-14  2:20   ` Kuniyuki Iwashima
2025-06-14 11:30     ` Pauli Virtanen
2025-06-15  0:26       ` Kuniyuki Iwashima [this message]
2025-06-14  5:38 ` [PATCH v1] " Paul Menzel
2025-06-15  0:01   ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250615002620.2343407-1-kuni1840@gmail.com \
    --to=kuni1840@gmail.com \
    --cc=bluez.test.bot@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=pav@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox