public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Ismagil Iskakov <i.iskakov@omp.ru>
To: <linux-bluetooth@vger.kernel.org>
Cc: Ismagil Iskakov <i.iskakov@omp.ru>
Subject: [PATCH BlueZ v3 1/4] btio: fix range validation of security level
Date: Wed, 9 Jul 2025 15:18:49 +0300	[thread overview]
Message-ID: <20250709121852.2811885-2-i.iskakov@omp.ru> (raw)
In-Reply-To: <20250709121852.2811885-1-i.iskakov@omp.ru>

Arrays inside l2cap_set_lm/rfcomm_set_lm functions are of size 4,
but the bounds check allows the value 4 for 'level'.
---
 btio/btio.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/btio/btio.c b/btio/btio.c
index b8afe0580..bc14199f2 100644
--- a/btio/btio.c
+++ b/btio/btio.c
@@ -474,6 +474,12 @@ static gboolean set_sec_level(int sock, BtIOType type, int level, GError **err)
 		return FALSE;
 	}
 
+	if (level == BT_SECURITY_FIPS) {
+		g_set_error(err, BT_IO_ERROR, EINVAL,
+				"FIPS security level is not supported for L2CAP_LM/RFCOMM_LM");
+		return FALSE;
+	}
+
 	if (type == BT_IO_L2CAP)
 		ret = l2cap_set_lm(sock, level);
 	else
-- 
2.34.1


  reply	other threads:[~2025-07-09 12:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09 12:18 [PATCH BlueZ v3 0/4] Fix bugs found by static analysis Ismagil Iskakov
2025-07-09 12:18 ` Ismagil Iskakov [this message]
2025-07-09 13:40   ` bluez.test.bot
2025-07-09 12:18 ` [PATCH BlueZ v3 2/4] profiles/audio: add nullity checks Ismagil Iskakov
2025-07-09 12:18 ` [PATCH BlueZ v3 3/4] src/shared: " Ismagil Iskakov
2025-07-09 12:18 ` [PATCH BlueZ v3 4/4] obexd/client: fix err condition causing memleak Ismagil Iskakov
2025-07-09 12:53 ` [PATCH BlueZ v3 0/4] Fix bugs found by static analysis Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250709121852.2811885-2-i.iskakov@omp.ru \
    --to=i.iskakov@omp.ru \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox