From: Jeongjun Park <aha310510@gmail.com>
To: stable@vger.kernel.org
Cc: gregkh@linuxfoundation.org, tglx@linutronix.de,
Julia.Lawall@inria.fr, akpm@linux-foundation.org,
anna-maria@linutronix.de, arnd@arndb.de,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, luiz.dentz@gmail.com, marcel@holtmann.org,
maz@kernel.org, peterz@infradead.org, rostedt@goodmis.org,
sboyd@kernel.org, viresh.kumar@linaro.org,
Jacob Keller <jacob.e.keller@intel.com>,
Jeongjun Park <aha310510@gmail.com>
Subject: [PATCH 6.1.y 01/12] Documentation: Remove bogus claim about del_timer_sync()
Date: Sat, 11 Oct 2025 00:02:41 +0900 [thread overview]
Message-ID: <20251010150252.1115788-2-aha310510@gmail.com> (raw)
In-Reply-To: <20251010150252.1115788-1-aha310510@gmail.com>
From: Thomas Gleixner <tglx@linutronix.de>
[ Upstream commit b0b0aa5d858d4d2fe39a5e4486e0550e858108f6 ]
del_timer_sync() does not return the number of times it tried to delete the
timer which rearms itself. It's clearly documented:
The function returns whether it has deactivated a pending timer or not.
This part of the documentation is from 2003 where del_timer_sync() really
returned the number of deletion attempts for unknown reasons. The code
was rewritten in 2005, but the documentation was not updated.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Link: https://lore.kernel.org/r/20221123201624.452282769@linutronix.de
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
---
Documentation/kernel-hacking/locking.rst | 3 +--
Documentation/translations/it_IT/kernel-hacking/locking.rst | 4 +---
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/Documentation/kernel-hacking/locking.rst b/Documentation/kernel-hacking/locking.rst
index 6805ae6e86e6..b26e4a3a9b7e 100644
--- a/Documentation/kernel-hacking/locking.rst
+++ b/Documentation/kernel-hacking/locking.rst
@@ -1006,8 +1006,7 @@ Another common problem is deleting timers which restart themselves (by
calling add_timer() at the end of their timer function).
Because this is a fairly common case which is prone to races, you should
use del_timer_sync() (``include/linux/timer.h``) to
-handle this case. It returns the number of times the timer had to be
-deleted before we finally stopped it from adding itself back in.
+handle this case.
Locking Speed
=============
diff --git a/Documentation/translations/it_IT/kernel-hacking/locking.rst b/Documentation/translations/it_IT/kernel-hacking/locking.rst
index 51af37f2d621..eddfba806e13 100644
--- a/Documentation/translations/it_IT/kernel-hacking/locking.rst
+++ b/Documentation/translations/it_IT/kernel-hacking/locking.rst
@@ -1027,9 +1027,7 @@ Un altro problema è l'eliminazione dei temporizzatori che si riavviano
da soli (chiamando add_timer() alla fine della loro esecuzione).
Dato che questo è un problema abbastanza comune con una propensione
alle corse critiche, dovreste usare del_timer_sync()
-(``include/linux/timer.h``) per gestire questo caso. Questa ritorna il
-numero di volte che il temporizzatore è stato interrotto prima che
-fosse in grado di fermarlo senza che si riavviasse.
+(``include/linux/timer.h``) per gestire questo caso.
Velocità della sincronizzazione
===============================
--
next prev parent reply other threads:[~2025-10-10 15:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 15:02 [PATCH 6.1.y 00/12] timers: Provide timer_shutdown[_sync]() Jeongjun Park
2025-10-10 15:02 ` Jeongjun Park [this message]
2025-10-10 15:16 ` bluez.test.bot
2025-10-10 15:02 ` [PATCH 6.1.y 02/12] ARM: spear: Do not use timer namespace for timer_shutdown() function Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 03/12] clocksource/drivers/arm_arch_timer: " Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 04/12] clocksource/drivers/sp804: " Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 05/12] timers: Replace BUG_ON()s Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 06/12] Documentation: Replace del_timer/del_timer_sync() Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 07/12] timers: Silently ignore timers with a NULL function Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 08/12] timers: Split [try_to_]del_timer[_sync]() to prepare for shutdown mode Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 09/12] timers: Add shutdown mechanism to the internal functions Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 10/12] timers: Provide timer_shutdown[_sync]() Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 11/12] timers: Update the documentation to reflect on the new timer_shutdown() API Jeongjun Park
2025-10-10 15:02 ` [PATCH 6.1.y 12/12] Bluetooth: hci_qca: Fix the teardown problem for real Jeongjun Park
2025-10-20 11:17 ` [PATCH 6.1.y 00/12] timers: Provide timer_shutdown[_sync]() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010150252.1115788-2-aha310510@gmail.com \
--to=aha310510@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=maz@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).