* [PATCH v1 1/2] Bluetooth: hci_bcm4377: Use generic power management
@ 2025-12-10 21:17 Vaibhav Gupta
2025-12-10 22:05 ` [v1,1/2] " bluez.test.bot
2025-12-10 23:21 ` [PATCH v2] " Vaibhav Gupta
0 siblings, 2 replies; 4+ messages in thread
From: Vaibhav Gupta @ 2025-12-10 21:17 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Marcel Holtmann, Luiz Augusto von Dentz,
Neal Gompa
Cc: Vaibhav Gupta, asahi, linux-arm-kernel, linux-bluetooth,
linux-kernel
Switch to the generic PCI power management framework and remove legacy
callbacks like .suspend() and .resume(). With the generic framework, the
standard PCI related work like:
- pci_save/restore_state()
- pci_enable/disable_device()
- pci_set_power_state()
is handled by the PCI core and this driver should implement only
hci_bcm4377 specific operations in its respective callback functions.
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
drivers/bluetooth/hci_bcm4377.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c
index 45e6d84224ee..925d0a635945 100644
--- a/drivers/bluetooth/hci_bcm4377.c
+++ b/drivers/bluetooth/hci_bcm4377.c
@@ -2416,8 +2416,9 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id)
hdev);
}
-static int bcm4377_suspend(struct pci_dev *pdev, pm_message_t state)
+static int bcm4377_suspend(struct device *dev)
{
+ struct pci_dev *pdev = to_pci_dev(dev);
struct bcm4377_data *bcm4377 = pci_get_drvdata(pdev);
int ret;
@@ -2431,8 +2432,9 @@ static int bcm4377_suspend(struct pci_dev *pdev, pm_message_t state)
return 0;
}
-static int bcm4377_resume(struct pci_dev *pdev)
+static int bcm4377_resume(struct device *dev)
{
+ struct pci_dev *pdev = to_pci_dev(dev);
struct bcm4377_data *bcm4377 = pci_get_drvdata(pdev);
iowrite32(BCM4377_BAR0_SLEEP_CONTROL_UNQUIESCE,
@@ -2441,6 +2443,8 @@ static int bcm4377_resume(struct pci_dev *pdev)
return hci_resume_dev(bcm4377->hdev);
}
+static DEFINE_SIMPLE_DEV_PM_OPS(bcm4377_ops, bcm4377_suspend, bcm4377_resume);
+
static const struct dmi_system_id bcm4377_dmi_board_table[] = {
{
.matches = {
@@ -2541,8 +2545,7 @@ static struct pci_driver bcm4377_pci_driver = {
.name = "hci_bcm4377",
.id_table = bcm4377_devid_table,
.probe = bcm4377_probe,
- .suspend = bcm4377_suspend,
- .resume = bcm4377_resume,
+ .driver.pm = &bcm4377_ops,
};
module_pci_driver(bcm4377_pci_driver);
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [v1,1/2] Bluetooth: hci_bcm4377: Use generic power management
2025-12-10 21:17 [PATCH v1 1/2] Bluetooth: hci_bcm4377: Use generic power management Vaibhav Gupta
@ 2025-12-10 22:05 ` bluez.test.bot
2025-12-10 23:21 ` [PATCH v2] " Vaibhav Gupta
1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2025-12-10 22:05 UTC (permalink / raw)
To: linux-bluetooth, vaibhavgupta40
[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1032107
---Test result---
Test Summary:
CheckPatch PENDING 0.54 seconds
GitLint PENDING 0.32 seconds
SubjectPrefix PASS 0.07 seconds
BuildKernel PASS 25.62 seconds
CheckAllWarning PASS 27.76 seconds
CheckSparse PASS 31.05 seconds
BuildKernel32 PASS 24.76 seconds
TestRunnerSetup PASS 553.69 seconds
TestRunner_l2cap-tester PASS 24.62 seconds
TestRunner_iso-tester PASS 90.05 seconds
TestRunner_bnep-tester PASS 6.10 seconds
TestRunner_mgmt-tester FAIL 116.33 seconds
TestRunner_rfcomm-tester PASS 9.42 seconds
TestRunner_sco-tester FAIL 14.33 seconds
TestRunner_ioctl-tester PASS 10.11 seconds
TestRunner_mesh-tester FAIL 11.49 seconds
TestRunner_smp-tester PASS 8.46 seconds
TestRunner_userchan-tester PASS 6.55 seconds
IncrementalBuild PENDING 0.85 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.101 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 1.991 seconds
Mesh - Send cancel - 2 Timed out 1.996 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] Bluetooth: hci_bcm4377: Use generic power management
2025-12-10 21:17 [PATCH v1 1/2] Bluetooth: hci_bcm4377: Use generic power management Vaibhav Gupta
2025-12-10 22:05 ` [v1,1/2] " bluez.test.bot
@ 2025-12-10 23:21 ` Vaibhav Gupta
2025-12-11 0:00 ` [v2] " bluez.test.bot
1 sibling, 1 reply; 4+ messages in thread
From: Vaibhav Gupta @ 2025-12-10 23:21 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Marcel Holtmann, Luiz Augusto von Dentz,
Neal Gompa
Cc: Vaibhav Gupta, asahi, linux-arm-kernel, linux-bluetooth,
linux-kernel
Switch to the generic PCI power management framework and remove legacy
callbacks like .suspend() and .resume(). With the generic framework, the
standard PCI related work like:
- pci_save/restore_state()
- pci_enable/disable_device()
- pci_set_power_state()
is handled by the PCI core and this driver should implement only
hci_bcm4377 specific operations in its respective callback functions.
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
v2: v1 has a typo in its subject. This patch is not part of a series. So
there should be no '[.... 1/2]'.
---
drivers/bluetooth/hci_bcm4377.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm4377.c
index 45e6d84224ee..925d0a635945 100644
--- a/drivers/bluetooth/hci_bcm4377.c
+++ b/drivers/bluetooth/hci_bcm4377.c
@@ -2416,8 +2416,9 @@ static int bcm4377_probe(struct pci_dev *pdev, const struct pci_device_id *id)
hdev);
}
-static int bcm4377_suspend(struct pci_dev *pdev, pm_message_t state)
+static int bcm4377_suspend(struct device *dev)
{
+ struct pci_dev *pdev = to_pci_dev(dev);
struct bcm4377_data *bcm4377 = pci_get_drvdata(pdev);
int ret;
@@ -2431,8 +2432,9 @@ static int bcm4377_suspend(struct pci_dev *pdev, pm_message_t state)
return 0;
}
-static int bcm4377_resume(struct pci_dev *pdev)
+static int bcm4377_resume(struct device *dev)
{
+ struct pci_dev *pdev = to_pci_dev(dev);
struct bcm4377_data *bcm4377 = pci_get_drvdata(pdev);
iowrite32(BCM4377_BAR0_SLEEP_CONTROL_UNQUIESCE,
@@ -2441,6 +2443,8 @@ static int bcm4377_resume(struct pci_dev *pdev)
return hci_resume_dev(bcm4377->hdev);
}
+static DEFINE_SIMPLE_DEV_PM_OPS(bcm4377_ops, bcm4377_suspend, bcm4377_resume);
+
static const struct dmi_system_id bcm4377_dmi_board_table[] = {
{
.matches = {
@@ -2541,8 +2545,7 @@ static struct pci_driver bcm4377_pci_driver = {
.name = "hci_bcm4377",
.id_table = bcm4377_devid_table,
.probe = bcm4377_probe,
- .suspend = bcm4377_suspend,
- .resume = bcm4377_resume,
+ .driver.pm = &bcm4377_ops,
};
module_pci_driver(bcm4377_pci_driver);
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [v2] Bluetooth: hci_bcm4377: Use generic power management
2025-12-10 23:21 ` [PATCH v2] " Vaibhav Gupta
@ 2025-12-11 0:00 ` bluez.test.bot
0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2025-12-11 0:00 UTC (permalink / raw)
To: linux-bluetooth, vaibhavgupta40
[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1032114
---Test result---
Test Summary:
CheckPatch PENDING 0.32 seconds
GitLint PENDING 0.25 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 25.19 seconds
CheckAllWarning PASS 28.50 seconds
CheckSparse PASS 31.34 seconds
BuildKernel32 PASS 25.21 seconds
TestRunnerSetup PASS 556.60 seconds
TestRunner_l2cap-tester PASS 24.07 seconds
TestRunner_iso-tester PASS 61.71 seconds
TestRunner_bnep-tester PASS 6.29 seconds
TestRunner_mgmt-tester FAIL 116.56 seconds
TestRunner_rfcomm-tester PASS 9.58 seconds
TestRunner_sco-tester FAIL 14.40 seconds
TestRunner_ioctl-tester PASS 10.14 seconds
TestRunner_mesh-tester FAIL 11.45 seconds
TestRunner_smp-tester PASS 8.69 seconds
TestRunner_userchan-tester PASS 6.76 seconds
IncrementalBuild PENDING 0.55 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.106 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 1.878 seconds
Mesh - Send cancel - 2 Timed out 1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-11 0:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-10 21:17 [PATCH v1 1/2] Bluetooth: hci_bcm4377: Use generic power management Vaibhav Gupta
2025-12-10 22:05 ` [v1,1/2] " bluez.test.bot
2025-12-10 23:21 ` [PATCH v2] " Vaibhav Gupta
2025-12-11 0:00 ` [v2] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).