From: "Frédéric Danis" <frederic.danis@collabora.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ] plugins/admin: Fix storage file location
Date: Fri, 23 Jan 2026 17:42:57 +0100 [thread overview]
Message-ID: <20260123164257.853415-1-frederic.danis@collabora.com> (raw)
The admin policy is set per adapter, as stated in
doc/settings-storage.txt and doc/org.bluez.AdminPolicySet.rst but
currently stored directly under STORAGEDIR.
---
doc/settings-storage.txt | 2 +-
plugins/admin.c | 20 ++++++++++----------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/doc/settings-storage.txt b/doc/settings-storage.txt
index 0a2cc706c..15f55f9ed 100644
--- a/doc/settings-storage.txt
+++ b/doc/settings-storage.txt
@@ -56,7 +56,7 @@ So the directory structure is:
/var/lib/bluetooth/<adapter address>/
./settings
./attributes
- ./admin_policy_settings
+ ./admin_policy_settings
./cache/
./<remote device address>
./<remote device address>
diff --git a/plugins/admin.c b/plugins/admin.c
index 6ab3cba56..76c65d068 100644
--- a/plugins/admin.c
+++ b/plugins/admin.c
@@ -34,7 +34,6 @@
#define ADMIN_POLICY_SET_INTERFACE "org.bluez.AdminPolicySet1"
#define ADMIN_POLICY_STATUS_INTERFACE "org.bluez.AdminPolicyStatus1"
-#define ADMIN_POLICY_STORAGE STORAGEDIR "/admin_policy_settings"
#define DBUS_BLUEZ_SERVICE "org.bluez"
#define BTD_DEVICE_INTERFACE "org.bluez.Device1"
@@ -248,7 +247,7 @@ static void store_policy_settings(struct btd_admin_policy *admin_policy)
{
GKeyFile *key_file = NULL;
GError *gerr = NULL;
- char *filename = ADMIN_POLICY_STORAGE;
+ char filename[PATH_MAX];
char *key_file_data = NULL;
char **uuid_strs = NULL;
gsize length, num_uuids;
@@ -268,16 +267,14 @@ static void store_policy_settings(struct btd_admin_policy *admin_policy)
(const gchar * const *)uuid_strs,
num_uuids);
- if (create_file(ADMIN_POLICY_STORAGE, 0600) < 0) {
- btd_error(admin_policy->adapter_id, "create %s failed, %s",
- filename, strerror(errno));
- goto failed;
- }
+ create_filename(filename, PATH_MAX, "/%s/admin_policy_settings",
+ btd_adapter_get_storage_dir(admin_policy->adapter));
+ create_file(filename, 0600);
key_file_data = g_key_file_to_data(key_file, &length, NULL);
- if (!g_file_set_contents(ADMIN_POLICY_STORAGE, key_file_data, length,
+ if (!g_file_set_contents(filename, key_file_data, length,
&gerr)) {
- error("Unable set contents for %s: (%s)", ADMIN_POLICY_STORAGE,
+ error("Unable set contents for %s: (%s)", filename,
gerr->message);
g_error_free(gerr);
}
@@ -342,9 +339,12 @@ static void load_policy_settings(struct btd_admin_policy *admin_policy)
{
GKeyFile *key_file;
GError *gerr = NULL;
- char *filename = ADMIN_POLICY_STORAGE;
+ char filename[PATH_MAX];
struct stat st;
+ create_filename(filename, PATH_MAX, "/%s/admin_policy_settings",
+ btd_adapter_get_storage_dir(admin_policy->adapter));
+
if (stat(filename, &st) < 0)
store_policy_settings(policy_data);
--
2.43.0
next reply other threads:[~2026-01-23 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 16:42 Frédéric Danis [this message]
2026-01-23 17:40 ` [BlueZ] plugins/admin: Fix storage file location bluez.test.bot
2026-01-26 23:00 ` [PATCH BlueZ] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123164257.853415-1-frederic.danis@collabora.com \
--to=frederic.danis@collabora.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox