From: Johan Hovold <johan@kernel.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 2/2] Bluetooth: btmtk: refactor endpoint lookup
Date: Mon, 30 Mar 2026 11:41:34 +0200 [thread overview]
Message-ID: <20260330094134.1622788-3-johan@kernel.org> (raw)
In-Reply-To: <20260330094134.1622788-1-johan@kernel.org>
Use the common USB helper for looking up bulk and interrupt endpoints
instead of open coding.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/bluetooth/btmtk.c | 29 +++++------------------------
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
index fa7533578f85..ccea160da7ac 100644
--- a/drivers/bluetooth/btmtk.c
+++ b/drivers/bluetooth/btmtk.c
@@ -983,7 +983,7 @@ static int __set_mtk_intr_interface(struct hci_dev *hdev)
{
struct btmtk_data *btmtk_data = hci_get_priv(hdev);
struct usb_interface *intf = btmtk_data->isopkt_intf;
- int i, err;
+ int err;
if (!btmtk_data->isopkt_intf)
return -ENODEV;
@@ -994,29 +994,10 @@ static int __set_mtk_intr_interface(struct hci_dev *hdev)
return err;
}
- btmtk_data->isopkt_tx_ep = NULL;
- btmtk_data->isopkt_rx_ep = NULL;
-
- for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i++) {
- struct usb_endpoint_descriptor *ep_desc;
-
- ep_desc = &intf->cur_altsetting->endpoint[i].desc;
-
- if (!btmtk_data->isopkt_tx_ep &&
- usb_endpoint_is_int_out(ep_desc)) {
- btmtk_data->isopkt_tx_ep = ep_desc;
- continue;
- }
-
- if (!btmtk_data->isopkt_rx_ep &&
- usb_endpoint_is_int_in(ep_desc)) {
- btmtk_data->isopkt_rx_ep = ep_desc;
- continue;
- }
- }
-
- if (!btmtk_data->isopkt_tx_ep ||
- !btmtk_data->isopkt_rx_ep) {
+ err = usb_find_common_endpoints(intf->cur_altsetting, NULL, NULL,
+ &btmtk_data->isopkt_rx_ep,
+ &btmtk_data->isopkt_tx_ep);
+ if (err) {
bt_dev_err(hdev, "invalid interrupt descriptors");
return -ENODEV;
}
--
2.52.0
prev parent reply other threads:[~2026-03-30 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 9:41 [PATCH 0/2] Bluetooth: refactor endpoint lookup Johan Hovold
2026-03-30 9:41 ` [PATCH 1/2] Bluetooth: btusb: " Johan Hovold
2026-03-30 10:16 ` Bluetooth: " bluez.test.bot
2026-03-30 9:41 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330094134.1622788-3-johan@kernel.org \
--to=johan@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox