* [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset.
@ 2026-03-30 6:38 Chandrashekar Devegowda
2026-03-30 8:30 ` [v1] " bluez.test.bot
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chandrashekar Devegowda @ 2026-03-30 6:38 UTC (permalink / raw)
To: linux-bluetooth
Cc: linux-pci, bhelgaas, ravishankar.srivatsa, chethan.tumkur.narayan,
Chandrashekar Devegowda
When driver encounters a TOP exception, ACPI methods will be called
for Product level reset since Wifi and BT share the same TOP, BT driver
will first reprobe the wifi driver and then reprobe BT.
Tested by:
1) Simulating TOP exception: sudo hcitool cmd 3f 4d 0A 00
And verified that the device went through PLDR by checking the ACPI
debug logs.
2) Toggle of sysfs attribute for BT reset for FLR i.e
echo 1 > /sys/class/bluetooth/hci0/reset
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
---
drivers/bluetooth/btintel.c | 6 +-
drivers/bluetooth/btintel.h | 7 ++
drivers/bluetooth/btintel_pcie.c | 163 +++++++++++++++++++++++++++++--
drivers/bluetooth/btintel_pcie.h | 6 ++
4 files changed, 171 insertions(+), 11 deletions(-)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index dcaaa4ca02b9..4426327ebc61 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -67,9 +67,10 @@ static struct {
u32 fw_build_num;
} coredump_info;
-static const guid_t btintel_guid_dsm =
+const guid_t btintel_guid_dsm =
GUID_INIT(0xaa10f4e0, 0x81ac, 0x4233,
0xab, 0xf6, 0x3b, 0x2a, 0xc5, 0x0e, 0x28, 0xd9);
+EXPORT_SYMBOL_GPL(btintel_guid_dsm);
int btintel_check_bdaddr(struct hci_dev *hdev)
{
@@ -2624,7 +2625,7 @@ static void btintel_set_ppag(struct hci_dev *hdev, struct intel_version_tlv *ver
kfree_skb(skb);
}
-static int btintel_acpi_reset_method(struct hci_dev *hdev)
+int btintel_acpi_reset_method(struct hci_dev *hdev)
{
int ret = 0;
acpi_status status;
@@ -2663,6 +2664,7 @@ static int btintel_acpi_reset_method(struct hci_dev *hdev)
kfree(buffer.pointer);
return ret;
}
+EXPORT_SYMBOL_GPL(btintel_acpi_reset_method);
static void btintel_set_dsm_reset_method(struct hci_dev *hdev,
struct intel_version_tlv *ver_tlv)
diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index 0e9ca99aaaae..70d812ad36a2 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -79,6 +79,8 @@ struct intel_tlv {
#define BTINTEL_HWID_SCP2 0x20 /* Scorpius Peak2 - Nova Lake */
#define BTINTEL_HWID_BZRIW 0x22 /* BlazarIW - Wildcat Lake */
+extern const guid_t btintel_guid_dsm;
+
struct intel_version_tlv {
u32 cnvi_top;
u32 cnvr_top;
@@ -289,6 +291,7 @@ int btintel_bootloader_setup_tlv(struct hci_dev *hdev,
int btintel_shutdown_combined(struct hci_dev *hdev);
void btintel_hw_error(struct hci_dev *hdev, u8 code);
void btintel_print_fseq_info(struct hci_dev *hdev);
+int btintel_acpi_reset_method(struct hci_dev *hdev);
#else
static inline int btintel_check_bdaddr(struct hci_dev *hdev)
@@ -422,4 +425,8 @@ static inline void btintel_hw_error(struct hci_dev *hdev, u8 code)
static inline void btintel_print_fseq_info(struct hci_dev *hdev)
{
}
+static inline int btintel_acpi_reset_method(struct hci_dev *hdev)
+{
+ return -ENODEV;
+}
#endif
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 05f82bc3f0d7..abac1ae5df8f 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -15,6 +15,7 @@
#include <linux/wait.h>
#include <linux/delay.h>
#include <linux/interrupt.h>
+#include <linux/acpi.h>
#include <linux/unaligned.h>
#include <linux/devcoredump.h>
@@ -100,6 +101,22 @@ enum {
BTINTEL_PCIE_D3
};
+enum {
+ BTINTEL_PCIE_DSM_SET_RESET_TIMING = 1,
+ BTINTEL_PCIE_DSM_GET_RESET_TIMING = 2,
+ BTINTEL_PCIE_DSM_BT_PLDR_CONFIG = 3,
+ BTINTEL_PCIE_DSM_GET_RESET_TYPE = 4,
+ BTINTEL_PCIE_DSM_DYNAMIC_PLDR = 5,
+ BTINTEL_PCIE_DSM_GET_RESET_METHOD = 6,
+ BTINTEL_PCIE_DSM_SET_PLDR_DELAY = 7,
+};
+
+enum btintel_dsm_internal_product_reset_mode {
+ BTINTEL_PCIE_DSM_PLDR_MODE_EN_PROD_RESET = BIT(0),
+ BTINTEL_PCIE_DSM_PLDR_MODE_EN_WIFI_FLR = BIT(1),
+ BTINTEL_PCIE_DSM_PLDR_MODE_EN_BT_OFF_ON = BIT(2),
+};
+
/* Structure for dbgc fragment buffer
* @buf_addr_lsb: LSB of the buffer's physical address
* @buf_addr_msb: MSB of the buffer's physical address
@@ -126,6 +143,11 @@ struct btintel_pcie_dbgc_ctxt {
struct btintel_pcie_dbgc_ctxt_buf bufs[BTINTEL_PCIE_DBGC_BUFFER_COUNT];
};
+/* structure for reset and recovery
+ * @pdev: The pci_dev for controller
+ * @work: work struct for reset
+ * @reset type: Reset can be FLR or PLDR
+ */
struct btintel_pcie_removal {
struct pci_dev *pdev;
struct work_struct work;
@@ -2254,6 +2276,112 @@ static void btintel_pcie_inc_recovery_count(struct pci_dev *pdev,
}
static int btintel_pcie_setup_hdev(struct btintel_pcie_data *data);
+static void btintel_pcie_reset(struct hci_dev *hdev);
+
+static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
+{
+ union acpi_object *obj, argv4;
+ acpi_handle handle;
+ int ret;
+ struct pldr_mode {
+ u16 cmd_type;
+ u16 cmd_payload;
+ } __packed;
+
+ /* set 1 for _PRR mode
+ * Product Reset (PLDR Abort flow)
+ */
+ static const struct pldr_mode mode = {
+ .cmd_type = 1,
+ .cmd_payload = BTINTEL_PCIE_DSM_PLDR_MODE_EN_PROD_RESET |
+ BTINTEL_PCIE_DSM_PLDR_MODE_EN_WIFI_FLR,
+ };
+ struct hci_dev *hdev = data->hdev;
+
+ handle = ACPI_HANDLE(GET_HCIDEV_DEV(data->hdev));
+ if (!handle) {
+ bt_dev_dbg(data->hdev, "No support for bluetooth device in ACPI firmware");
+ return -EACCES;
+ }
+
+ if (!acpi_has_method(handle, "_PRR")) {
+ bt_dev_dbg(data->hdev, "No support for _PRR ACPI method, falling back to FLR");
+ btintel_pcie_reset(data->hdev);
+ return -ENODEV;
+ }
+
+ argv4.buffer.type = ACPI_TYPE_BUFFER;
+ argv4.buffer.length = sizeof(mode);
+ argv4.buffer.pointer = (void *)&mode;
+
+ obj = acpi_evaluate_dsm(handle, &btintel_guid_dsm, 0,
+ BTINTEL_PCIE_DSM_DYNAMIC_PLDR, &argv4);
+ if (!obj) {
+ bt_dev_err(data->hdev, "Failed to call dsm to set reset method");
+ return -EIO;
+ }
+ ACPI_FREE(obj);
+
+ pci_dev_lock(data->pdev);
+ pci_save_state(data->pdev);
+ ret = btintel_acpi_reset_method(hdev);
+ if (ret)
+ bt_dev_err(data->hdev, "ACPI _PRR reset failed (%d),PLDR incomplete",
+ ret);
+ pci_restore_state(data->pdev);
+ pci_dev_unlock(data->pdev);
+ return ret;
+}
+
+static void btintel_pcie_perform_pldr(struct btintel_pcie_removal *removal)
+{
+ struct pci_dev *pdev = removal->pdev;
+ struct pci_dev *wifi = NULL;
+ struct pci_bus *bus;
+ struct btintel_pcie_data *data;
+ /* on integrated we have to look up by ID (same bus) */
+ static const struct pci_device_id wifi_device_ids[] = {
+ #define WIFI_DEV(_id) { PCI_DEVICE(PCI_VENDOR_ID_INTEL, _id) }
+ WIFI_DEV(0xA840), /* LNL */
+ WIFI_DEV(0xE440), /* PTL-P */
+ WIFI_DEV(0xE340), /* PTL-H */
+ WIFI_DEV(0xD340), /* NVL-H */
+ WIFI_DEV(0x6E70), /* NVL-S */
+ WIFI_DEV(0x4D40), /* WCL */
+ WIFI_DEV(0xD240), /* RZL-H */
+ WIFI_DEV(0x6C40), /* RZL-M */
+ {}
+ };
+ struct pci_dev *tmp = NULL;
+
+ data = pci_get_drvdata(pdev);
+
+ bus = pdev->bus;
+ if (!bus)
+ return;
+
+ /* If ACPI reset fell back to FLR or failed, skip reprobe to avoid
+ * racing with the FLR work already scheduled.
+ */
+ if (btintel_pcie_acpi_reset_method(data))
+ return;
+
+ list_for_each_entry(tmp, &bus->devices, bus_list) {
+ if (pci_match_id(wifi_device_ids, tmp)) {
+ wifi = pci_dev_get(tmp);
+ break;
+ }
+ }
+
+ if (wifi) {
+ if (device_reprobe(&wifi->dev))
+ BT_ERR("WiFi reprobe failed for BDF:%s", pci_name(wifi));
+ pci_dev_put(wifi);
+ }
+
+ if (device_reprobe(&pdev->dev))
+ BT_ERR("BT reprobe failed for BDF:%s", pci_name(pdev));
+}
static void btintel_pcie_removal_work(struct work_struct *wk)
{
@@ -2266,9 +2394,13 @@ static void btintel_pcie_removal_work(struct work_struct *wk)
pci_lock_rescan_remove();
if (!pdev->bus)
- goto error;
+ goto out;
data = pci_get_drvdata(pdev);
+ if (!data) {
+ BT_WARN("PCI driver data is NULL, aborting removal work");
+ goto out;
+ }
btintel_pcie_disable_interrupts(data);
btintel_pcie_synchronize_irqs(data);
@@ -2276,12 +2408,16 @@ static void btintel_pcie_removal_work(struct work_struct *wk)
flush_work(&data->rx_work);
bt_dev_dbg(data->hdev, "Release bluetooth interface");
+ if (data->reset_type == BTINTEL_PCIE_IOSF_PRR_PLDR) {
+ btintel_pcie_perform_pldr(removal);
+ goto out;
+ }
btintel_pcie_release_hdev(data);
err = pci_reset_function(pdev);
if (err) {
BT_ERR("Failed resetting the pcie device (%d)", err);
- goto error;
+ goto out;
}
btintel_pcie_enable_interrupts(data);
@@ -2291,7 +2427,7 @@ static void btintel_pcie_removal_work(struct work_struct *wk)
if (err) {
BT_ERR("Failed to enable bluetooth hardware after reset (%d)",
err);
- goto error;
+ goto out;
}
btintel_pcie_reset_ia(data);
@@ -2301,9 +2437,9 @@ static void btintel_pcie_removal_work(struct work_struct *wk)
err = btintel_pcie_setup_hdev(data);
if (err) {
BT_ERR("Failed registering hdev (%d)", err);
- goto error;
+ goto out;
}
-error:
+out:
pci_dev_put(pdev);
pci_unlock_rescan_remove();
kfree(removal);
@@ -2339,15 +2475,19 @@ static void btintel_pcie_hw_error(struct hci_dev *hdev, u8 code)
struct pci_dev *pdev = dev_data->pdev;
time64_t retry_window;
- if (code == 0x13) {
- bt_dev_err(hdev, "Encountered top exception");
- return;
- }
+ btintel_pcie_dump_debug_registers(hdev);
data = btintel_pcie_get_recovery(pdev, &hdev->dev);
if (!data)
return;
+ if (code == 0x13)
+ dev_data->reset_type = BTINTEL_PCIE_IOSF_PRR_PLDR;
+ else
+ dev_data->reset_type = BTINTEL_PCIE_IOSF_PRR_FLR;
+
+ bt_dev_err(hdev, "Encountered exception err:0x%x triggering: %s", code,
+ dev_data->reset_type == BTINTEL_PCIE_IOSF_PRR_PLDR ? "PLDR" : "FLR");
retry_window = ktime_get_boottime_seconds() - data->last_error;
if (retry_window < BTINTEL_PCIE_RESET_WINDOW_SECS &&
@@ -2503,6 +2643,10 @@ static int btintel_pcie_probe(struct pci_dev *pdev,
data->boot_stage_cache = 0x00;
data->img_resp_cache = 0x00;
+ /* FLR can be invoked by echoing to debugfs path, so explicitly
+ * initialized
+ */
+ data->reset_type = BTINTEL_PCIE_IOSF_PRR_FLR;
err = btintel_pcie_config_pcie(pdev, data);
if (err)
@@ -2701,6 +2845,7 @@ static int btintel_pcie_resume(struct device *dev)
if (data->pm_sx_event == PM_EVENT_FREEZE ||
data->pm_sx_event == PM_EVENT_HIBERNATE) {
set_bit(BTINTEL_PCIE_CORE_HALTED, &data->flags);
+ data->reset_type = BTINTEL_PCIE_IOSF_PRR_FLR;
btintel_pcie_reset(data->hdev);
return 0;
}
diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h
index e3d941ffef4a..856673fb2bd7 100644
--- a/drivers/bluetooth/btintel_pcie.h
+++ b/drivers/bluetooth/btintel_pcie.h
@@ -144,6 +144,11 @@ enum msix_mbox_int_causes {
BTINTEL_PCIE_CSR_MBOX_STATUS_MBOX4 = BIT(3), /* cause MBOX4 */
};
+enum btintel_pcie_reset_type {
+ BTINTEL_PCIE_IOSF_PRR_FLR = 0,
+ BTINTEL_PCIE_IOSF_PRR_PLDR = 1,
+};
+
#define BTINTEL_PCIE_MSIX_NON_AUTO_CLEAR_CAUSE BIT(7)
/* Minimum and Maximum number of MSI-X Vector
@@ -514,6 +519,7 @@ struct btintel_pcie_data {
struct txq txq;
struct rxq rxq;
u32 alive_intr_ctxt;
+ enum btintel_pcie_reset_type reset_type;
struct btintel_pcie_dbgc dbgc;
struct btintel_pcie_dump_header dmp_hdr;
u8 pm_sx_event;
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [v1] Bluetooth: btintel_pcie:Support Product level reset.
2026-03-30 6:38 [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset Chandrashekar Devegowda
@ 2026-03-30 8:30 ` bluez.test.bot
2026-03-30 21:01 ` [PATCH v1] " kernel test robot
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2026-03-30 8:30 UTC (permalink / raw)
To: linux-bluetooth, chandrashekar.devegowda
[-- Attachment #1: Type: text/plain, Size: 2993 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1074376
---Test result---
Test Summary:
CheckPatch PENDING 0.31 seconds
GitLint PENDING 0.29 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 25.97 seconds
CheckAllWarning PASS 29.12 seconds
CheckSparse PASS 27.49 seconds
BuildKernel32 PASS 24.99 seconds
TestRunnerSetup PASS 565.01 seconds
TestRunner_l2cap-tester PASS 28.33 seconds
TestRunner_iso-tester PASS 40.82 seconds
TestRunner_bnep-tester PASS 6.28 seconds
TestRunner_mgmt-tester FAIL 111.50 seconds
TestRunner_rfcomm-tester PASS 9.43 seconds
TestRunner_sco-tester FAIL 14.10 seconds
TestRunner_ioctl-tester PASS 10.12 seconds
TestRunner_mesh-tester FAIL 11.44 seconds
TestRunner_smp-tester PASS 8.45 seconds
TestRunner_userchan-tester PASS 6.61 seconds
IncrementalBuild PENDING 0.47 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 484 (98.0%), Failed: 6, Not Run: 4
Failed Test Cases
Adv. connectable & connected (central) - Success Failed 0.128 seconds
Adv. non-connectable & connected (central) - Success Failed 0.120 seconds
Ext Adv. connectable & connected (central) Failed 0.168 seconds
Ext Adv. non-connectable & connected (central) Failed 0.168 seconds
Read Exp Feature - Success Failed 0.100 seconds
LL Privacy - Set Device Flag 1 (Device Privacy) Failed 0.152 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 1.901 seconds
Mesh - Send cancel - 2 Timed out 1.996 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset.
2026-03-30 6:38 [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset Chandrashekar Devegowda
2026-03-30 8:30 ` [v1] " bluez.test.bot
@ 2026-03-30 21:01 ` kernel test robot
2026-03-30 23:39 ` kernel test robot
2026-04-09 20:19 ` [v1] " bluez.test.bot
3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-03-30 21:01 UTC (permalink / raw)
To: Chandrashekar Devegowda, linux-bluetooth
Cc: llvm, oe-kbuild-all, linux-pci, bhelgaas, ravishankar.srivatsa,
chethan.tumkur.narayan, Chandrashekar Devegowda
Hi Chandrashekar,
kernel test robot noticed the following build errors:
[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20260327]
[cannot apply to bluetooth/master linus/master v7.0-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chandrashekar-Devegowda/Bluetooth-btintel_pcie-Support-Product-level-reset/20260330-190125
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
patch link: https://lore.kernel.org/r/20260330063842.1121545-1-chandrashekar.devegowda%40intel.com
patch subject: [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset.
config: um-allmodconfig (https://download.01.org/0day-ci/archive/20260331/202603310419.PsZ2njdQ-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260331/202603310419.PsZ2njdQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603310419.PsZ2njdQ-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/bluetooth/btintel_pcie.c:13:
In file included from include/linux/pci.h:38:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:24:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:12:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:1209:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
1209 | return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
| ~~~~~~~~~~ ^
>> drivers/bluetooth/btintel_pcie.c:2307:7: error: call to undeclared function 'acpi_has_method'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2307 | if (!acpi_has_method(handle, "_PRR")) {
| ^
drivers/bluetooth/btintel_pcie.c:2307:7: note: did you mean 'acpi_has_watchdog'?
include/linux/acpi.h:1494:20: note: 'acpi_has_watchdog' declared here
1494 | static inline bool acpi_has_watchdog(void) { return false; }
| ^
1 warning and 1 error generated.
vim +/acpi_has_method +2307 drivers/bluetooth/btintel_pcie.c
2280
2281 static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
2282 {
2283 union acpi_object *obj, argv4;
2284 acpi_handle handle;
2285 int ret;
2286 struct pldr_mode {
2287 u16 cmd_type;
2288 u16 cmd_payload;
2289 } __packed;
2290
2291 /* set 1 for _PRR mode
2292 * Product Reset (PLDR Abort flow)
2293 */
2294 static const struct pldr_mode mode = {
2295 .cmd_type = 1,
2296 .cmd_payload = BTINTEL_PCIE_DSM_PLDR_MODE_EN_PROD_RESET |
2297 BTINTEL_PCIE_DSM_PLDR_MODE_EN_WIFI_FLR,
2298 };
2299 struct hci_dev *hdev = data->hdev;
2300
2301 handle = ACPI_HANDLE(GET_HCIDEV_DEV(data->hdev));
2302 if (!handle) {
2303 bt_dev_dbg(data->hdev, "No support for bluetooth device in ACPI firmware");
2304 return -EACCES;
2305 }
2306
> 2307 if (!acpi_has_method(handle, "_PRR")) {
2308 bt_dev_dbg(data->hdev, "No support for _PRR ACPI method, falling back to FLR");
2309 btintel_pcie_reset(data->hdev);
2310 return -ENODEV;
2311 }
2312
2313 argv4.buffer.type = ACPI_TYPE_BUFFER;
2314 argv4.buffer.length = sizeof(mode);
2315 argv4.buffer.pointer = (void *)&mode;
2316
2317 obj = acpi_evaluate_dsm(handle, &btintel_guid_dsm, 0,
2318 BTINTEL_PCIE_DSM_DYNAMIC_PLDR, &argv4);
2319 if (!obj) {
2320 bt_dev_err(data->hdev, "Failed to call dsm to set reset method");
2321 return -EIO;
2322 }
2323 ACPI_FREE(obj);
2324
2325 pci_dev_lock(data->pdev);
2326 pci_save_state(data->pdev);
2327 ret = btintel_acpi_reset_method(hdev);
2328 if (ret)
2329 bt_dev_err(data->hdev, "ACPI _PRR reset failed (%d),PLDR incomplete",
2330 ret);
2331 pci_restore_state(data->pdev);
2332 pci_dev_unlock(data->pdev);
2333 return ret;
2334 }
2335
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset.
2026-03-30 6:38 [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset Chandrashekar Devegowda
2026-03-30 8:30 ` [v1] " bluez.test.bot
2026-03-30 21:01 ` [PATCH v1] " kernel test robot
@ 2026-03-30 23:39 ` kernel test robot
2026-04-09 20:19 ` [v1] " bluez.test.bot
3 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2026-03-30 23:39 UTC (permalink / raw)
To: Chandrashekar Devegowda, linux-bluetooth
Cc: oe-kbuild-all, linux-pci, bhelgaas, ravishankar.srivatsa,
chethan.tumkur.narayan, Chandrashekar Devegowda
Hi Chandrashekar,
kernel test robot noticed the following build errors:
[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on next-20260327]
[cannot apply to bluetooth/master linus/master v7.0-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chandrashekar-Devegowda/Bluetooth-btintel_pcie-Support-Product-level-reset/20260330-190125
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
patch link: https://lore.kernel.org/r/20260330063842.1121545-1-chandrashekar.devegowda%40intel.com
patch subject: [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset.
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20260331/202603310744.5WIVh3e6-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260331/202603310744.5WIVh3e6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603310744.5WIVh3e6-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/bluetooth/btintel_pcie.c: In function 'btintel_pcie_acpi_reset_method':
>> drivers/bluetooth/btintel_pcie.c:2307:14: error: implicit declaration of function 'acpi_has_method'; did you mean 'acpi_has_watchdog'? [-Wimplicit-function-declaration]
2307 | if (!acpi_has_method(handle, "_PRR")) {
| ^~~~~~~~~~~~~~~
| acpi_has_watchdog
vim +2307 drivers/bluetooth/btintel_pcie.c
2280
2281 static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
2282 {
2283 union acpi_object *obj, argv4;
2284 acpi_handle handle;
2285 int ret;
2286 struct pldr_mode {
2287 u16 cmd_type;
2288 u16 cmd_payload;
2289 } __packed;
2290
2291 /* set 1 for _PRR mode
2292 * Product Reset (PLDR Abort flow)
2293 */
2294 static const struct pldr_mode mode = {
2295 .cmd_type = 1,
2296 .cmd_payload = BTINTEL_PCIE_DSM_PLDR_MODE_EN_PROD_RESET |
2297 BTINTEL_PCIE_DSM_PLDR_MODE_EN_WIFI_FLR,
2298 };
2299 struct hci_dev *hdev = data->hdev;
2300
2301 handle = ACPI_HANDLE(GET_HCIDEV_DEV(data->hdev));
2302 if (!handle) {
2303 bt_dev_dbg(data->hdev, "No support for bluetooth device in ACPI firmware");
2304 return -EACCES;
2305 }
2306
> 2307 if (!acpi_has_method(handle, "_PRR")) {
2308 bt_dev_dbg(data->hdev, "No support for _PRR ACPI method, falling back to FLR");
2309 btintel_pcie_reset(data->hdev);
2310 return -ENODEV;
2311 }
2312
2313 argv4.buffer.type = ACPI_TYPE_BUFFER;
2314 argv4.buffer.length = sizeof(mode);
2315 argv4.buffer.pointer = (void *)&mode;
2316
2317 obj = acpi_evaluate_dsm(handle, &btintel_guid_dsm, 0,
2318 BTINTEL_PCIE_DSM_DYNAMIC_PLDR, &argv4);
2319 if (!obj) {
2320 bt_dev_err(data->hdev, "Failed to call dsm to set reset method");
2321 return -EIO;
2322 }
2323 ACPI_FREE(obj);
2324
2325 pci_dev_lock(data->pdev);
2326 pci_save_state(data->pdev);
2327 ret = btintel_acpi_reset_method(hdev);
2328 if (ret)
2329 bt_dev_err(data->hdev, "ACPI _PRR reset failed (%d),PLDR incomplete",
2330 ret);
2331 pci_restore_state(data->pdev);
2332 pci_dev_unlock(data->pdev);
2333 return ret;
2334 }
2335
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [v1] Bluetooth: btintel_pcie:Support Product level reset.
2026-03-30 6:38 [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset Chandrashekar Devegowda
` (2 preceding siblings ...)
2026-03-30 23:39 ` kernel test robot
@ 2026-04-09 20:19 ` bluez.test.bot
3 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2026-04-09 20:19 UTC (permalink / raw)
To: linux-bluetooth, chandrashekar.devegowda
[-- Attachment #1: Type: text/plain, Size: 5634 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1074376
---Test result---
Test Summary:
CheckPatch PENDING 0.43 seconds
GitLint PENDING 0.23 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 24.96 seconds
CheckAllWarning PASS 27.21 seconds
CheckSparse PASS 26.00 seconds
BuildKernel32 PASS 24.34 seconds
TestRunnerSetup PASS 527.21 seconds
TestRunner_l2cap-tester FAIL 28.29 seconds
TestRunner_iso-tester PASS 38.27 seconds
TestRunner_bnep-tester PASS 6.54 seconds
TestRunner_mgmt-tester FAIL 114.21 seconds
TestRunner_rfcomm-tester PASS 9.58 seconds
TestRunner_sco-tester FAIL 14.54 seconds
TestRunner_ioctl-tester PASS 10.43 seconds
TestRunner_mesh-tester FAIL 12.62 seconds
TestRunner_smp-tester PASS 8.87 seconds
TestRunner_userchan-tester PASS 6.81 seconds
TestRunner_6lowpan-tester PASS 8.99 seconds
IncrementalBuild PENDING 0.23 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_l2cap-tester - FAIL
Desc: Run l2cap-tester with test-runner
Output:
Total: 96, Passed: 95 (99.0%), Failed: 1, Not Run: 0
Failed Test Cases
L2CAP BR/EDR Server - Set PHY 3M Failed 0.116 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.104 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
7.0.0-rc2-gdb8a83754e8b #1 Not tainted
------------------------------------------------------
kworker/u5:2/117 is trying to acquire lock:
ffff888001abe240 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: sco_connect_cfm+0x358/0x8d0
but task is already holding lock:
ffff888002090c20 (&conn->lock){+.+.}-{3:3}, at: sco_connect_cfm+0x22d/0x8d0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&conn->lock){+.+.}-{3:3}:
lock_acquire+0xf7/0x2c0
_raw_spin_lock+0x2a/0x40
sco_sock_connect+0x4d7/0x1280
__sys_connect+0x1a3/0x260
__x64_sys_connect+0x6e/0xb0
do_syscall_64+0xa0/0x570
entry_SYSCALL_64_after_hwframe+0x74/0x7c
-> #0 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
check_prev_add+0xe9/0xc70
__lock_acquire+0x1457/0x1df0
lock_acquire+0xf7/0x2c0
lock_sock_nested+0x36/0xd0
sco_connect_cfm+0x358/0x8d0
hci_sync_conn_complete_evt+0x3d3/0x8e0
hci_event_packet+0x74f/0xb10
hci_rx_work+0x398/0xd00
process_scheduled_works+0xb16/0x1ac0
worker_thread+0x4ff/0xba0
kthread+0x368/0x490
ret_from_fork+0x498/0x7e0
ret_from_fork_asm+0x19/0x30
other info that might help us debug this:
...
BUG: sleeping function called from invalid context at net/core/sock.c:3782
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 117, name: kworker/u5:2
preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
CPU: 0 UID: 0 PID: 117 Comm: kworker/u5:2 Not tainted 7.0.0-rc2-gdb8a83754e8b #1 PREEMPT(lazy)
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-1ubuntu1.1 04/01/2014
Workqueue: hci0 hci_rx_work
Call Trace:
<TASK>
dump_stack_lvl+0x49/0x60
__might_resched+0x2ea/0x500
lock_sock_nested+0x47/0xd0
? sco_connect_cfm+0x358/0x8d0
sco_connect_cfm+0x358/0x8d0
? hci_debugfs_create_conn+0x190/0x210
? __pfx_sco_connect_cfm+0x10/0x10
hci_sync_conn_complete_evt+0x3d3/0x8e0
hci_event_packet+0x74f/0xb10
? __pfx_hci_sync_conn_complete_evt+0x10/0x10
? __pfx_hci_event_packet+0x10/0x10
? mark_held_locks+0x49/0x80
? lockdep_hardirqs_on_prepare+0xd4/0x180
? _raw_spin_unlock_irqrestore+0x2c/0x50
hci_rx_work+0x398/0xd00
process_scheduled_works+0xb16/0x1ac0
? __pfx_process_scheduled_works+0x10/0x10
? lock_acquire+0xf7/0x2c0
? lock_is_held_type+0x9b/0x110
? __pfx_hci_rx_work+0x10/0x10
worker_thread+0x4ff/0xba0
? _raw_spin_unlock_irqrestore+0x2c/0x50
? __pfx_worker_thread+0x10/0x10
kthread+0x368/0x490
? _raw_spin_unlock_irq+0x23/0x40
? __pfx_kthread+0x10/0x10
ret_from_fork+0x498/0x7e0
? __pfx_ret_from_fork+0x10/0x10
? __switch_to+0x9e4/0xe50
? __switch_to_asm+0x32/0x60
...
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.705 seconds
Mesh - Send cancel - 2 Timed out 1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
https://github.com/bluez/bluetooth-next/pull/37/checks
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-09 20:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-30 6:38 [PATCH v1] Bluetooth: btintel_pcie:Support Product level reset Chandrashekar Devegowda
2026-03-30 8:30 ` [v1] " bluez.test.bot
2026-03-30 21:01 ` [PATCH v1] " kernel test robot
2026-03-30 23:39 ` kernel test robot
2026-04-09 20:19 ` [v1] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox