public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
To: marcel@holtmann.org, luiz.dentz@gmail.com,
	chandrashekar.devegowda@intel.com,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: venkat88@linux.ibm.com, rafael@kernel.org,
	christophe.leroy@csgroup.eu, maddy@linux.ibm.com,
	riteshh@linux.ibm.com, broonie@kernel.org
Subject: [PATCH] Bluetooth: btintel_pcie: Add ACPI dependency
Date: Thu, 16 Apr 2026 20:58:03 +0530	[thread overview]
Message-ID: <20260416152803.54396-1-venkat88@linux.ibm.com> (raw)

The btintel_pcie driver uses ACPI functions (acpi_has_method,
ACPI_HANDLE, acpi_evaluate_dsm) in btintel_pcie_acpi_reset_method()
but can be built without CONFIG_ACPI, leading to build failures
discovered by IBM CI:

drivers/bluetooth/btintel_pcie.c:2309:14: error: implicit declaration
of function 'acpi_has_method' [-Werror=implicit-function-declaration]
 2309 |         if (!acpi_has_method(handle, "_PRR")) {
      |              ^~~~~~~~~~~~~~~

Add ACPI dependency to the Kconfig entry to prevent building this
driver when ACPI is disabled, since the driver requires ACPI
functionality for its reset method.

Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Closes: https://lore.kernel.org/all/ad624e0d-cfd7-4521-ae33-c5c3287b4204@linux.ibm.com/
Fixes: 912a499a7955 ("Bluetooth: btintel_pcie: Support Product level reset")
Suggested-by: Rafael J. Wysocki <rafael@kernel.org>
Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
---
Hi Marcel and Luiz,

I'm submitting a fix for a build failure in the btintel_pcie driver when
CONFIG_ACPI is not set. Christophe Leroy helped identify that commit
912a499a7955 introduced this issue.

 drivers/bluetooth/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index c5d45cf91f88..fc1b37044a9b 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -502,7 +502,7 @@ config BT_NXPUART
 
 config BT_INTEL_PCIE
 	tristate "Intel HCI PCIe driver"
-	depends on PCI
+	depends on PCI && ACPI
 	select BT_INTEL
 	select FW_LOADER
 	help
-- 
2.45.2


             reply	other threads:[~2026-04-16 15:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 15:28 Venkat Rao Bagalkote [this message]
2026-04-16 15:38 ` [PATCH] Bluetooth: btintel_pcie: Add ACPI dependency Luiz Augusto von Dentz
2026-04-16 16:39 ` bluez.test.bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416152803.54396-1-venkat88@linux.ibm.com \
    --to=venkat88@linux.ibm.com \
    --cc=broonie@kernel.org \
    --cc=chandrashekar.devegowda@intel.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=maddy@linux.ibm.com \
    --cc=marcel@holtmann.org \
    --cc=rafael@kernel.org \
    --cc=riteshh@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox