From: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com,
Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH v2] Bluetooth: btintel_pcie: Fix build error when CONFIG_ACPI is disabled
Date: Thu, 16 Apr 2026 21:05:23 +0530 [thread overview]
Message-ID: <20260416153524.1405955-1-chandrashekar.devegowda@intel.com> (raw)
btintel_pcie_acpi_reset_method() uses ACPI APIs such as
acpi_evaluate_object() and acpi_has_method() which are not available
when CONFIG_ACPI is disabled, causing build errors on architectures
that lack ACPI support.
Guard btintel_pcie_acpi_reset_method() and btintel_pcie_perform_pldr()
with IS_ENABLED(CONFIG_ACPI). Since PLDR relies entirely on ACPI reset
methods, skip the entire PLDR flow when ACPI is not enabled instead of
unnecessarily unbinding and reprobing WiFi with no actual reset.
Fixes: 912a499a7955 ("Bluetooth: btintel_pcie: Support Product level reset")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
---
v1 -> v2:
- Guard btintel_pcie_perform_pldr() along with
btintel_pcie_acpi_reset_method() under IS_ENABLED(CONFIG_ACPI)
instead of providing a separate stub for the ACPI method, since
PLDR is meaningless without ACPI support (Paul).
- Tested with CONFIG_ACPI=y, CONFIG_ACPI disabled, and 0day CI
alpha config.
drivers/bluetooth/btintel_pcie.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
index 076beb45c410..07223965388a 100644
--- a/drivers/bluetooth/btintel_pcie.c
+++ b/drivers/bluetooth/btintel_pcie.c
@@ -2280,6 +2280,7 @@ static void btintel_pcie_inc_recovery_count(struct pci_dev *pdev,
static int btintel_pcie_setup_hdev(struct btintel_pcie_data *data);
static void btintel_pcie_reset(struct hci_dev *hdev);
+#if IS_ENABLED(CONFIG_ACPI)
static int btintel_pcie_acpi_reset_method(struct btintel_pcie_data *data)
{
union acpi_object *obj, argv4;
@@ -2389,6 +2390,12 @@ static void btintel_pcie_perform_pldr(struct btintel_pcie_data *data)
BT_ERR("BT reprobe failed for BDF:%s", pci_name(pdev));
}
}
+#else
+static void btintel_pcie_perform_pldr(struct btintel_pcie_data *data)
+{
+ bt_dev_warn(data->hdev, "PLDR not supported, ACPI is disabled");
+}
+#endif
static void btintel_pcie_reset_work(struct work_struct *wk)
{
--
2.43.0
next reply other threads:[~2026-04-16 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 15:35 Chandrashekar Devegowda [this message]
2026-04-16 15:41 ` [PATCH v2] Bluetooth: btintel_pcie: Fix build error when CONFIG_ACPI is disabled Luiz Augusto von Dentz
2026-04-16 16:08 ` [v2] " bluez.test.bot
2026-04-16 18:11 ` bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416153524.1405955-1-chandrashekar.devegowda@intel.com \
--to=chandrashekar.devegowda@intel.com \
--cc=bhelgaas@google.com \
--cc=chethan.tumkur.narayan@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ravishankar.srivatsa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox