From: Martin Brodeur <admin@fluentlogic.org>
To: linux-bluetooth@vger.kernel.org
Cc: Martin Brodeur <admin@fluentlogic.org>
Subject: [PATCH BlueZ] sdp: fix overflow in sdp_extract_seqtype()
Date: Mon, 04 May 2026 16:01:24 +0000 [thread overview]
Message-ID: <20260504160118.26675-1-admin@fluentlogic.org> (raw)
bt_get_be32() returns uint32_t. Assigning directly to the
int *size parameter sign-extends values greater than INT_MAX
to negative, bypassing sequence-length sanity checks in
extract_seq() and sdp_extract_pdu() callers.
Store the result in a uint32_t first and return an error if
the value exceeds INT_MAX. This closes the residual paths not
covered by commit 31e4fb1.
Reported-by: Martin Brodeur <admin@fluentlogic.org>
---
lib/bluetooth/sdp.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/bluetooth/sdp.c b/lib/bluetooth/sdp.c
index 7210ce0..3295fc0 100644
--- a/lib/bluetooth/sdp.c
+++ b/lib/bluetooth/sdp.c
@@ -1249,7 +1249,15 @@ int sdp_extract_seqtype(const uint8_t *buf, int bufsize, uint8_t *dtdp, int *siz
SDPERR("Unexpected end of packet");
return 0;
}
- *size = bt_get_be32(buf);
+ {
+ uint32_t val32 = bt_get_be32(buf);
+
+ if (val32 > INT_MAX) {
+ SDPERR("Sequence length overflow");
+ return 0;
+ }
+ *size = (int) val32;
+ }
scanned += sizeof(uint32_t);
break;
default:
--
2.39.5 (Apple Git-154)
next reply other threads:[~2026-05-04 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 16:01 Martin Brodeur [this message]
2026-05-04 17:26 ` [BlueZ] sdp: fix overflow in sdp_extract_seqtype() bluez.test.bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-04 15:16 [PATCH BlueZ] " Martin Brodeur
2026-05-04 14:50 admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504160118.26675-1-admin@fluentlogic.org \
--to=admin@fluentlogic.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox