From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240AA3A9861; Thu, 2 Jul 2026 10:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.244.123.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782987293; cv=none; b=gRA4lZsy35XI26Q5jjLAXmB2sHap/YCQ4Cme04pt4fB10OWY0/yz4sFtcTLC9xZ0/iiss339oWVURJBeJXCGDGMcUGfFF/axScXepXI4r9tG6vh5iV9XeVC34CIoAs+MeNx28HwFvhju8xDLbh2EQZODkXVQXuDqfVJ6mXVU3cE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782987293; c=relaxed/simple; bh=GCubNCwHGKKRjcbuA5IQghYrHsyFAHHtJv6R8FC/1/U=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=SQQDkmUV9fQ+0qLwQ2wxRRva+DguhbOi6EtMsMBJVLQir7FTTtH4Oj0Zyu5bLG+nE0Hb0JKUp9q9O6SB0xwwH5Ny0DzfQIuvy534ymNp1um1i0rluSJiQLEFCJH5sy1eD4DipMFCpK/fvxPah6cqx+OPfzOcUtPrgrPmeLZ+vMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=a11haF1Z; arc=none smtp.client-ip=60.244.123.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="a11haF1Z" X-UUID: d5ef3a0275fe11f1b1788b6acf885367-20260702 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=2r+opIPiZDVid6SD99FpJALwExcU62X0RllDnLmIzXc=; b=a11haF1Z/Z1k2JNsc5/+ADzxHvxMoDvKC4Pp9visxmy6wSoos6WALlaDPVKLL82+gSn4FkDQAhXV8mRa+mCoJskmJ0iuIjhMjLBgpR28prnHj9Gy1tKTUC+KkYEW9Mmp+g5f3hTqkN4TXfCUZ9+ahAxhu8X3pR+sewcK0qUcif4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.17,REQID:848dac05-a340-463d-a81e-07f413216af9,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:d497b38,CLOUDID:2087e6ee-6085-4bd7-b32c-8f3a894d1f02,B ulkID:nil,BulkQuantity:0,SF:102|136|836|865|888|898,TC:-5,Content:0|15|50| 99|100|102|156|200|213,EDM:-3|-100,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS: nil,BEC:-1,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC :0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: d5ef3a0275fe11f1b1788b6acf885367-20260702 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 449050525; Thu, 02 Jul 2026 18:14:39 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 2 Jul 2026 18:14:38 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Thu, 2 Jul 2026 18:14:38 +0800 From: Chris Lu To: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz CC: Sean Wang , Will Lee , SS Wu , Steve Lee , linux-bluetooth , linux-kernel , linux-mediatek , Paul Menzel , Chris Lu Subject: [PATCH v9 0/6] Bluetooth: btmtk: Add MT7928 support Date: Thu, 2 Jul 2026 18:14:30 +0800 Message-ID: <20260702101437.1787800-1-chris.lu@mediatek.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This patch series adds support for MT7928 (device ID 0x7935) to the btmtk driver, which requires a new two-stage firmware loading process with CBMCU firmware. The series is organized to fix existing issues first, then improve code quality, and finally add new functionality: Patch 1 fixes a pre-existing security issue in btmtk_setup_firmware_79xx() by adding comprehensive firmware size validation to prevent out-of-bounds memory access with truncated or malicious firmware files. Patch 2 fixes a pre-existing bug in btmtksdio_setup() where btmtk_fw_get_filename() generates the correct firmware path but is immediately overwritten by snprintf() with a generic legacy format, causing newer chips to request incorrect filenames. Patch 3 fixes a regression introduced in commit 28b7c5a6db74 ("Bluetooth: btmtk: Add MT6639 (MT7927) Bluetooth support") where SDIO devices would incorrectly log "BT HW ver: 0x0000" due to hardcoded dev_id=0. Patch 4 refactors existing firmware download code by replacing magic numbers with a descriptive BTMTK_WMT_PKT_* enum, making the packet sequencing logic clearer. Patch 5 improves BT firmware logging to provide more useful information for debugging: adds firmware filename before loading and displays chip ID as HW version instead of firmware's hwver field. Patch 6 implements MT7928 firmware download flow, which requires loading CBMCU firmware before Bluetooth firmware. The CBMCU firmware uses a two-phase download sequence: Phase 1 downloads the section containing global descriptor and signature data, Phase 2 downloads the remaining firmware sections. Tested on MT7928 hardware with successful firmware loading and Bluetooth functionality verification. Changes in v9: - Reorder patches to group SDIO fixes together (Patch 2-3) - Patch 1 (was Patch 2): Fix firmware size validation in btmtk_setup_firmware_79xx() - Patch 2 (was Patch 1): Fix firmware filename override in btmtksdio_setup() btmtk_fw_get_filename() result was incorrectly overwritten by snprintf() Changes in v8: - Add Patch 1 (now Patch 2) to fix firmware size validation in btmtk_setup_firmware_79xx() - Add Patch 2 (now Patch 3) to fix SDIO device logging regression SDIO devices were passing hardcoded 0, causing "BT HW ver: 0x0000" log Changes in v7: - Patch 4 (was Patch 1): Extend magic number refactoring to btmtk_setup_firmware() in addition to btmtk_setup_firmware_79xx() for consistency - Patch 5 (was Patch 2): Fix potential buffer over-read by using %.16s format specifier for hdr->datetime which is a 16-byte array that may not be null-terminated - Patch 6 (was Patch 3): Apply same %.16s fix to CBMCU firmware logging Changes in v6: - Fix timeout handling in btmtk_cbmcu_patch_status() to return -ETIMEDOUT instead of success when polling exhausts retry count - Add integer overflow protection in btmtk_load_cbmcu_firmware() using check_mul_overflow() and check_add_overflow() Changes in v5: - Split into three patches: refactoring, logging improvement, and new feature - Add Patch 5 (was Patch 2) to improve BT firmware logging independently - Apply same logging improvements to CBMCU firmware in Patch 6 (was Patch 3) Changes in v4: - Split into two patches: refactoring and new feature - Add BTMTK_WMT_PKT_* enum to improve code readability - Replace magic numbers (0xF0, 0xF1) with descriptive macros Changes in v3: - Add firmware size validation with bounds checking - Improve error messages with context information Changes in v2: - Simplified enum usage by consolidating status definitions Chris Lu (6): Bluetooth: btmtk: Add firmware size validation in btmtk_setup_firmware_79xx() Bluetooth: btmtksdio: Remove redundant firmware filename override Bluetooth: btmtksdio: Pass hardware dev_id to mt79xx_setup() Bluetooth: btmtk: Replace magic numbers with WMT packet flag enum Bluetooth: btmtk: Improve BT firmware logging Bluetooth: btmtk: Add MT7928 support drivers/bluetooth/btmtk.c | 427 +++++++++++++++++++++++++++++++++- drivers/bluetooth/btmtk.h | 9 + drivers/bluetooth/btmtksdio.c | 9 +- 3 files changed, 430 insertions(+), 15 deletions(-) -- 2.45.2