From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11013017.outbound.protection.outlook.com [52.101.83.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA7334192E7; Thu, 9 Jul 2026 10:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783592044; cv=fail; b=jRP9BWocpgOBW6GwRQ/x/1WaFXrrVW+/vb4JZq8I22sTvkx+mz+k8wtfRWFt5Kv3zsHGoiy80gyeX/XQPPM9sPn9nZh6tjG/JeXkUDMmouJleYCKmh0whrF8jH4bUMLHXY1y4dXRlc/6ouN4F8CohT9V/3bwIxR4t7scxz4ZhPY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783592044; c=relaxed/simple; bh=odBo28BT9Bu4qvZsULgPVz87pyTLfNcXLScXtCoqMaI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tu9mgMu/YfkD2gobnYMa052drFmVQR4H4/Qpc6Mv11xyBeyhqbYN1y3Oo7itxP7g+gmI+zZL7Amiuspu4oPw+9nQKm+4iCxZt4atuGpsix8KEr0SiKDtGEMreM400Mtn5sjOUctUQCb8rtHVj+/oHlNE17lO0tE2WNAaJmgwTvc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=qNDnyleV; arc=fail smtp.client-ip=52.101.83.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="qNDnyleV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v5OQeT/un9r68RUBX8bGsxzfkzxWMA4pp8oHikfmzWWIQoTNp8VCyJ2WhNFRd9jamslkssIh8NE5ZIYwaI21jT0fGCxXUULer6ys5oPSeZDjOmzBaRt8AaPbUv0to7JoH5pCnO8ktRqwF5tdtZ4HvDmNnMpiOspLXjqJm//spmu+xSwu6oSalF+XFWyqmsAIWfY/IqfyfJ6UG3Xdtd4v9a0jsrBYKFkaPc6xSiu0YX9DSO22vyscvrqhXp8NoFG/EfSX6Bul+1iPdV09nFmKzuNo3IgD34vAF/HfcZyBxGEnwv+Am9aerFKTZjV4oqw8QrdAWpSNq1jLc9Fwee0Q+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lrzN8TD5BJROFjQZ3kreDCVGLrpFvl4LkH0QdjSNQV4=; b=ZptmsPyFLwcITpGiTYR27LTaxv9DUKhq7x/W/o3fzbGOg2hSgUR9q5EsrJGfRUMg149Esy5UqRQ5b3HmtJck7skj5UTuCJIkqSSgZOh7U1Kzo08/Hm73ulLiTLyz8a/6tP1kuaP3zQ2a661sJvlx+QkDVO/SubjDQfMtQIQMiKMWMXGQrXizjvVcb41/fosdeqjamLb2ZUEh31o0e9tYkxwRSIg5jSEQv4+tKc7g6WF0D4TU+hUD1lJmfMJ1TQx00Q4yFGQCpG9H6r/GOawlZ/UugoYiq49KS9Jer54kcF7pjfMV2bLm5yHUfYjc4Yqq0IdLl9E8LBx/Psz2/uL1EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lrzN8TD5BJROFjQZ3kreDCVGLrpFvl4LkH0QdjSNQV4=; b=qNDnyleVd4xUWIbIubwdEGrZ9h34yvLrQy+gvvkMtMXvS85xitTe6CZMBRbDHtV1Vgm84bNcLSOnFJx7XkYXUs5uY0W8PxBFeyjqkAjIxrmsaIUVWBYYOEapKbPjhiXXhHhWOAXhamT97hChOFvkfFQDMJ20aOKtWsZROuURP2PjLjzUmhrGYFmPeyARuXUlxPUU3DAsIM9f1DJ4D1dzUWGAEujvMa9fSzCvUYRIzH6K7Dbk0tooygFJkeZ9J8RNh+l3f82NizG60TrQ4Ft9WCxFJnmtRP/PbDzg8zkagRS8hK0vKo69NMiIR4PTx+SxLKi+oJ5lb5I9OZSsI8I4jQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) by AS5PR04MB9854.eurprd04.prod.outlook.com (2603:10a6:20b:673::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Thu, 9 Jul 2026 10:13:57 +0000 Received: from VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be]) by VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be%5]) with mapi id 15.21.0181.014; Thu, 9 Jul 2026 10:13:57 +0000 From: "Sherry Sun (OSS)" To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, amitkumar.karwar@nxp.com, neeraj.sanjaykale@nxp.com, marcel@holtmann.org, luiz.dentz@gmail.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, brgl@kernel.org Cc: imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, sherry.sun@nxp.com Subject: [PATCH V5 3/4] Bluetooth: btnxpuart: Add M.2 Bluetooth device support using pwrseq Date: Thu, 9 Jul 2026 18:15:54 +0800 Message-ID: <20260709101555.3034853-4-sherry.sun@oss.nxp.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260709101555.3034853-1-sherry.sun@oss.nxp.com> References: <20260709101555.3034853-1-sherry.sun@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI3PR02CA0006.apcprd02.prod.outlook.com (2603:1096:4:295::13) To VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI2PR04MB11276:EE_|AS5PR04MB9854:EE_ X-MS-Office365-Filtering-Correlation-Id: b619d6ad-432c-467c-089e-08dedda2c94a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|7416014|1800799024|19092799006|23010399003|56012099006|11063799006|18002099003|22082099003|6133799003|921020; X-Microsoft-Antispam-Message-Info: v6m/S0SoCZuDvRoUAtZ0y22t/BLDBAHs0DMh+GBJCxT3A7MQRcvS5PCHHCtmDUvfbjfIX3wbkLQF3bc9wKQX4LdWOHOoBQHoaYBLQpnmFEo6FcA5R+/sqv5EzJhvaoG6In5DP7xuBd3D9NukLBOy8S3lqF/Cx/sSY/qOTjpH3JYyH+hjsyubQOwdX/luq6WFUnTuN/NhcoE3n4qkTn+Z0Fw1I9ryaSkXIgbee3/z9ximpy4BK1JH7US2oYrsSCZZM1jaNIuyiEaodrDgvf08KAC00uOjUklTQBIvHOaJQm+PY06B2C0FrSfbVcwbuSZ4sySxZ4PAbq/bovPQ74ov2k7zqq6TKo3lmRaNPqNpkoHeiqH0FfMGGhOkThc7UNc+yOKNscMoajGn0jQyUF9popDzP3NK7b28GfvXeZfL5T+MsujUHDRBslL7Sg5F/AFDGvSSj6F9RbsyGxZdXq+EcuStYg9cABzjQObrUXGy+g84VOO1xTax8d94OQmk+L4JVPFU+Jvo2oVnpxDyJdpxv8+e/yClCDpAgCfWO27TJ9tHwL5RVD9ujmoGZLTUnWQXVpLz7ein1l1yT8uZbBWOzBJH+iTS0zItKxxr5DV+l98QF12QOMuIGOpctlASod3ZG6eVn9Tw352SvrSYjqUEhW44ODJZgLorDBAXIJFy6c2pGnefJAlX+hBWJiPPw651dXBNLyByzzdOy2QeJoISWg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI2PR04MB11276.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024)(19092799006)(23010399003)(56012099006)(11063799006)(18002099003)(22082099003)(6133799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KDQEshDLQVQ6/Z38D8guh1WjK3DRclSsV5Y2dVngSSW1Wvv8Y9NGrURtpVLz?= =?us-ascii?Q?1FUCU8MWaHzEFzNuNsWDyJRaRhMepcQYiGF6DwH4K5FbTDP/gpCTgXeZe6PT?= =?us-ascii?Q?2cmcsAphXopQuCdTnn5ep9HfYFTU0/dgch8383iIOV++wlF39H7xlRoGjVSe?= =?us-ascii?Q?l+BbQG5Tx072Od1HV6LP4HdZPj+L2gs9YmvEpwo74ibDJC3trzsKpCDZGEqd?= =?us-ascii?Q?uD8jC4TfIyRqqcXKFLwiYyZyO5+FGw2JdpIH2SLM7YnO2YJPMwGX72f5Ec4q?= =?us-ascii?Q?waAJM6ILJp0jzOZQsUrUo442Y8iNU7E4RMBTiai4xeG6D7tebhCZ4PlAzSHt?= =?us-ascii?Q?RTaL7tKbpIieDtPDlNNWem9RpAV5ebDWQCfxFoRSTzHPkaqJaYOTkcVhCOvM?= =?us-ascii?Q?j8Og4ERyRubv7/2c5zBMwf/xhVnRp63jyV2aEJ+dbCcK/9Yskn6fl7LWFcYm?= =?us-ascii?Q?83+LvoOvATsrC8brF1XgGzDo1OWcXhAfmPQqxusVWsVyR15MxvJY9g4ZiN/F?= =?us-ascii?Q?xYlpyzGLrYz9yeNH/mjAYvBSKlYqs8m6wFZBcS7HJXYeP7HK9sYwQKPNopme?= =?us-ascii?Q?X3QLPu8Pykqc9O+jaF1aIIzM+EPeToLqfuIEzMkqbd/sJWaCsf1xmS/fs51q?= =?us-ascii?Q?FjpoQsgcoRKPVblb1vjqde/d61ZzDhcL8WzmTVIGDi0WRvBe/Z0f+vLvADzF?= =?us-ascii?Q?UyrS5K7fG9Q/ksl35iI4781++L5ij1rOUBR/rANPvpdUjXUU/gLk1eSZJrNf?= =?us-ascii?Q?KLJOs4mElUVoo4rOozcW0gXkYwEgcUw589lzUnq0B3z5/M2aGPVaCvu+wWWZ?= =?us-ascii?Q?w1+ocMUjuKP13U4jvPykTfqz7vi3t+1o6fJQxtxpSNpODa45Amrpl6R0ier5?= =?us-ascii?Q?dONo3vzRsmUnIrmPqIHESTYw7VeyU91VdeJ3KjkOY0hfH5pAsRU9xLr98OJP?= =?us-ascii?Q?OVdgxi0nMGCt2EOOKNLis5TfqoehEmsjj/Y5kbOlzZn9Ou5PevXUs4wTT2ar?= =?us-ascii?Q?Z4xzc2CRc8biYYyVwclJygBncdNzwhbx5dsd6f1FdQjvc4CHhMepHSWYCl+5?= =?us-ascii?Q?SkocJvUevkmvvOgwMt2ZWqt8xPN9m+sfy1E/XYkfkGUi5fiPnme8jnyp18oH?= =?us-ascii?Q?UiVUev3965Jb53Gc/kOG/tpD9ZzWk6BAHyP21Sp9H0LsL0VnBnHslwCGoz+P?= =?us-ascii?Q?IUy2HkM2d3iAnan3eY3sZFlo/y6dNGWAB17x/KpoQjS8vAU6ibLvTvYi/pTf?= =?us-ascii?Q?HOPVwIAQ5WzMDCr6TJbMVF30nYcUeoQcTLFKQWiPgefwnCfx937ssGIuTOdA?= =?us-ascii?Q?puTOmbHpWMIHSvEuqKVrOXK08BhADMqKJ4ld6pT593hjqZOwUK6rkJdE8pOr?= =?us-ascii?Q?+BrxMdoeV6y0qTo0xX+d+56cftzXkzMYhLQWeCXFLI33c4MYqQE6d5TP03b3?= =?us-ascii?Q?jtjQyvsrfbY1ZfIi6G3SxaD/OdgTEv7d7zOqySYEcSBQtHhIiTqpxMhUMVK/?= =?us-ascii?Q?pvvCMdHmya/opvY5r8n82eetnrcDYa+DeEITb7fexxTxAYRkl0mdftF4eWjC?= =?us-ascii?Q?MoVc1xzJBtQIjAvWDJEE+/JXARv7KIHCIrOU6hefO1pLkNkZJ6sGZLUEdpRh?= =?us-ascii?Q?aHm1wPpSHZ1+71QfM75L6T2s6Z7qZwl0L9DwZC95mnpkE7FYrXX0HAn2ujEE?= =?us-ascii?Q?1r7CwCstWiox4NUBRvmFn+PVi5wpgZk+q6GOG/kszJTwTYrrKrKnqXm0qU+0?= =?us-ascii?Q?mpAoqRNoV73JWKlK5ePqU9hmjBu6XKe5Y/F3vUSKUgGrkD+NuX3W?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b619d6ad-432c-467c-089e-08dedda2c94a X-MS-Exchange-CrossTenant-AuthSource: VI2PR04MB11276.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2026 10:13:56.8887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oifRsLCG7RMEbh2Q656t4oHNJhNmuOsEjkkS4hWJvg8AUg/9ThOIh+qsCIyJWfoi6LgkuIApQZ6j4d1RgwnAiiOBsWb+rs422oFzv2o3Z1zfWSqxRJ1d60Aq3rBgV/HP X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9854 From: Sherry Sun Power supply to the M.2 Bluetooth device attached to the host using M.2 connector is controlled using the 'uart' pwrseq device. So add support for getting the pwrseq device if the OF graph link is present. Once obtained, pwrseq_power_on() is called to power up the M.2 Bluetooth card. The power sequencer descriptor is obtained via devm_pwrseq_get() with the UART controller device (serdev->ctrl->dev), since the OF graph link is defined on the UART controller node. The devm cleanup of the pwrseq descriptor is tied to the UART controller device, not the serdev child device, so it does not fire when the serdev probe fails and nxp_serdev_remove(), an explicit pwrseq_power_off() call is added in probe error path and nxp_serdev_remove() to ensure the power reference stay balanced. Signed-off-by: Sherry Sun Reviewed-by: Bartosz Golaszewski Reviewed-by: Frank Li --- Hi Frank and Bartosz, this V5 patch adds an explicit pwrseq_power_off() call in both probe error path and nxp_serdev_remove() to properly handle power references. I'm keeping your Reviewed-by tag. I can remove it if you think it's inappropriate. --- drivers/bluetooth/btnxpuart.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index 0bb300eef157..68f84c324113 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -9,6 +9,8 @@ #include #include +#include +#include #include #include #include @@ -211,6 +213,7 @@ struct btnxpuart_dev { struct ps_data psdata; struct btnxpuart_data *nxp_data; + struct pwrseq_desc *pwrseq; struct reset_control *pdn; struct hci_uart hu; }; @@ -1872,11 +1875,26 @@ static int nxp_serdev_probe(struct serdev_device *serdev) return err; } + if (of_graph_is_present(dev_of_node(&serdev->ctrl->dev))) { + struct pwrseq_desc *pwrseq; + + pwrseq = devm_pwrseq_get(&serdev->ctrl->dev, "uart"); + if (IS_ERR(pwrseq)) + return dev_err_probe(&serdev->dev, PTR_ERR(pwrseq), + "failed to get pwrseq\n"); + + nxpdev->pwrseq = pwrseq; + err = pwrseq_power_on(pwrseq); + if (err) + return err; + } + /* Initialize and register HCI device */ hdev = hci_alloc_dev(); if (!hdev) { dev_err(&serdev->dev, "Can't allocate HCI device\n"); - return -ENOMEM; + err = -ENOMEM; + goto err_pwrseq_power_off; } reset_control_deassert(nxpdev->pdn); @@ -1907,13 +1925,16 @@ static int nxp_serdev_probe(struct serdev_device *serdev) if (bacmp(&ba, BDADDR_ANY)) hci_set_quirk(hdev, HCI_QUIRK_USE_BDADDR_PROPERTY); - if (hci_register_dev(hdev) < 0) { + err = hci_register_dev(hdev); + if (err < 0) { dev_err(&serdev->dev, "Can't register HCI device\n"); goto probe_fail; } - if (ps_setup(hdev)) + if (ps_setup(hdev)) { + err = -ENODEV; goto probe_fail_unregister; + } hci_devcd_register(hdev, nxp_coredump, nxp_coredump_hdr, nxp_coredump_notify); @@ -1925,7 +1946,10 @@ static int nxp_serdev_probe(struct serdev_device *serdev) probe_fail: reset_control_assert(nxpdev->pdn); hci_free_dev(hdev); - return -ENODEV; +err_pwrseq_power_off: + if (nxpdev->pwrseq) + pwrseq_power_off(nxpdev->pwrseq); + return err; } static void nxp_serdev_remove(struct serdev_device *serdev) @@ -1952,6 +1976,8 @@ static void nxp_serdev_remove(struct serdev_device *serdev) ps_cleanup(nxpdev); hci_unregister_dev(hdev); reset_control_assert(nxpdev->pdn); + if (nxpdev->pwrseq) + pwrseq_power_off(nxpdev->pwrseq); hci_free_dev(hdev); } -- 2.50.1