Linux bluetooth development
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth@vger.kernel.org (open list:BLUETOOTH DRIVERS),
	linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH] Bluetooth: Remove redundant dev_err()
Date: Fri, 10 Jul 2026 19:06:50 +0800	[thread overview]
Message-ID: <20260710110651.448373-1-panchuang@vivo.com> (raw)

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/bluetooth/btmrvl_sdio.c | 5 -----
 drivers/bluetooth/hci_nokia.c   | 4 +---
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 93932a0d8625..a84275b8833a 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -93,11 +93,6 @@ static int btmrvl_sdio_probe_of(struct device *dev,
 			ret = devm_request_irq(dev, cfg->irq_bt,
 					       btmrvl_wake_irq_bt,
 					       IRQF_NO_AUTOEN, "bt_wake", card);
-			if (ret) {
-				dev_err(dev,
-					"Failed to request irq_bt %d (%d)\n",
-					cfg->irq_bt, ret);
-			}
 
 			/* Configure wakeup (enabled by default) */
 			ret = devm_device_init_wakeup(dev);
diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
index 1e65b541f8ad..2dc3d97bcca1 100644
--- a/drivers/bluetooth/hci_nokia.c
+++ b/drivers/bluetooth/hci_nokia.c
@@ -709,10 +709,8 @@ static int nokia_bluetooth_serdev_probe(struct serdev_device *serdev)
 		wakeup_handler,
 		IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 		"wakeup", btdev);
-	if (err) {
-		dev_err(dev, "could request wakeup irq: %d", err);
+	if (err)
 		return err;
-	}
 
 	btdev->wakeup_bt = devm_gpiod_get(dev, "bluetooth-wakeup",
 					   GPIOD_OUT_LOW);
-- 
2.34.1


             reply	other threads:[~2026-07-10 11:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 11:06 Pan Chuang [this message]
2026-07-10 13:26 ` Bluetooth: Remove redundant dev_err() bluez.test.bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260710110651.448373-1-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox