From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58D2E184524; Tue, 14 Jul 2026 12:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.244.123.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784032419; cv=none; b=RMuRLiIxkQCVLzg3LIqlJTMmKyoiP4Op/9VUMmFb9vuafIaS9ExQHUu5YPqUYPZnIix60XrxLuOS+cJjv8e+kQve17kxrdiJIe67AnslVJa5fF0qF1W+nYri/7JnCvCtfV/GkCBfNJ4iO1lyNnyWU3y3zoHXkAiG9K49vX5qd98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784032419; c=relaxed/simple; bh=rBaE/MfcEdjivbR33oYhxxSSow7u4OoqpDnrq0hx0k0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=epvS8c9QH4R2bWvPaBLAjF2E3nVHCiyOGP9shjt4jHLhjZolplSYqeVNduStRfQOR8pVO6ya/hRVHqlCDgPqqUlXbgYPUk9YU6I0SxU5osYAug4g4FdqlRNhJ+5w1NFwcXDtzxQpeOopn1+RqrF6q0lxKVyRYXsPEFJISk5SogQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=PtaQ6JHJ; arc=none smtp.client-ip=60.244.123.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="PtaQ6JHJ" X-UUID: 3091dfca7f8011f1b1788b6acf885367-20260714 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=06jzXmWyrPOrkABaEWPVVx+A/MarDT9Aq0Bgk0yLqzE=; b=PtaQ6JHJznHuZ974Wci30bJbn4TSTJbK41XrG6gc7+TKv748erR52p10zVgC7tskxOl5CRgCqd+G6TBtVRTzf8g8bSyXhgVjv2StrrJrRhbcCSlw/5fYKU0UT6Hz7K5YQDebYcN2M5a6txSfqkjiCs7Nr+zuMG6Kmski8RiaJUE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.17,REQID:5a1be2ea-6060-4e51-8952-a17537262835,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:d497b38,CLOUDID:a48e2115-ea64-44d4-98db-4e1fb89955a3,B ulkID:nil,BulkQuantity:0,SF:81|82|102|836|865|888|898,TC:-5,Content:0|15|5 0|99|200|213,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL: 0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 3091dfca7f8011f1b1788b6acf885367-20260714 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 710979770; Tue, 14 Jul 2026 20:33:17 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 14 Jul 2026 20:33:15 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Tue, 14 Jul 2026 20:33:15 +0800 From: Chris Lu To: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz CC: Sean Wang , Will Lee , SS Wu , Steve Lee , Paul Menzel , linux-bluetooth , linux-kernel , linux-mediatek , Chris Lu Subject: [PATCH v10 3/7] Bluetooth: btmtksdio: Remove redundant firmware filename override Date: Tue, 14 Jul 2026 20:33:09 +0800 Message-ID: <20260714123314.814333-4-chris.lu@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260714123314.814333-1-chris.lu@mediatek.com> References: <20260714123314.814333-1-chris.lu@mediatek.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain btmtksdio_setup() calls btmtk_fw_get_filename() to generate the correct firmware filename based on chip ID, then immediately overwrites it with snprintf() using a generic legacy format. This causes newer chips that require chip-specific firmware paths (MT6639, MT7925, MT7928) to request incorrect legacy filenames, leading to firmware load failures. The USB driver (btmtkusb.c) correctly uses btmtk_fw_get_filename() without overriding the result. Match that behavior by removing the redundant snprintf() call. Fixes: 7f935b21bee4 ("Bluetooth: btmtk: apply the common btmtk_fw_get_filename") Signed-off-by: Chris Lu --- drivers/bluetooth/btmtksdio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index a21edefaca99..1d9bf9928c6d 100644 --- a/drivers/bluetooth/btmtksdio.c +++ b/drivers/bluetooth/btmtksdio.c @@ -1162,9 +1162,6 @@ static int btmtksdio_setup(struct hci_dev *hdev) btmtk_fw_get_filename(fwname, sizeof(fwname), dev_id, fw_version, 0); - snprintf(fwname, sizeof(fwname), - "mediatek/BT_RAM_CODE_MT%04x_1_%x_hdr.bin", - dev_id & 0xffff, (fw_version & 0xff) + 1); err = mt79xx_setup(hdev, fwname); if (err < 0) return err; -- 2.45.2