From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3C7F343D75; Fri, 17 Jul 2026 08:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.244.123.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277586; cv=none; b=VWzPIj+ABgMJaXDzFKK8o+V4ecCF5fQ/VKGgCFO+X6qqCioOohnosZ5a+NHKuCms7TJ1cdf5iD2hAEG0IhYBOax22hbnhaf7Nj6XAOwtyf4Qj7ZHVewlDBbbLP2RRxokRsNT+LdTH9tAK4z7G/45d2lgLgZjIhcz3FpDosLCeq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784277586; c=relaxed/simple; bh=b8Iwl6CNpT4qOX6Ot14Bv10aLVTuf0sIeSa0JQJCYi4=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=A8yK88Jbv5pd73CYA6gsRleHcR0qhFXm95qdbVayNtRxjQfZO1TXI7SEhvzl6nuE23BVkn1VodvlmJdq/dIS49JkxkF69MO/rNNsaDmx/UXl+7tQX/YvkFpdcpW6hxzrchVurigyABZr2aRF17GDgGSFrqL6SCdwbkAEhU1X0mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=rxnM1WbU; arc=none smtp.client-ip=60.244.123.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="rxnM1WbU" X-UUID: 0c141d4c81bb11f1b1788b6acf885367-20260717 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=wfEBk7+DETCq/337t74L0/OSrJQnXlYUDD8RMnEvRSA=; b=rxnM1WbU7dt/zl95xYPAdzc2ujjpTWx8YHg+D+uEy5WcwGLOM1IGXpTFx94+9r1y0nANtg1j3ngZtqorPet84LlgA1MKHu3GIFbuGZRHZASP6QPpt0L3Q4TStBDyb1qFjkMFZGA7R9BpmMDMaMAaWoI9qGVnhRk9eF7rCEzdDAU=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.18,REQID:33094e42-8da0-4274-be4a-4f4000d265b4,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:8a735a6,CLOUDID:23ddf450-9df4-4a32-98eb-0af8dcdad6c0,B ulkID:nil,BulkQuantity:0,SF:102|136|836|865|888|898,TC:-5,Content:0|15|50| 99|100|102|156|200|213,EDM:-3|-100,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS: nil,BEC:-1,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC :0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 0c141d4c81bb11f1b1788b6acf885367-20260717 Received: from mtkmbs09n1.mediatek.inc [(172.21.101.35)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 161473863; Fri, 17 Jul 2026 16:39:38 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 17 Jul 2026 16:39:37 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Fri, 17 Jul 2026 16:39:37 +0800 From: Chris Lu To: Marcel Holtmann , Johan Hedberg , Luiz Von Dentz CC: Sean Wang , Will Lee , SS Wu , Steve Lee , Paul Menzel , linux-bluetooth , linux-kernel , linux-mediatek , Chris Lu Subject: [PATCH v16 0/7] Bluetooth: btmtk: Add MT7928 support Date: Fri, 17 Jul 2026 16:39:29 +0800 Message-ID: <20260717083936.2923891-1-chris.lu@mediatek.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This patch series adds support for MT7928 (device ID 0x7935) to the btmtk driver, which requires a new two-stage firmware loading process with CBMCU firmware. Patch 1 fixes SKB handling issues: DMA out-of-bounds read and cloned SKB corruption. Fix by calling skb_unshare() and expanding skb tailroom with zero-padding. Use double-pointer to properly update caller's SKB pointer, preventing use-after-free. Patch 2 adds firmware size validation with integer overflow protection to prevent out-of-bounds access with malicious firmware files. Patch 3 passes hardware dev_id to mt79xx_setup() to fix incorrect chip ID logging (was hardcoded to 0). Patch 4 removes redundant snprintf() that overrides btmtk_fw_get_filename() result, causing newer chips to request incorrect firmware filenames. Patch 5 improves firmware logging: adds filename log, uses chip ID as HW version, and uses %.16s format specifier for datetime field. Patch 6 replaces magic numbers with BTMTK_WMT_PKT_* enum for better code readability. Patch 7 implements MT7928 CBMCU firmware download with two-phase loading sequence and cert_len overflow protection. Tested on MT7928 hardware with successful firmware loading and Bluetooth functionality verification. Changes in v16: - Fix Patch 1 SKB ownership issues reported by Sashiko: * Use double-pointer (struct sk_buff **pskb) to properly update caller's SKB pointer when skb_unshare() allocates new SKB * On error paths, do not free SKB - leave it valid for caller to requeue, preventing use-after-free in btmtksdio_txrx_work() * Prevents memory leak when pskb_expand_head() fails after skb_unshare() succeeds Changes in v15: - Rebased onto latest bluetooth-next/HEAD (bd8bee79e1fa) - No functional changes from v14 - Fixed patch application issues reported by Sashiko Changes in v14: - Rebased onto latest bluetooth-next tree - No functional changes from v13 Changes in v13: - Fix cloned SKB corruption (HIGH severity) by adding skb_unshare() (Patch 1) - Fix cert_len integer overflow (CRITICAL severity) in CBMCU firmware loading (Patch 7) Pre-existing issues fixed in subsequent patches: - Patch 2 introduces format string issue (%s on non-null-terminated field) -> Fixed in Patch 5 using %.16s format specifier - Patch 3 context has pre-existing snprintf() override (identified in v12 review) -> Fixed in Patch 4, resolving firmware load failures on MT6639/MT7925/MT7928 This gradual improvement approach allows independent backporting of each fix. v12 -> v13: - Added skb_unshare() to prevent cloned SKB corruption - Added overflow checks for cert_len calculation - Split SDIO firmware loading fixes into two patches Changes in v12: - Reordered patches to fix dependency: move "Pass dev_id" before "Improve logging" so dev_id is available when logging Changes in v11: - Fixed use-after-free: reassign sdio_hdr after pskb_expand_head() - Reordered patches for bisectability Changes in v10: - Added Patch 1 to fix DMA out-of-bounds access Changes in v9: - Reordered patches to group SDIO fixes together Changes in v8: - Split firmware validation from dev_id pass-through into separate patches Changes in v7: - Added Fixes tag per feedback Changes in v6: - Added Fixes tag and restructured parameter comment Changes in v5: - Moved documentation to function-level comment Changes in v4: - Fixed commit message and expanded description Changes in v3: - Changed dev_id type from u16 to u32 Changes in v2: - Combined MT7928 functionality into single patch Chris Lu (7): Bluetooth: btmtksdio: Fix SKB handling issues in TX path Bluetooth: btmtk: Add firmware size validation in btmtk_setup_firmware_79xx() Bluetooth: btmtksdio: Pass hardware dev_id to mt79xx_setup() Bluetooth: btmtksdio: Remove redundant firmware filename override Bluetooth: btmtk: Improve BT firmware logging Bluetooth: btmtk: Replace magic numbers with WMT packet flag enum Bluetooth: btmtk: Add MT7928 support drivers/bluetooth/btmtk.c | 427 +++++++++++++++++++++++++++++++++- drivers/bluetooth/btmtk.h | 9 + drivers/bluetooth/btmtksdio.c | 74 ++++-- 3 files changed, 485 insertions(+), 25 deletions(-) -- 2.45.2