From: Ali Ahmet Memis <ali@iusegentoo.com>
To: Laxman Acharya Padhya <acharyalaxman8848@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
luiz.dentz@gmail.com, linux-kernel@vger.kernel.org,
raghuram.hegde@intel.com, kiraank@gmail.com, kiran.k@intel.com,
ravishankar.srivatsa@intel.com, amit.k.bag@intel.com
Subject: Re: [PATCH v2 3/3] Bluetooth: btintel: propagate version TLV parsing errors
Date: Fri, 14 Aug 2026 18:46:47 +0000 [thread overview]
Message-ID: <20260814184653.943386-1-ali@iusegentoo.com> (raw)
In-Reply-To: <20260814171503.42684-4-acharyalaxman8848@gmail.com>
This looks good to me. Propagating the parser error here keeps the
version TLV handling consistent with the other setup path and avoids
continuing with partially initialized version data.
Reviewed-by: Ali Ahmet Memis <ali@iusegentoo.com>
prev parent reply other threads:[~2026-08-14 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 17:15 [PATCH v2 0/3] Bluetooth: btintel: harden version TLV parsing Laxman Acharya Padhya
2026-08-14 17:15 ` [PATCH v2 1/3] Bluetooth: btintel: validate version TLV value lengths Laxman Acharya Padhya
2026-08-14 18:29 ` Bluetooth: btintel: harden version TLV parsing bluez.test.bot
2026-08-14 17:15 ` [PATCH v2 2/3] Bluetooth: btintel: bound firmware ID by TLV length Laxman Acharya Padhya
2026-08-14 17:15 ` [PATCH v2 3/3] Bluetooth: btintel: propagate version TLV parsing errors Laxman Acharya Padhya
2026-08-14 18:46 ` Ali Ahmet Memis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814184653.943386-1-ali@iusegentoo.com \
--to=ali@iusegentoo.com \
--cc=acharyalaxman8848@gmail.com \
--cc=amit.k.bag@intel.com \
--cc=kiraank@gmail.com \
--cc=kiran.k@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=raghuram.hegde@intel.com \
--cc=ravishankar.srivatsa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox