Re: Re:Re: [PATCH v2] Bluetooth: HIDP: add missing length check for incoming frames

[kernel test robot <lkp@intel.com>]

Hi jiale,

kernel test robot noticed the following build warnings:

[auto build test WARNING on kees/for-next/pstore]
[also build test WARNING on kees/for-next/kspp]
[cannot apply to bluetooth-next/master bluetooth/master linus/master v7.2-rc7 next-20260814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/jiale-yao/Re-Re-PATCH-v2-Bluetooth-HIDP-add-missing-length-check-for-incoming-frames/20260814-100503
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
patch link:    https://lore.kernel.org/r/220b6be5.d3f.19f78e165aa.Coremail.19888972804%40163.com
patch subject: Re:Re: [PATCH v2] Bluetooth: HIDP: add missing length check for incoming frames
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20260816/202608161044.9x6CmhDO-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 844a18e753e822736c9805ab779144b647a2c186)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260816/202608161044.9x6CmhDO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608161044.9x6CmhDO-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/bluetooth/hidp/core.c:612:48: warning: format specifies type 'unsigned int' but the argument has type 'unsigned char *' [-Wformat]
     612 |                 BT_DBG("Unsupported protocol header 0x%02x", hdr);
         |                                                       ~~~~   ^~~
         |                                                       %2s
   include/net/bluetooth/bluetooth.h:287:47: note: expanded from macro 'BT_DBG'
     287 | #define BT_DBG(fmt, ...)        pr_debug(fmt "\n", ##__VA_ARGS__)
         |                                          ~~~         ^~~~~~~~~~~
   include/linux/printk.h:641:38: note: expanded from macro 'pr_debug'
     641 |         no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
         |                                     ~~~     ^~~~~~~~~~~
   include/linux/printk.h:134:18: note: expanded from macro 'no_printk'
     134 |                 _printk(fmt, ##__VA_ARGS__);            \
         |                         ~~~    ^~~~~~~~~~~
   1 warning generated.


vim +612 net/bluetooth/hidp/core.c

^1da177e4c3f41 Linus Torvalds   2005-04-16  588  
91f5cca3d1b434 Andrew Morton    2008-02-05  589  static void hidp_recv_intr_frame(struct hidp_session *session,
91f5cca3d1b434 Andrew Morton    2008-02-05  590  				struct sk_buff *skb)
^1da177e4c3f41 Linus Torvalds   2005-04-16  591  {
afd2c613d3369f jiale yao        2026-07-19  592  	unsigned char *hdr;
^1da177e4c3f41 Linus Torvalds   2005-04-16  593  
093dabb4f1aff9 Kai Ye           2021-06-03  594  	BT_DBG("session %p skb %p len %u", session, skb, skb->len);
^1da177e4c3f41 Linus Torvalds   2005-04-16  595  
afd2c613d3369f jiale yao        2026-07-19  596  	hdr = skb_pull_data(skb, 1);
afd2c613d3369f jiale yao        2026-07-19  597  	if (!hdr)
afd2c613d3369f jiale yao        2026-07-19  598  		return;
^1da177e4c3f41 Linus Torvalds   2005-04-16  599  
afd2c613d3369f jiale yao        2026-07-19  600  	if (*hdr == (HIDP_TRANS_DATA | HIDP_DATA_RTYPE_INPUT)) {
^1da177e4c3f41 Linus Torvalds   2005-04-16  601  		hidp_set_timer(session);
e1aaadd4d8162a Marcel Holtmann  2007-02-17  602  
^1da177e4c3f41 Linus Torvalds   2005-04-16  603  		if (session->input)
^1da177e4c3f41 Linus Torvalds   2005-04-16  604  			hidp_input_report(session, skb);
e1aaadd4d8162a Marcel Holtmann  2007-02-17  605  
e1aaadd4d8162a Marcel Holtmann  2007-02-17  606  		if (session->hid) {
a4b1b5877b514b David Rheinsberg 2013-12-19  607  			hidp_process_report(session, HID_INPUT_REPORT,
a4b1b5877b514b David Rheinsberg 2013-12-19  608  					    skb->data, skb->len, 1);
e1aaadd4d8162a Marcel Holtmann  2007-02-17  609  			BT_DBG("report len %d", skb->len);
e1aaadd4d8162a Marcel Holtmann  2007-02-17  610  		}
^1da177e4c3f41 Linus Torvalds   2005-04-16  611  	} else {
^1da177e4c3f41 Linus Torvalds   2005-04-16 @612  		BT_DBG("Unsupported protocol header 0x%02x", hdr);
^1da177e4c3f41 Linus Torvalds   2005-04-16  613  	}
^1da177e4c3f41 Linus Torvalds   2005-04-16  614  
^1da177e4c3f41 Linus Torvalds   2005-04-16  615  	kfree_skb(skb);
^1da177e4c3f41 Linus Torvalds   2005-04-16  616  }
^1da177e4c3f41 Linus Torvalds   2005-04-16  617  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki