From: Andrei-Alexandru Bleortu <me@andrei-z.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>
Cc: <linux-bluetooth@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
George Moussalem <george.moussalem@outlook.com>,
<linux-arm-msm@vger.kernel.org>
Subject: [PATCH 3/3] Bluetooth: btqcomipc: take the board's address from the host
Date: Mon, 12 Oct 2026 01:09:19 +0300 [thread overview]
Message-ID: <20261011220919.1816407-4-me@andrei-z.com> (raw)
In-Reply-To: <20261011220919.1816407-1-me@andrei-z.com>
The IPQ5018 NVM carries one placeholder address (50:18:00:00:5a:ad) for
every board, and btqca skips the NVM tag parsing on IPQ5018, so the
placeholder check that sets HCI_QUIRK_USE_BDADDR_PROPERTY for other QCA
parts never matches: the controller came up configured with the
placeholder and, being set up again on every power on, went back to it
even after an address was set through mgmt.
Set the quirk in setup, so the controller stays unconfigured until the
board's address comes from the local-bd-address property or from
userspace, and the core programs it after each setup.
Assisted-by: LLM
Signed-off-by: Andrei-Alexandru Bleortu <me@andrei-z.com>
---
drivers/bluetooth/btqcomipc.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btqcomipc.c b/drivers/bluetooth/btqcomipc.c
index 8513c1780..92a0d671e 100644
--- a/drivers/bluetooth/btqcomipc.c
+++ b/drivers/bluetooth/btqcomipc.c
@@ -997,9 +997,13 @@ static int btqcomipc_setup(struct hci_dev *hdev)
}
/*
- * 7.2 has no NVMEM-backed BD address in the HCI core; the board's
- * address is set from userspace through set_bdaddr instead.
+ * The NVM carries the same placeholder address for every board, so
+ * the controller stays unconfigured until the board's address comes
+ * from the local-bd-address property or from userspace, and the core
+ * programs it again after each setup.
*/
+ hci_set_quirk(hdev, HCI_QUIRK_USE_BDADDR_PROPERTY);
+
return 0;
}
next prev parent reply other threads:[~2026-10-11 22:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 9:18 [PATCH v5 0/6] Add support for IPQ5018 Bluetooth George Moussalem via B4 Relay
2026-07-09 9:18 ` [PATCH v5 1/6] dt-bindings: net: bluetooth: Document Qualcomm IPQ5018 Bluetooth controller George Moussalem via B4 Relay
2026-07-09 12:21 ` Add support for IPQ5018 Bluetooth bluez.test.bot
2026-07-09 9:18 ` [PATCH v5 2/6] Bluetooth: btqca: Add IPQ5018 support George Moussalem via B4 Relay
2026-07-09 9:18 ` [PATCH v5 3/6] firmware: qcom: scm: Add support for setting Bluetooth power modes George Moussalem via B4 Relay
2026-07-09 9:18 ` [PATCH v5 4/6] Bluetooth: Introduce Qualcomm IPQ5018 IPC based HCI driver George Moussalem via B4 Relay
2026-10-11 22:09 ` [PATCH 0/3] Bluetooth: btqcomipc: fixes on top of the IPQ5018 v5 series Andrei-Alexandru Bleortu
2026-10-11 22:09 ` [PATCH 1/3] Bluetooth: btqcomipc: keep the dot in split firmware segment names Andrei-Alexandru Bleortu
2026-10-11 22:17 ` Bluetooth: btqcomipc: fixes on top of the IPQ5018 v5 series bluez.test.bot
2026-10-11 22:09 ` [PATCH 2/3] Bluetooth: btqcomipc: deassert the BTSS reset before enabling its clock Andrei-Alexandru Bleortu
2026-10-11 22:09 ` Andrei-Alexandru Bleortu [this message]
2026-07-09 9:18 ` [PATCH v5 5/6] arm64: dts: qcom: ipq5018: add node required for Bluetooth support George Moussalem via B4 Relay
2026-07-09 18:16 ` Konrad Dybcio
2026-07-09 18:23 ` George Moussalem
2026-07-09 18:17 ` Konrad Dybcio
2026-07-09 18:25 ` George Moussalem
2026-07-09 18:40 ` Konrad Dybcio
2026-07-10 9:14 ` Bartosz Golaszewski
2026-07-10 9:23 ` Konrad Dybcio
2026-07-10 9:32 ` George Moussalem
2026-07-09 9:18 ` [PATCH v5 6/6] MAINTAINERS: Add IPQ5018 driver to Qualcomm Bluetooth driver entry George Moussalem via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261011220919.1816407-4-me@andrei-z.com \
--to=me@andrei-z.com \
--cc=george.moussalem@outlook.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox