Re: [PATCH] Bluetooth: hci_event: Clear explicit connect state on LE connection

[Kevin Dewald <kevin@simpleble.org>]

Hi Luiz,

Sashiko flagged two things on this patch, so here is what I found.

The medium one: if Load Connection Subrate arrives while an explicit
connect to a device without params is still pending, the subrate values
go into the temporary EXPLICIT params. This patch now deletes those on
connection, so the Connection Rate Request is not sent. That is
correct, but bluetoothd only loads subrates at startup, from stored
devices, and those params are DISABLED, so they are kept. A failed
connect already deletes the same values through
hci_connect_le_scan_cleanup(). Moving the cleanup after the subrate
check would not help either, since hci_le_conn_rate_request_sync()
looks the params up again when it runs. If you want that case covered,
load_conn_subrate() could keep such params as DISABLED, which would
also cover a failed connect. I can send that as a separate patch.

The low one: the comment in hci_explicit_conn_params_set() still says
the new params are deleted in hci_connect_le_scan_cleanup(). I can send
a v2 that updates it if you like.

Kevin