From: Kevin Dewald <kevin@simpleble.org>
To: linux-bluetooth@vger.kernel.org
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Kevin Dewald <kevin@simpleble.org>
Subject: [PATCH BlueZ RESEND] monitor: Fix legacy SCAN_RSP PDU type names
Date: Sun, 18 Oct 2026 21:10:09 -0700 [thread overview]
Message-ID: <20261019041009.9720-1-kevin@simpleble.org> (raw)
The names of the two legacy scan response event types are swapped. A
scan response keeps the properties of the advertisement it answers, so
0x1b, which has the connectable bit set, is the response to ADV_IND and
0x1a is the response to ADV_SCAN_IND, as listed in Core Specification
Vol 4, Part E, 7.7.65.13, Table 7.1.
Fixes: e29ef3b85116 ("monitor: Add LE Extended Scan commands decoding")
Assisted-by: Claude:claude-opus-5.5
---
monitor/packet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/monitor/packet.c b/monitor/packet.c
index fe7b054dd..a301e1ae7 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -13076,10 +13076,10 @@ static void print_legacy_adv_report_pdu(uint16_t flags)
str = "ADV_DIRECT_IND";
break;
case 0x1a:
- str = "SCAN_RSP to an ADV_IND";
+ str = "SCAN_RSP to an ADV_SCAN_IND";
break;
case 0x1b:
- str = "SCAN_RSP to an ADV_SCAN_IND";
+ str = "SCAN_RSP to an ADV_IND";
break;
default:
str = "Reserved";
base-commit: fa6ba55020dee3c3183041c854c347b4582448be
--
2.54.0 (Apple Git-157)
next reply other threads:[~2026-10-19 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 4:10 Kevin Dewald [this message]
2026-10-19 7:51 ` [BlueZ,RESEND] monitor: Fix legacy SCAN_RSP PDU type names bluez.test.bot
2026-10-19 15:10 ` [PATCH BlueZ RESEND] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019041009.9720-1-kevin@simpleble.org \
--to=kevin@simpleble.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox