Linux bluetooth development
 help / color / mirror / Atom feed
From: Brandon Williams <turbine.bmw@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Brandon Williams <turbine.bmw@gmail.com>
Subject: [PATCH BlueZ 1/2] smp-tester: Expect the identity key in Pairing Requests
Date: Sat, 24 Oct 2026 07:25:26 -0400	[thread overview]
Message-ID: <20261024112527.249473-1-turbine.bmw@gmail.com> (raw)

The kernel distributes its identity address whenever it bonds over LE
("Bluetooth: SMP: distribute the identity address when bonding"), so
its Pairing Requests set IdKey in the initiator key distribution.

Assisted-by: Claude:claude-opus-5-5
---

Notes:
    These go with the kernel series "[PATCH 0/2] Bluetooth: SMP: distribute
    the identity address when bonding", sent to this list. Against
    bluetooth-next 47d4d9f67e92 under QEMU (arm64, TCG): without the kernel
    patches the four client tests updated here and both new tests fail;
    with them smp-tester passes 10/10 in each of 10 runs. make check passes.
    
    Tool use: written with an AI coding assistant (Claude Code, Claude
    Opus 5.5) together with the kernel series; see its cover letter.
    
    I read both test changes, including why the keys the kernel distributes
    are not compared, and ran the device tests described in the kernel cover
    letter myself.

 tools/smp-tester.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/smp-tester.c b/tools/smp-tester.c
index 581f3a233..cde1211af 100644
--- a/tools/smp-tester.c
+++ b/tools/smp-tester.c
@@ -327,7 +327,7 @@ static const uint8_t smp_basic_req_1[] = {	0x01,	/* Pairing Request */
 						0x00,	/* OOB Flag */
 						0x01,	/* Bonding - no MITM */
 						0x10,	/* Max key size */
-						0x05,	/* Init. key dist. */
+						0x07,	/* Init. key dist. */
 						0x05,	/* Rsp. key dist. */
 };
 static const uint8_t smp_basic_req_1_rsp[] = {	0x02,	/* Pairing Response */
@@ -375,7 +375,7 @@ static const uint8_t smp_basic_req_2[] = {	0x01,	/* Pairing Request */
 						0x00,	/* OOB Flag */
 						0x05,	/* Bonding - MITM */
 						0x10,	/* Max key size */
-						0x05,	/* Init. key dist. */
+						0x07,	/* Init. key dist. */
 						0x05,	/* Rsp. key dist. */
 };
 
@@ -414,7 +414,7 @@ static const uint8_t smp_sc_req_1[] = {	0x01,	/* Pairing Request */
 					0x00,	/* OOB Flag */
 					0x29,	/* Bonding - no MITM, SC, CT2 */
 					0x10,	/* Max key size */
-					0x0d,	/* Init. key dist. */
+					0x0f,	/* Init. key dist. */
 					0x0d,	/* Rsp. key dist. */
 };
 
-- 
2.56.0


             reply	other threads:[~2026-10-24 11:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 11:25 Brandon Williams [this message]
2026-10-24 11:25 ` [PATCH BlueZ 2/2] smp-tester: Add identity key distribution tests Brandon Williams
2026-10-24 14:16 ` [BlueZ,1/2] smp-tester: Expect the identity key in Pairing Requests bluez.test.bot
2026-10-26 17:23 ` [PATCH BlueZ 1/2] " Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024112527.249473-1-turbine.bmw@gmail.com \
    --to=turbine.bmw@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox