Linux bluetooth development
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ v1 3/3] shared/bap: Accept all defined metadata types
Date: Wed, 28 Oct 2026 09:55:17 -0400	[thread overview]
Message-ID: <20261028135517.2395290-3-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20261028135517.2395290-1-luiz.dentz@gmail.com>

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

bap_metadata_process() rejected every metadata type other than
Preferred/Streaming_Audio_Contexts, Program_Info and Language with
Unsupported Metadata, so valid LTVs such as CCID_List, which the Client
must include for content control, caused Enable and Update Metadata to
fail.

Accept all types defined in Assigned Numbers 6.12.6, and reject
Parental_Rating, Audio_Active_State and Assisted_Listening_Stream as
Invalid Metadata when their value is not 1 octet.

Assisted-by: OpenCode:claude-opus-5.5
---
 src/shared/bap.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index d1836afc9ad2..3bdeec2b82e2 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -3443,6 +3443,21 @@ static void bap_metadata_process(size_t i, uint8_t l, uint8_t t, uint8_t *v,
 		break;
 	case BT_BAP_META_PROGRAM_INFO:
 	case BT_BAP_META_LANGUAGE:
+	case BT_BAP_META_CCID_LIST:
+	case BT_BAP_META_PROGRAM_INFO_URI:
+	case BT_BAP_META_BCAST_IMMEDIATE:
+	case BT_BAP_META_BROADCAST_NAME:
+	case BT_BAP_META_EXTENDED:
+	case BT_BAP_META_VENDOR:
+		break;
+	case BT_BAP_META_PARENTAL_RATING:
+	case BT_BAP_META_AUDIO_ACTIVE_STATE:
+	case BT_BAP_META_ASSISTED_LISTENING:
+		if (l != sizeof(uint8_t)) {
+			ascs_ase_rsp_add(data->rsp, data->ep->id,
+					BT_ASCS_RSP_METADATA_INVALID, t);
+			data->err = BT_ASCS_RSP_METADATA_INVALID;
+		}
 		break;
 	default:
 		ascs_ase_rsp_add(data->rsp, data->ep->id,
-- 
2.56.0


  parent reply	other threads:[~2026-10-28 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 13:55 [PATCH BlueZ v1 1/3] shared/bap: Fix line over 80 columns in set_base_subgroup Luiz Augusto von Dentz
2026-10-28 13:55 ` [PATCH BlueZ v1 2/3] shared/bap: Move LTV type defines to bap-defs.h Luiz Augusto von Dentz
2026-10-28 13:55 ` Luiz Augusto von Dentz [this message]
2026-10-28 16:19 ` [BlueZ,v1,1/3] shared/bap: Fix line over 80 columns in set_base_subgroup bluez.test.bot
2026-10-28 19:50 ` [PATCH BlueZ v1 1/3] " patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261028135517.2395290-3-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox