Linux bluetooth development
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ v1 6/8] shared/gatt-client: Fix parsing Read Multiple Variable Length response
Date: Thu,  5 Nov 2026 17:16:36 -0500	[thread overview]
Message-ID: <20261105221638.2332398-7-luiz.dentz@gmail.com> (raw)
In-Reply-To: <20261105221638.2332398-1-luiz.dentz@gmail.com>

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

The Length Value Tuple loop never advanced past each value, and a
length exceeding the remaining data grew the remaining length instead
of truncating the value, passing data past the end of the PDU to the
callback.

Fixes: 6ea204dca0b2 ("shared/gatt-client: Add support for Read Multiple Variable Length")
Assisted-by: OpenCode:claude-opus-5.5
---
 src/shared/gatt-client.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c
index 2b6da611b9f1..6902903e7b02 100644
--- a/src/shared/gatt-client.c
+++ b/src/shared/gatt-client.c
@@ -2942,9 +2942,12 @@ static void read_multiple_cb(uint8_t opcode, const void *pdu, uint16_t length,
 		 * current ATT_MTU.
 		 */
 		if (len > length)
-			length = len;
+			len = length;
 
 		op->callback(success, att_ecode, pdu, len, op->user_data);
+
+		length -= len;
+		pdu += len;
 	}
 }
 
-- 
2.56.0


  parent reply	other threads:[~2026-11-05 22:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 22:16 [PATCH BlueZ v1 0/8] Fix handling of malformed GATT PDUs Luiz Augusto von Dentz
2026-11-05 22:16 ` [PATCH BlueZ v1 1/8] shared/gatt: Validate Read By Type responses Luiz Augusto von Dentz
2026-11-05 23:40   ` Fix handling of malformed GATT PDUs bluez.test.bot
2026-11-05 22:16 ` [PATCH BlueZ v1 2/8] unit/test-gatt: Add malformed Read By Type response tests Luiz Augusto von Dentz
2026-11-05 22:16 ` [PATCH BlueZ v1 3/8] shared/gatt-client: Fix handling of short notifications Luiz Augusto von Dentz
2026-11-05 22:16 ` [PATCH BlueZ v1 4/8] unit/test-gatt: Add short notification test Luiz Augusto von Dentz
2026-11-05 22:16 ` [PATCH BlueZ v1 5/8] shared/att: Add Read Multiple Variable Length opcodes Luiz Augusto von Dentz
2026-11-05 22:16 ` Luiz Augusto von Dentz [this message]
2026-11-05 22:16 ` [PATCH BlueZ v1 7/8] shared/gatt-client: Check value lengths before reading them Luiz Augusto von Dentz
2026-11-05 22:16 ` [PATCH BlueZ v1 8/8] unit/test-gatt: Add Read Multiple Variable Length tests Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105221638.2332398-7-luiz.dentz@gmail.com \
    --to=luiz.dentz@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox