[PATCH BlueZ v1 07/10] shared/gatt-server: Fix double response on prepare write failure

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

When storing the prepared data fails, prep_write_complete_cb sent an
error response and then also the Prepare Write Response. The error
response also used the response opcode instead of the request opcode.

Send only the error response, with the request opcode.

Fixes: 1ebfc68f ("shared/gatt-server: Request authorization for prepare writes")
Assisted-by: OpenCode:claude-sonnet-5.5
---
 src/shared/gatt-server.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/shared/gatt-server.c b/src/shared/gatt-server.c
index b63745c4df2e..4a6bdb4677ab 100644
--- a/src/shared/gatt-server.c
+++ b/src/shared/gatt-server.c
@@ -1310,10 +1310,15 @@ static void prep_write_complete_cb(struct gatt_db_attribute *attr, int err,
 	}
 
 	if (!store_prep_data(pwcd->server, handle, offset, iov.iov_len,
-							iov.iov_base))
-		bt_att_chan_send_error_rsp(pwcd->chan, BT_ATT_OP_PREP_WRITE_RSP,
+							iov.iov_base)) {
+		bt_att_chan_send_error_rsp(pwcd->chan, BT_ATT_OP_PREP_WRITE_REQ,
 					handle,
 					BT_ATT_ERROR_INSUFFICIENT_RESOURCES);
+		free(pwcd->pdu);
+		free(pwcd);
+
+		return;
+	}
 
 	bt_att_chan_send_rsp(pwcd->chan, BT_ATT_OP_PREP_WRITE_RSP, pwcd->pdu,
 								pwcd->length);
-- 
2.56.0