Linux bluetooth development
 help / color / mirror / Atom feed
From: Kevin Dewald <kevin@simpleble.org>
To: linux-bluetooth@vger.kernel.org
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Kevin Dewald <kevin@simpleble.org>
Subject: [PATCH BlueZ v4 0/4] Bearer.LE1: Add ReadRSSI
Date: Sun, 15 Nov 2026 23:16:17 -0800	[thread overview]
Message-ID: <20261116071622.35355-1-kevin@simpleble.org> (raw)

This adds ReadRSSI to Bearer.LE1 as a testing method, for diagnostics
and production testing, as discussed on v1 [1]. It is only available
when D-Bus testing interfaces are enabled, with bluetoothd -T or
Testing = true in main.conf.

Each call sends Get Connection Information, which the kernel answers
from the controller or with the value it read in the last 1 to 3
seconds. A call made right after Connect returns fails with NotReady
until the kernel has read the remote features.

Changes in v4, from the automated review of v3 [2]:
- Don't cancel a Get Connection Information request that is still
  pending when the bearer is destroyed. The kernel replies to it
  anyway, and shared/mgmt would take that reply for the reply to the
  next request. The request now has its own state, freed by a destroy
  callback btd_adapter_get_conn_info takes, and
  btd_adapter_cancel_request is removed.
- Allocate the queue of pending calls with the request, so it does not
  leak if the bearer interface fails to register.

Changes in v3, from the review of v2 [3]:
- Retry ReadRSSI in the functional test while it fails with NotReady.
- Check that the RSSI is between -127 and 20 dBm instead of the -1 dBm
  of the emulated controller, so the test also passes with real
  controllers.

Changes in v2:
- Make ReadRSSI a testing method and mark it [testing] in the
  documentation.
- Enable testing interfaces on one host in the functional test, and
  check that the other host does not export ReadRSSI.
- Rebase on master.

Tested with the functional test on bluetooth-next 3f425f95ba39, and on
an RTL8761BU connected to an nRF52840: with -T, ReadRSSI returned
-49 dBm; without it, the method was not exported.

The v3 issue was reproduced with three emulated hosts and an emulator
that answers Read RSSI after 1.5 seconds: host0 reads the RSSI of
host1, host1 powers off, host0 removes it and then reads the RSSI of
host2. With v3 that read got the RSSI of host1, and its own reply
was dropped; with v4 it got the RSSI of host2. The reproducer is not
included as it needs the delay in the emulator, but I can send it if
it is useful.

[1] https://lore.kernel.org/linux-bluetooth/20261112032250.37687-1-kevin@simpleble.org/
[2] https://github.com/bluez/bluez/pull/2825
[3] https://lore.kernel.org/linux-bluetooth/20261113051438.75230-1-kevin@simpleble.org/

Kevin Dewald (4):
  org.bluez.Bearer: Add ReadRSSI method
  adapter: Add btd_adapter_get_conn_info
  bearer: Add ReadRSSI method
  test: functional: add bearer ReadRSSI test

 doc/org.bluez.Bearer.LE.rst    |  19 +++++
 src/adapter.c                  |  18 +++++
 src/adapter.h                  |   7 ++
 src/bearer.c                   | 132 ++++++++++++++++++++++++++++++++-
 test/functional/test_bearer.py |  58 +++++++++++++++
 5 files changed, 232 insertions(+), 2 deletions(-)


base-commit: 20ffd285b58facfd1f2478d159a5f941b09d5be1
-- 
2.54.0 (Apple Git-157)


             reply	other threads:[~2026-11-16  7:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:16 Kevin Dewald [this message]
2026-11-16  7:16 ` [PATCH BlueZ v4 1/4] org.bluez.Bearer: Add ReadRSSI method Kevin Dewald
2026-11-16  7:16 ` [PATCH BlueZ v4 2/4] adapter: Add btd_adapter_get_conn_info Kevin Dewald
2026-11-16  7:16 ` [PATCH BlueZ v4 3/4] bearer: Add ReadRSSI method Kevin Dewald
2026-11-16  7:16 ` [PATCH BlueZ v4 4/4] test: functional: add bearer ReadRSSI test Kevin Dewald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116071622.35355-1-kevin@simpleble.org \
    --to=kevin@simpleble.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox