From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.222.180 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794873921; b=X9fN6g80qZklmIAEWoNn48d4lq6bLF3/DxF+tLye6+YnJ4tW3zw8nxtyv0V/LUYC5sO9 ZeUu9r3qSleJ0JWtRGHF2p81Es0AO80zNykZ+FEh5OAGMxl963dsztwpVXcQFiWOiZRLi POu2ImOlRaU1w22wQA0Z78gM14BiG1U+He3jHh8/is8wBH4R4CMu1qEowiXyWVZTKSJDE wh8luoCyO27OLqupXsRBdu81LhI5tqbKbeM1CGZIHW8J/IuUDxtIdPF3cQvFa55N7cNKl +/TXHnDxq7eAL75G8nvYRyZsMdIPaimAIJROZWWEzmPzv6WjXS57taQy/o0dq3b74ew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794873921; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=eMx+CTkXv1VoOtSvi+6D1nYsmWu0vpvPd8N8huVVt6c=; b=pYaD+DkrMxVgmSaYnaKYmqtrMULIAFmDYNpkNe7pMJ5eXcDu4qP2dWh7kxSo5PiZeGK0 huJkwP6VosWTJdljgpW0bykRRuq5KfzWcP6+3SACmX6D9EWVh0eEX9Ac2ev2sz+zQ7eop p0TImQfQXSBC+jZ0N10mfjHcp3ZKT3F4Cs9ZTQgvMKiwliQwk7EXDsYW2peNyVBPHloai trXhTSuE4WXJ6xBgXDiGvgwX7wf8aaQbfY7Dfty/23ROcY4b3xta3tnnFDIWd1W7KEUTI 21brs4faW2of057Q0ZqobEW1dO0Y1ereb5WW8ZvzHhu2ert93MthhC84ykndVK5qO1A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=o+1molFf; arc=none smtp.remote-ip=209.85.222.180 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37EB9606A334 for ; Tue, 17 Nov 2026 00:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 37EB9606A334 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=o+1molFf Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-949589c1495so334703085a.3 for ; Mon, 16 Nov 2026 16:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1794873920; x=1795478720; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=eMx+CTkXv1VoOtSvi+6D1nYsmWu0vpvPd8N8huVVt6c=; b=o+1molFffc9e6T9ddIDnNeseSjzEf2bQKujHs4vpOVw4OzSSGS4YQo8BJrSN9kd667 k9JFBOotGGRYa0PkAFx2E0FiQp1pgsnwgn6pcnUL3Eya4+1ObVIZXwVWtTnGOXsLpAKM Qm4w4F5jBIoZdwaJAnrycuNhvr/nMKvlaRPWeoY+KemZwqtCHlIRV3pKlOZAan8ZiPyk dg+rWFVtziAEodqueYjujOY8FQIiLOIqi0nCOki4SNuEx/vo4myxz/px2YhfTxnQyYx8 5SnT2fX1BMMsw9KBqqyDMrnK6kEETUe11lAAN+nPzvpxO9VlnJiaiLVZSGU+NSdcdbag q8ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794873920; x=1795478720; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eMx+CTkXv1VoOtSvi+6D1nYsmWu0vpvPd8N8huVVt6c=; b=EI9BlMqAc5V8e+Q6Oq02q4zvzo4RYeQOVLZ2/R1hpelB/o+Jc/DOcycxDicebCLuAh Ky7DWouW/uwTjRypW/3uyvid+5fPrEAQISpOCOwCHPAmuaFSKTvO6j05cMA0rFpXchob jm3ITclFSrVustJgiKL7/2fGYi2jlEm3oJBRlZ7yGZZqowxLyAA5UBdP2i63dRG/VIoc Vq4avJw8SAh4hGymsuTptZGvTrnov/uHdNyBfA7adxJArojVY4FT0tx9p4F2GwjRuhTV YZTodXgVPFdoPd/+1iH8ld0DKPberrr24jfbp7/XvoN6DO6PbAoQ18KBhymC3ZU0re3R kQ9A== X-Forwarded-Encrypted: i=1; AL+hErESX8wjLLLFKJc2YSdttVwcwHenM4QpFGxMA/qRi1VcK5bgBGHUZsWbmyfA+B4SLyMSQYOfAQcTyaFjzt/eCRg=@vger.kernel.org X-Gm-Message-State: APuU4Z/su3XtBqLiPiWZ8YqBO5IN1Ahyg6Gx9F23qIc50mNHcaFu3Nh8 3VOkVn3qZ5t37Ohzk7YSvBRcOoeX3GrDaBf+Fyj+tkyd94dzR75TeuOETsv3YrfYPCs= X-Gm-Gg: AYBFou3p4u/Hm1lWtn+hizrO8jAuDRA/oZXWCd7ojsZHGaCF+MAtMyTUmFd6O2cCEE2 fQ+Lt7gr//+r7wLAJdEG6+gGByiTbdhnOPyqaBsguOgcvUiLJ+JnA0QxR6UNp07d7ripTustWuo cXbi3dDmidFVoppNm46IMGxp5dYhVJ/TG3G2xTu33imHsWmGXDST6znU/hbNwRDicCAJs758wVU WPVo1STuK/F3KHFaZ7KRW/8cbMca722nhLpVNmsbjNdFnKEc+4gYLsVlQIFlaQzvQTGUKuvcOpj Yv42VrKn2jfpDXbiefYfMjFl9Yr2DpCV0lZZzG8hJr7uhhgzg1tXgaIzKV+y1isXxPnSmww9zzM Mwf39kHUgzV7TYNKFVFsjsDOnDtltTDX7Dpt4NZ/QCv0kaYlQE7BnsnnNimNVyBzca8F5AinLZK UhdiahExjjcGwippZG+iteRP+K+uyoZZ4JDJkSc0vHYehkBSTF5Y1uxpyoOhaTpfNYgFlO3ZbEY cFY+Bxnhzu6PDVkHH1B5YI93rZUn7suP/1r/yIrXhFxgE/3VSgqmS9voQ23bGc6Eku7fvJ9fbmS OUvLdA== X-Received: by 2002:a05:620a:aa0b:b0:949:7473:b1a5 with SMTP id af79cd13be357-9497473c077mr807892285a.55.1794873920005; Mon, 16 Nov 2026 16:05:20 -0800 (PST) Received: from ziepe.ca ([142.166.156.71]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9494c8b889csm969866585a.32.2026.11.16.16.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 16:05:10 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xT6h7-0000000Apgy-1pGN; Mon, 16 Nov 2026 20:05:05 -0400 Date: Mon, 16 Nov 2026 20:05:05 -0400 From: Jason Gunthorpe To: Robin Murphy Cc: Leon Romanovsky , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Dmitry Torokhov , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Johannes Berg , Jonathan Corbet , Shuah Khan , Randy Dunlap , Bjorn Helgaas , "Joerg Roedel (AMD)" , Suravee Suthikulpanit , Vasant Hegde , Will Deacon , David Woodhouse , Lu Baolu , Johan Hovold , Eric Dumazet , Marcel Holtmann , Luiz Augusto von Dentz , Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [PATCH v2 18/19] PCI: Replace untrusted state with device trust Message-ID: <20261117000505.GA2488304@ziepe.ca> References: <20261109-device-trust-core-v2-0-3b12d9a9f861@nvidia.com> <20261109-device-trust-core-v2-18-3b12d9a9f861@nvidia.com> <20261110122237.GG8635@unreal> X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 16, 2026 at 05:13:59PM +0000, Robin Murphy wrote: > Even with the slightly dubious argument that this series only intends to > shuffle the existing PCI code around rather than fully introduce the generic > abstraction that it claims to, if the PCI behaviour is still just based on > propagating the internal "untrusted" flag plus the new global override, both > of which *are* known at add_device time into the common trust state, then > there seems little excuse for not doing that up-front so that the new API > *can* just work as expected. The desired iommu flow is to start out as blocking and create the default domain only right before driver binding when we have the correct trust level. If we try to do that without this series then we have to do it all the time, which I'm really scared will break some embedded thing that expects scanout to work or something like that. My hope was this becomes opt-in based on the new command line stuff in this series. On the other hand this series works properly on systems without an iommu, which is pretty much all CC VMs today. There are probably around 15 series to complete all of this PCI device attestation. Without everything it isn't really usable, IMHO. I'm not that worried about the series ordering. > > We have two levels: policy - that describes the default of all devices > > for that bus. level - actual decision on how that device is going to be > > operated. > > > > "Disabled" prevents driver probing until the device is authorized, > > "Adversary" permits probing and requests the available protections > > for operating an untrusted device. > > > > Both need conservative initial IOMMU setup: a disabled device may later > > be authorized as adversary, and authorization does not rebuild its IOMMU > > domain. > > Urgh, I can be absolutely certain I'm not the only one who is going to be > confused this way... I see "disabled" and instinctively take it to mean > disabling the device_trust *mechanism*, as the logical thing that people > will reach for in terms of "I don't care what this new thing is, just get it > out of my way and let my drivers work like they always used to; I want to > disable the new thing." Maybe "isolated" is a better word? Jason